From 0a6eefe5c1c9408ed9a413d78a85056218e2a4b8 Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Sat, 2 Nov 2013 01:45:55 -0700 Subject: [PATCH] [#1718] order of operations on group check. (false && false || true) == true... am I just a n00b? --- src/controllers/groups.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/groups.js b/src/controllers/groups.js index 64a8486dce..05fb72c79b 100644 --- a/src/controllers/groups.js +++ b/src/controllers/groups.js @@ -124,7 +124,7 @@ api.get = function(req, res) { var q = (gid == 'party') ? Group.findOne({type: 'party', members: {'$in': [user._id]}}) : Group.findById(gid); populateQuery(gid, q); q.exec(function(err, group){ - if ( group && (group.type == 'guild' && group.privacy == 'private') || (group.type == 'party')) { + if (group && ((group.type == 'guild' && group.privacy == 'private') || (group.type == 'party'))) { if(!_.find(group.members, {_id: user._id})) return res.json(401, {err: "You don't have access to this group"}); }