diff --git a/website/src/models/group.js b/website/src/models/group.js index ab4c468248..6bb2c15aa3 100644 --- a/website/src/models/group.js +++ b/website/src/models/group.js @@ -193,13 +193,13 @@ GroupSchema.methods.finishQuest = function(quest, cb) { mongoose.model('User').update(q, updates, {multi:true}, cb); } -function isOnQuest(user,progress,group){ - return group && progress && user.party.quest.key && group.quest && user.party.quest.key == group.quest.key && group.quest.active; +function isOnQuest(progress,group){ + return group && progress && group.quest && group.quest.active; } GroupSchema.statics.collectQuest = function(user, progress, cb) { this.findOne({type: 'party', members: {'$in': [user._id]}},function(err, group){ - if (!isOnQuest(user,progress,group)) return cb(null); + if (!isOnQuest(progress,group)) return cb(null); var quest = shared.content.quests[group.quest.key]; _.each(progress.collect,function(v,k){ @@ -302,7 +302,7 @@ GroupSchema.statics.tavernBoss = function(user,progress) { GroupSchema.statics.bossQuest = function(user, progress, cb) { this.findOne({type: 'party', members: {'$in': [user._id]}},function(err, group){ - if (!isOnQuest(user,progress,group)) return cb(null); + if (!isOnQuest(progress,group)) return cb(null); var quest = shared.content.quests[group.quest.key]; if (!progress || !quest) return cb(null); // FIXME why is this ever happening, progress should be defined at this point var down = progress.down * quest.boss.str; // multiply by boss strength