Group approval ui (#8184)

* Added all ui components back

* Added group ui items back and initial group approval directive

* Added ability to mark tasks as requires approval. Added approvals ctrl. Added get approvals method to tasks service

* Added approval list view with approving functionality

* Added error to produce message when task requests approval

* Added notification display for group approvals

* Fixed notification read and adding task

* Fixed syncing with group approval required

* Added group id to notifications for redirect on client side

* Fixed approval request tests

* Fixed linting issues

* Removed expectation from beforeEach

* Moved string to locale

* Added eslint ignore

* Updated notification for group approved, added new icons, and updated styles

* Hid group plan ui

test/api/v3/integration/tasks/groups/GET-approvals_group_id.test.js

@@ -34,7 +34,12 @@ describe('GET /approvals/group/:groupId', () => {
 
     let memberTasks = await member.get('/tasks/user');
     syncedTask = find(memberTasks, findAssignedTask);
-    await member.post(`/tasks/${syncedTask._id}/score/up`);
+
+    try {
+      await member.post(`/tasks/${syncedTask._id}/score/up`);
+    } catch (e) {
+      // eslint-disable-next-line no-empty
+    }
   });
 
   it('errors when user is not the group leader', async () => {

test/api/v3/integration/tasks/groups/POST-group_tasks_id_approve_userId.test.js

@@ -60,7 +60,7 @@ describe('POST /tasks/:id/approve/:userId', () => {
     await member.sync();
 
     expect(member.notifications.length).to.equal(1);
-    expect(member.notifications[0].type).to.equal('GROUP_TASK_APPROVAL');
+    expect(member.notifications[0].type).to.equal('GROUP_TASK_APPROVED');
     expect(member.notifications[0].data.message).to.equal(t('yourTaskHasBeenApproved'));
 
     expect(syncedTask.group.approval.approved).to.be.true;

test/api/v3/integration/tasks/groups/POST-group_tasks_id_score_direction.test.js

@@ -37,7 +37,12 @@ describe('POST /tasks/:id/score/:direction', () => {
     let memberTasks = await member.get('/tasks/user');
     let syncedTask = find(memberTasks, findAssignedTask);
 
-    let response = await member.post(`/tasks/${syncedTask._id}/score/up`);
+    await expect(member.post(`/tasks/${syncedTask._id}/score/up`))
+      .to.eventually.be.rejected.and.to.eql({
+        code: 401,
+        error: 'NotAuthorized',
+        message: t('taskApprovalHasBeenRequested'),
+      });
     let updatedTask = await member.get(`/tasks/${syncedTask._id}`);
 
     await user.sync();
@@ -48,8 +53,8 @@ describe('POST /tasks/:id/score/:direction', () => {
       user: member.auth.local.username,
       taskName: updatedTask.text,
     }));
+    expect(user.notifications[0].data.groupId).to.equal(guild._id);
 
-    expect(response.message).to.equal(t('taskApprovalHasBeenRequested'));
     expect(updatedTask.group.approval.requested).to.equal(true);
     expect(updatedTask.group.approval.requestedDate).to.be.a('string'); // date gets converted to a string as json doesn't have a Date type
   });
@@ -58,7 +63,12 @@ describe('POST /tasks/:id/score/:direction', () => {
     let memberTasks = await member.get('/tasks/user');
     let syncedTask = find(memberTasks, findAssignedTask);
 
-    await member.post(`/tasks/${syncedTask._id}/score/up`);
+    await expect(member.post(`/tasks/${syncedTask._id}/score/up`))
+      .to.eventually.be.rejected.and.to.eql({
+        code: 401,
+        error: 'NotAuthorized',
+        message: t('taskApprovalHasBeenRequested'),
+      });
 
     await expect(member.post(`/tasks/${syncedTask._id}/score/up`))
       .to.eventually.be.rejected.and.eql({

test/api/v3/unit/models/group_tasks.test.js

@@ -107,6 +107,7 @@ describe('Group Task Methods', () => {
 
         let updatedTaskName = 'Update Task name';
         task.text = updatedTaskName;
+        task.group.approval.required = true;
 
         await guild.updateTask(task);
 
@@ -121,10 +122,12 @@ describe('Group Task Methods', () => {
         expect(task.group.assignedUsers).to.contain(leader._id);
         expect(syncedTask).to.exist;
         expect(syncedTask.text).to.equal(task.text);
+        expect(syncedTask.group.approval.required).to.equal(true);
 
         expect(task.group.assignedUsers).to.contain(newMember._id);
         expect(syncedMemberTask).to.exist;
         expect(syncedMemberTask.text).to.equal(task.text);
+        expect(syncedMemberTask.group.approval.required).to.equal(true);
       });
 
       it('removes an assigned task and unlinks assignees', async () => {