From 23da70fa2e8d759db5222aac659ed12436fecee2 Mon Sep 17 00:00:00 2001
From: negue <negue@users.noreply.github.com>
Date: Sun, 13 Nov 2022 20:38:14 +0100
Subject: [PATCH] extract save / cancel buttons and the shared inlineSetting
 "logic"

---
 .../inlineSettings/_inlineSettingMixin.js     | 12 ++++++
 .../inlineSettings/_saveCancelButtons.vue     | 41 ++++++++++++++++++
 .../inlineSettings/userNameSetting.vue        | 42 +++++--------------
 3 files changed, 63 insertions(+), 32 deletions(-)
 create mode 100644 website/client/src/pages/settings/inlineSettings/_inlineSettingMixin.js
 create mode 100644 website/client/src/pages/settings/inlineSettings/_saveCancelButtons.vue

diff --git a/website/client/src/pages/settings/inlineSettings/_inlineSettingMixin.js b/website/client/src/pages/settings/inlineSettings/_inlineSettingMixin.js
new file mode 100644
index 0000000000..b6f0b1f7de
--- /dev/null
+++ b/website/client/src/pages/settings/inlineSettings/_inlineSettingMixin.js
@@ -0,0 +1,12 @@
+export const _InlineSettingMixin = {
+  data () {
+    return {
+      show: false,
+    };
+  },
+  methods: {
+    resetAndClose () {
+      this.show = false;
+    },
+  },
+};
diff --git a/website/client/src/pages/settings/inlineSettings/_saveCancelButtons.vue b/website/client/src/pages/settings/inlineSettings/_saveCancelButtons.vue
new file mode 100644
index 0000000000..f4e82b1db4
--- /dev/null
+++ b/website/client/src/pages/settings/inlineSettings/_saveCancelButtons.vue
@@ -0,0 +1,41 @@
+<template>
+  <div class="buttons">
+    <button
+      class="btn btn-primary btn-save"
+      type="submit"
+      :disabled="disableSave"
+      @click="$emit('saveClicked')"
+    >
+      {{ $t('save') }}
+    </button>
+    <br>
+
+    <a
+      class="edit-link"
+      @click.prevent="$emit('cancelClicked')"
+    >
+      {{ $t('cancel') }}
+    </a>
+  </div>
+</template>
+
+<script>
+export default {
+  name: 'SaveCancelButtons',
+  props: ['disableSave'],
+};
+</script>
+
+<style scoped>
+
+.buttons {
+  align-items: center;
+  display: flex;
+  flex-direction: column;
+}
+
+
+.btn-save {
+  margin-bottom: 1rem;
+}
+</style>
diff --git a/website/client/src/pages/settings/inlineSettings/userNameSetting.vue b/website/client/src/pages/settings/inlineSettings/userNameSetting.vue
index 0ce0bf3f1e..6d68e4d4b1 100644
--- a/website/client/src/pages/settings/inlineSettings/userNameSetting.vue
+++ b/website/client/src/pages/settings/inlineSettings/userNameSetting.vue
@@ -14,7 +14,7 @@
           class="edit-link"
           @click.prevent="show = true"
         >
-          {{ $t('edit') }}
+          {{ $t(user?.auth?.local?.username ? 'edit' : 'add') }}
         </a>
       </td>
     </tr>
@@ -71,24 +71,11 @@
             </div>
           </div>
 
-          <div class="buttons">
-            <button
-              class="btn btn-primary btn-save"
-              type="submit"
-              :disabled="usernameCannotSubmit"
-              @click="changeUser('username', cleanedInputValue)"
-            >
-              {{ $t('save') }}
-            </button>
-            <br>
-
-            <a
-              class="edit-link"
-              @click.prevent="resetAndClose()"
-            >
-              {{ $t('cancel') }}
-            </a>
-          </div>
+          <save-cancel-buttons
+            :disable-save="usernameCannotSubmit"
+            @saveClicked="changeUser('username', cleanedInputValue)"
+            @cancelClicked="resetAndClose()"
+          />
         </div>
       </td>
     </tr>
@@ -137,19 +124,10 @@ input {
   color: $green-50;
 }
 
-.buttons {
-  align-items: center;
-  display: flex;
-  flex-direction: column;
-}
-
 .form-group {
   margin-bottom: 1.5rem;
 }
 
-.btn-save {
-  margin-bottom: 1rem;
-}
 </style>
 
 <script>
@@ -158,11 +136,14 @@ import debounce from 'lodash/debounce';
 import { mapState } from '@/libs/store';
 
 import checkIcon from '@/assets/svg/check.svg';
+import { _InlineSettingMixin } from './_inlineSettingMixin';
+import SaveCancelButtons from '@/pages/settings/inlineSettings/_saveCancelButtons';
 
 export default {
+  components: { SaveCancelButtons },
+  mixins: [_InlineSettingMixin],
   data () {
     return {
-      show: false,
       inputValue: '',
       usernameIssues: [],
       icons: Object.freeze({
@@ -210,9 +191,6 @@ export default {
     this.restoreEmptyUsername();
   },
   methods: {
-    resetAndClose () {
-      this.show = false;
-    },
     restoreEmptyUsername () {
       if (this.inputValue.length < 1) {
         this.inputValue = `@${this.user.auth.local.username}`;