Merge branch 'TheHollidayInn-markdown-for-spells' into develop

2015-06-02 07:58:29 -05:00
parent 879c8c5428 b375c068de
commit 24c299783a
5 changed files with 400 additions and 105 deletions
@@ -1,9 +1,14 @@
 'use strict';

-//TODO mock bootstrapGrowl, add remaining tests
 describe('notificationServices', function() {
  var notification;

+  before(function(){
+    sinon.stub($, 'pnotify', function(){
+      return { click: function(){}}
+    });
+  });
+
  beforeEach(function() {
    module(function($provide){
      $provide.value('User', {});
@@ -14,12 +19,190 @@ describe('notificationServices', function() {
    });
  });

+  afterEach(function() {
+    $.pnotify.reset();
+  });
+
  it('notifies coins amount', function() {
    var SILVER_COIN = "<span class='notification-icon shop_silver'></span>";
    var GOLD_COIN = "<span class='notification-icon shop_gold'></span>";
+
+    expect(notification.coins(0)).to.not.exist;
    expect(notification.coins(0.01)).to.eql("1 " + SILVER_COIN);
    expect(notification.coins(0.1)).to.eql("10 " + SILVER_COIN);
    expect(notification.coins(1)).to.eql("1 " + GOLD_COIN);
    expect(notification.coins(12.34)).to.eql("12 " + GOLD_COIN +" 33 " + SILVER_COIN);
  });
+
+  it('sends crit notification', function() {
+    notification.crit(5);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('crit');
+    expect(arg.text).to.eql('Critical Hit! Bonus: 5%');
+    expect(arg.icon).to.eql('glyphicon glyphicon-certificate');
+  });
+
+  it('sends drop notification for unspecified item', function() {
+    notification.drop('msg');
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('drop');
+    expect(arg.text).to.eql('msg');
+    expect(arg.icon).to.eql(false);
+  });
+
+  it('sends drop notification for Egg', function() {
+    var item = { type: 'Egg', key: 'wolf' };
+    notification.drop('msg', item);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('drop');
+    expect(arg.text).to.eql('msg');
+    expect(arg.icon).to.eql('Pet_Egg_wolf');
+  });
+
+  it('sends drop notification for Hatching Potion', function() {
+    var item = { type: 'HatchingPotion', key: 'red' };
+    notification.drop('msg', item);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('drop');
+    expect(arg.text).to.eql('msg');
+    expect(arg.icon).to.eql('Pet_HatchingPotion_red');
+  });
+
+  it('sends drop notification for Food', function() {
+    var item = { type: 'Food', key: 'meat' };
+    notification.drop('msg', item);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('drop');
+    expect(arg.text).to.eql('msg');
+    expect(arg.icon).to.eql('Pet_Food_meat');
+  });
+
+  it('does not send exp notification if val < -50', function() {
+    notification.exp(-51);
+    expect($.pnotify).to.not.have.been.called;
+  });
+
+  it('send exp notification if val >= -50', function() {
+    notification.exp(50);
+    notification.exp(0);
+    notification.exp(-50);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledThrice;
+    expect(arg.type).to.eql('xp');
+    expect(arg.text).to.eql('+ 50 XP');
+    expect(arg.icon).to.eql('glyphicon glyphicon-star');
+  });
+
+  it('send exp notification with rounded value', function() {
+    notification.exp(50.23333);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('xp');
+    expect(arg.text).to.eql('+ 50.2 XP');
+    expect(arg.icon).to.eql('glyphicon glyphicon-star');
+  });
+
+  it('send error notification', function() {
+    notification.error('there was an error');
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('danger');
+    expect(arg.text).to.eql('there was an error');
+    expect(arg.icon).to.eql('glyphicon glyphicon-exclamation-sign');
+  });
+
+  it('send gp gained notification', function() {
+    notification.gp(50, 4);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('gp');
+    expect(arg.text).to.eql('+ 46 <span class=\'notification-icon shop_gold\'></span>');
+    expect(arg.icon).to.eql(false);
+  });
+
+  it('send hp notification', function() {
+    notification.hp(10);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('hp');
+    expect(arg.text).to.eql('+ 10 HP');
+    expect(arg.icon).to.eql('glyphicon glyphicon-heart');
+  });
+
+  it('send level up notification', function() {
+    notification.lvl(10);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('lvl');
+    expect(arg.text).to.eql('Level Up!');
+    expect(arg.icon).to.eql('glyphicon glyphicon-chevron-up');
+  });
+
+  it('send markdown parsed notification', function() {
+    notification.markdown(":smile: - task name");
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('info');
+    expect(arg.text).to.eql('<p><span class="emoji" style="background-image:url(common/img/emoji/unicode/1f604.png)">:smile:</span> - task name</p>\n');
+    expect(arg.icon).to.eql(false);
+  });
+
+  it('does not send markdown notification if no text is given', function() {
+    notification.markdown();
+
+    expect($.pnotify).to.not.have.been.called;
+  });
+
+  it('send mp notification', function() {
+    notification.mp(10);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('mp');
+    expect(arg.text).to.eql('+ 10 MP');
+    expect(arg.icon).to.eql('glyphicon glyphicon-fire');
+  });
+
+  it('send streak notification', function() {
+    notification.streak(10);
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('streak');
+    expect(arg.text).to.eql('Streak Achievements: 10');
+    expect(arg.icon).to.eql('glyphicon glyphicon-repeat');
+  });
+
+  it('send text notification', function() {
+    notification.text('task name');
+    var arg = $.pnotify.args[0][0]
+
+    expect($.pnotify).to.have.been.calledOnce;
+    expect(arg.type).to.eql('info');
+    expect(arg.text).to.eql('task name');
+    expect(arg.icon).to.eql(false);
+  });
+
+  it('does not send text notification if no text is given', function() {
+    notification.text();
+
+    expect($.pnotify).to.not.have.been.called;
+  });
 });
@@ -1,38 +1,112 @@
 'use strict';

-// @TODO: Something here is calling a full page reload
 describe('Root Controller', function() {
-  var scope, user, ctrl;
+  var scope, rootscope, user, User, notification, ctrl, $httpBackend;

  beforeEach(function () {
    module(function($provide) {
      $provide.value('User', {});
    });

-    inject(function($rootScope, $controller) {
+    inject(function($rootScope, $controller, _$httpBackend_, Notification) {
      scope = $rootScope.$new();
-      scope.loginUsername = 'user'
-      scope.loginPassword = 'pass'
-      user = specHelper.newUser();
+      scope.loginUsername = 'user';
+      scope.loginPassword = 'pass';

-      ctrl = $controller('RootCtrl', {$scope: scope, User: {user: user}});
+      rootscope = $rootScope;
+
+      $httpBackend = _$httpBackend_;
+
+      notification = Notification;
+      sinon.stub(notification, 'text')
+
+      user = specHelper.newUser();
+      User = {user: user};
+      User.save = sinon.spy();
+      User.sync = sinon.spy();
+
+      ctrl = $controller('RootCtrl', {$scope: scope, User: User});
    });
  });

-  it('shows contributor level text', function(){
-    expect(scope.contribText()).to.eql(undefined);
-    expect(scope.contribText(null, {npc: 'NPC'})).to.eql('NPC');
-    expect(scope.contribText({level: 0, text: 'Blacksmith'})).to.eql(undefined);
-    expect(scope.contribText({level: 1, text: 'Blacksmith'})).to.eql('Friend Blacksmith');
-    expect(scope.contribText({level: 2, text: 'Blacksmith'})).to.eql('Friend Blacksmith');
-    expect(scope.contribText({level: 3, text: 'Blacksmith'})).to.eql('Elite Blacksmith');
-    expect(scope.contribText({level: 4, text: 'Blacksmith'})).to.eql('Elite Blacksmith');
-    expect(scope.contribText({level: 5, text: 'Blacksmith'})).to.eql('Champion Blacksmith');
-    expect(scope.contribText({level: 6, text: 'Blacksmith'})).to.eql('Champion Blacksmith');
-    expect(scope.contribText({level: 7, text: 'Blacksmith'})).to.eql('Legendary Blacksmith');
-    expect(scope.contribText({level: 8, text: 'Blacksmith'})).to.eql('Guardian Blacksmith');
-    expect(scope.contribText({level: 9, text: 'Blacksmith'})).to.eql('Heroic Blacksmith');
-    expect(scope.contribText({level: 9, text: 'Blacksmith'}, {npc: 'NPC'})).to.eql('NPC');
+  afterEach(function() {
+    notification.text.reset();
+    User.save.reset();
+    User.sync.reset();
  });

+  describe('contribText', function(){
+    it('shows contributor level text', function(){
+      expect(scope.contribText()).to.eql(undefined);
+      expect(scope.contribText(null, {npc: 'NPC'})).to.eql('NPC');
+      expect(scope.contribText({level: 0, text: 'Blacksmith'})).to.eql(undefined);
+      expect(scope.contribText({level: 1, text: 'Blacksmith'})).to.eql('Friend Blacksmith');
+      expect(scope.contribText({level: 2, text: 'Blacksmith'})).to.eql('Friend Blacksmith');
+      expect(scope.contribText({level: 3, text: 'Blacksmith'})).to.eql('Elite Blacksmith');
+      expect(scope.contribText({level: 4, text: 'Blacksmith'})).to.eql('Elite Blacksmith');
+      expect(scope.contribText({level: 5, text: 'Blacksmith'})).to.eql('Champion Blacksmith');
+      expect(scope.contribText({level: 6, text: 'Blacksmith'})).to.eql('Champion Blacksmith');
+      expect(scope.contribText({level: 7, text: 'Blacksmith'})).to.eql('Legendary Blacksmith');
+      expect(scope.contribText({level: 8, text: 'Blacksmith'})).to.eql('Guardian Blacksmith');
+      expect(scope.contribText({level: 9, text: 'Blacksmith'})).to.eql('Heroic Blacksmith');
+      expect(scope.contribText({level: 9, text: 'Blacksmith'}, {npc: 'NPC'})).to.eql('NPC');
+    });
+  });
+
+  describe('castEnd', function(){
+    var task_target, type;
+
+    beforeEach(function(){
+      task_target = { id: 'task-id' };
+      type = 'task';
+      scope.spell = {
+        target: 'task',
+        key: 'fireball',
+        mana: 10,
+        text: env.t('spellWizardFireballText'),
+        cast: function(){}
+      };
+      rootscope.applyingAction = true;
+    });
+
+    context('fails', function(){
+      it('exits early if there is no applying action', function(){
+        rootscope.applyingAction = null;
+        expect(scope.castEnd(task_target, type)).to.be.eql('No applying action');
+      });
+
+      it('sends notification if target is invalid', function(){
+        scope.spell.target = 'not_the_same_target';
+
+        scope.castEnd(task_target, type)
+
+        notification.text.should.have.been.calledWith(window.env.t('invalidTarget'));
+      });
+    });
+
+    context('succeeds', function(){
+      it('sets scope.spell and rootScope.applyingAction to falsy values', function(){
+
+        scope.castEnd(task_target, type)
+
+        expect(rootscope.applyingAction).to.eql(false);
+        expect(scope.spell).to.eql(null);
+      });
+
+      it('calls $scope.spell.cast', function(){
+        // Kind of a hack, would prefer to use sinon.spy,
+        // but scope.spell gets turned to null in scope.castEnd
+        var spellWasCast = false;
+        scope.spell.cast = function(){ spellWasCast = true };
+
+        scope.castEnd(task_target, type)
+
+        expect(spellWasCast).to.eql(true);
+      });
+
+      it('calls cast endpoint');
+
+      it('sends notification that spell was cast');
+    });
+  });
 });