diff --git a/test/api/v3/integration/tasks/PUT-tasks_id.test.js b/test/api/v3/integration/tasks/PUT-tasks_id.test.js index 0608fa5174..c5bc5d050f 100644 --- a/test/api/v3/integration/tasks/PUT-tasks_id.test.js +++ b/test/api/v3/integration/tasks/PUT-tasks_id.test.js @@ -79,7 +79,7 @@ describe('PUT /tasks/:id', () => { let id2 = generateUUID(); let savedDaily = await user.put(`/tasks/${daily._id}`, { - checklist: [ + reminders: [ {id: id1, time: new Date(), startDate: new Date()}, {id: id2, time: new Date(), startDate: new Date()}, ], diff --git a/test/api/v3/integration/tasks/checklists/PUT-tasks_taskId_checklist_itemId.test.js b/test/api/v3/integration/tasks/checklists/PUT-tasks_taskId_checklist_itemId.test.js index 3f375c3c77..dee75ed914 100644 --- a/test/api/v3/integration/tasks/checklists/PUT-tasks_taskId_checklist_itemId.test.js +++ b/test/api/v3/integration/tasks/checklists/PUT-tasks_taskId_checklist_itemId.test.js @@ -25,7 +25,7 @@ describe('PUT /tasks/:taskId/checklist/:itemId', () => { savedTask = await user.put(`/tasks/${task._id}/checklist/${savedTask.checklist[0]._id}`, { text: 'updated', completed: true, - _id: 123, + _id: 123, // ignored }); expect(savedTask.checklist.length).to.equal(1); diff --git a/website/src/controllers/api-v3/tasks.js b/website/src/controllers/api-v3/tasks.js index 20ae68739e..fcb95bd3d7 100644 --- a/website/src/controllers/api-v3/tasks.js +++ b/website/src/controllers/api-v3/tasks.js @@ -570,7 +570,7 @@ api.addChecklistItem = { if (task.type !== 'daily' && task.type !== 'todo') throw new BadRequest(res.t('checklistOnlyDailyTodo')); - task.checklist.push(Tasks.Task.sanitizeChecklist(req.body)); + task.checklist.push(Tasks.Task.sanitizeChecklist(req.body)); // TODO why not allow to supply _id on creation? let savedTask = await task.save(); res.respond(200, savedTask); // TODO what to return diff --git a/website/src/models/task.js b/website/src/models/task.js index e35f9a155a..a3e657605d 100644 --- a/website/src/models/task.js +++ b/website/src/models/task.js @@ -70,7 +70,7 @@ TaskSchema.statics.sanitizeChecklist = function sanitizeChecklist (checklistObj) }; // Sanitize reminder objects (disallowing id) -TaskSchema.statics.sanitizeChecklist = function sanitizeChecklist (reminderObj) { +TaskSchema.statics.sanitizeReminder = function sanitizeReminder (reminderObj) { delete reminderObj.id; return reminderObj; };