From 2e0723f1b94595bd6a6d816abf9bf137f7241c75 Mon Sep 17 00:00:00 2001
From: SabreCat <sabe@habitica.com>
Date: Thu, 7 Sep 2023 15:37:59 -0500
Subject: [PATCH] feat(moderation): unflag profile Also a few stylistic tweaks

---
 website/client/src/assets/scss/button.scss    |  4 +-
 .../components/members/reportMemberModal.vue  | 47 ++++++++++++++++---
 website/client/src/store/actions/members.js   |  8 +++-
 website/server/controllers/api-v3/members.js  | 44 +++++++++++++++++
 4 files changed, 93 insertions(+), 10 deletions(-)

diff --git a/website/client/src/assets/scss/button.scss b/website/client/src/assets/scss/button.scss
index d9f9464660..a3ccbbde2c 100644
--- a/website/client/src/assets/scss/button.scss
+++ b/website/client/src/assets/scss/button.scss
@@ -5,8 +5,8 @@
   font-weight: bold;
   line-height: 1.71;
   border: 1px solid transparent;
-  padding: 0.219rem 0.75rem;
-  border-radius: 2px;
+  padding: 4px 12px;
+  border-radius: 4px;
   box-shadow: 0 1px 3px 0 rgba($black, 0.12), 0 1px 2px 0 rgba($black, 0.24);
   color: $white;
 
diff --git a/website/client/src/components/members/reportMemberModal.vue b/website/client/src/components/members/reportMemberModal.vue
index 23c51da78e..b029966cdb 100644
--- a/website/client/src/components/members/reportMemberModal.vue
+++ b/website/client/src/components/members/reportMemberModal.vue
@@ -20,7 +20,7 @@
         <strong>{{ $t('whyReportingPlayer') }}</strong>
         <textarea
           v-model="reportComment"
-          class="form-control"
+          class="mt-2 form-control"
           :placeholder="$t('whyReportingPlayerPlaceholder')"
         ></textarea>
       </div>
@@ -31,7 +31,9 @@
     </div>
     <div class="footer text-center d-flex flex-column">
       <button
-        class="btn btn-danger mx-auto px-3 mb-4"
+        class="btn btn-danger mx-auto mb-3"
+        :disabled="!reportComment"
+        :class="{ disabled: !reportComment }"
         @click="reportAbuse()"
       >
         {{ $t('report') }}
@@ -44,7 +46,17 @@
     <div
       slot="modal-footer"
     >
-      <a class="mx-auto">Reset Flags</a>
+      <div
+        class="d-flex"
+        @click="resetFlags()"
+      >
+        <div
+          v-once
+          class="svg-icon icon-16 color my-auto mr-2"
+          v-html="icons.report"
+        ></div>
+        <a>Reset Flags</a>
+      </div>
     </div>
   </b-modal>
 </template>
@@ -60,13 +72,16 @@
       padding: 0px 24px 24px 24px;
     }
     .modal-footer {
+      color: $maroon-50;
       display: flex;
       justify-content: center;
       border-top: none;
       height: 48px;
       background-color: rgba($red-500, 0.25);
       margin-top: -8px;
+      padding: 0px;
       a {
+        margin-top: 2px;
         color: $maroon-50;
       }
     }
@@ -84,7 +99,7 @@
   }
 
   blockquote {
-    border-radius: 2px;
+    border-radius: 4px;
     background-color: $gray-700;
     padding: .5rem 1rem;
   }
@@ -107,6 +122,7 @@ import closeX from '@/components/ui/closeX';
 import notifications from '@/mixins/notifications';
 import markdownDirective from '@/directives/markdown';
 import { userStateMixin } from '../../mixins/userState';
+import report from '@/assets/svg/report.svg';
 
 export default {
   components: {
@@ -128,6 +144,9 @@ export default {
       displayName: '',
       username: '',
       reportComment: '',
+      icons: Object.freeze({
+        report,
+      }),
     };
   },
   mounted () {
@@ -141,15 +160,18 @@ export default {
       this.$root.$emit('bv::hide::modal', 'report-profile');
     },
     async reportAbuse () {
-      this.text(this.$t('abuseReported'));
-
       const result = await this.$store.dispatch('members:reportMember', {
         memberId: this.memberId,
         source: this.$route.fullPath,
         comment: this.reportComment,
       });
+      if (result.status === 200) {
+        this.text(this.$t('abuseReported'));
 
-      this.$root.$emit('habitica:report-profile-result', result);
+        this.$root.$emit('habitica:report-profile-result', result.data.data);
+      } else {
+        this.error(result.statusText);
+      }
 
       this.close();
     },
@@ -161,6 +183,17 @@ export default {
       this.reportComment = '';
       this.$root.$emit('bv::show::modal', 'report-profile');
     },
+    async resetFlags () {
+      const result = await this.$store.dispatch('members:clearMemberFlags', {
+        memberId: this.memberId,
+      });
+      if (result.status === 200) {
+        this.text('Flags cleared.');
+      } else {
+        this.err(result.statusText);
+      }
+      this.close();
+    },
   },
 };
 </script>
diff --git a/website/client/src/store/actions/members.js b/website/client/src/store/actions/members.js
index fcf18bc0d3..d9377cd800 100644
--- a/website/client/src/store/actions/members.js
+++ b/website/client/src/store/actions/members.js
@@ -122,5 +122,11 @@ export async function reportMember (store, payload) {
     source: payload.source,
   };
   const response = await axios.post(url, data);
-  return response.data.data;
+  return response;
+}
+
+export async function clearMemberFlags (store, payload) {
+  const url = `${apiv4Prefix}/members/${payload.memberId}/clear-flags`;
+  const response = await axios.post(url);
+  return response;
 }
diff --git a/website/server/controllers/api-v3/members.js b/website/server/controllers/api-v3/members.js
index 16cccd6501..19b14edde0 100644
--- a/website/server/controllers/api-v3/members.js
+++ b/website/server/controllers/api-v3/members.js
@@ -819,4 +819,48 @@ api.flagUser = {
   },
 };
 
+/**
+ * @api {post} /api/v3/members/:memberId/clear-flags Delete flags from a user
+ * @apiDescription Removes any abuse reports flagged on a user profile.
+ * @apiPermission Admin
+ * @apiName ClearUserFlags
+ * @apiGroup Members
+ *
+ * @apiParam (Path) {UUID} memberId The unique ID of the flagged user to reset
+ *
+ * @apiSuccess {Object} data An empty object
+ *
+ * @apiError (400) {BadRequest} MemberIdRequired The `memberId` param is required
+ *                                               and must be a valid `UUID`.
+ * @apiError (400) {BadRequest} MustBeAdmin Must be a moderator to use this route
+ * @apiError (404) {NotFound} UserWithIdNotFound The `memberId` param did not
+ *                                               belong to an existing user.
+ */
+
+api.clearUserFlags = {
+  method: 'POST',
+  url: '/members/:memberId/clear-flags',
+  middlewares: [authWithHeaders()],
+  async handler (req, res) {
+    const { user } = res.locals;
+    const { memberId } = req.params;
+
+    req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
+    if (!user.hasPermission('moderator')) {
+      throw new BadRequest('Only a moderator may clear reports from a profile.');
+    }
+    const flaggedUser = await User.findOne(
+      { _id: memberId },
+      { profile: 1 },
+    ).exec();
+    if (!flaggedUser) {
+      throw new NotFound(res.t('userWithIDNotFound', { userId: memberId }));
+    }
+    flaggedUser.profile.flags = {};
+    await flaggedUser.save();
+
+    res.respond(200, {});
+  },
+};
+
 export default api;