From 20556e2af47001a170bd45d1bbee694e7598c396 Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Sun, 4 Feb 2018 15:51:17 +0100
Subject: [PATCH] refactor casting spells on the client side (#9949)

---
 website/client/components/tasks/spells.vue | 14 -------------
 website/client/mixins/spells.js            | 24 +++++++++++++++-------
 2 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/website/client/components/tasks/spells.vue b/website/client/components/tasks/spells.vue
index d6bf2a54bd..0cbe0b461d 100644
--- a/website/client/components/tasks/spells.vue
+++ b/website/client/components/tasks/spells.vue
@@ -188,22 +188,12 @@ export default {
     };
   },
   mounted () {
-    this.$root.$on('castEnd', (target, type, $event) => {
-      this.castEnd(target, type, $event);
-    });
-
-    document.addEventListener('keyup', this.handleKeyUp);
-
     // @TODO: should we abstract the drawer state/local store to a library and mixing combo? We use a similar pattern in equipment
     const spellDrawerState = getLocalSetting(CONSTANTS.keyConstants.SPELL_DRAWER_STATE);
     if (spellDrawerState === CONSTANTS.valueConstants.DRAWER_CLOSED) {
       this.$store.state.spellOptions.spellDrawOpen = false;
     }
   },
-  beforeDestroy () {
-    this.$root.$off('castEnd');
-    document.removeEventListener('keyup', this.handleKeyUp);
-  },
   computed: {
     ...mapState({user: 'user.data'}),
     openStatus () {
@@ -211,10 +201,6 @@ export default {
     },
   },
   methods: {
-    handleKeyUp (keyEvent) {
-      if (keyEvent.keyCode !== 27) return;
-      this.castCancel();
-    },
     drawerToggled (newState) {
       this.$store.state.spellOptions.spellDrawOpen = newState;
 
diff --git a/website/client/mixins/spells.js b/website/client/mixins/spells.js
index f0bec18674..6976857cca 100644
--- a/website/client/mixins/spells.js
+++ b/website/client/mixins/spells.js
@@ -4,6 +4,10 @@ import isArray from 'lodash/isArray';
 // @TODO: Let's separate some of the business logic out of Vue if possible
 export default {
   methods: {
+    handleCastCancelKeyUp (keyEvent) {
+      if (keyEvent.keyCode !== 27) return;
+      this.castCancel();
+    },
     async castStart (spell) {
       if (this.$store.state.spellOptions.castingSpell) {
         this.castCancel();
@@ -47,6 +51,13 @@ export default {
           return true;
         });
         this.castEnd(tasks, spell.target);
+      } else {
+        // If the cast target has to be selected (and can be cancelled)
+        document.addEventListener('keyup', this.handleCastCancelKeyUp);
+
+        this.$root.$on('castEnd', (target, type, $event) => {
+          this.castEnd(target, type, $event);
+        });
       }
     },
     async castEnd (target, type) {
@@ -61,17 +72,12 @@ export default {
       if (target && target.challenge && target.challenge.id) return this.text(this.$t('invalidTarget'));
       if (target && target.group && target.group.id) return this.text(this.$t('invalidTarget'));
 
-      // @TODO: just call castCancel?
-      this.$store.state.spellOptions.castingSpell = false;
-      this.potionClickMode = false;
-
       this.spell.cast(this.user, target);
-      // User.save(); // @TODO:
 
       let spell = this.spell;
       let targetId = target ? target._id : null;
-      this.spell = null;
-      this.applyingAction = false;
+
+      this.castCancel();
 
       let spellUrl = `/api/v3/user/class/cast/${spell.key}`;
       if (targetId) spellUrl += `?targetId=${targetId}`;
@@ -123,6 +129,10 @@ export default {
       this.spell = null;
       document.querySelector('body').style.cursor = 'initial';
       this.$store.state.spellOptions.castingSpell = false;
+
+      // Remove listeners
+      this.$root.$off('castEnd');
+      document.removeEventListener('keyup', this.handleCastCancelKeyUp);
     },
   },
 };