From 4929a2dd7991c242525aebdbddf9d4cfb8861a7d Mon Sep 17 00:00:00 2001 From: Keith Holliday Date: Thu, 17 Aug 2017 13:42:41 -0600 Subject: [PATCH] Remove catch from cron (#8963) * Removed extra logging * Removed second extra logger * Removed extra import --- website/server/middlewares/cron.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/website/server/middlewares/cron.js b/website/server/middlewares/cron.js index 409a5edefd..5bf2eb26b0 100644 --- a/website/server/middlewares/cron.js +++ b/website/server/middlewares/cron.js @@ -5,7 +5,6 @@ import { model as Group } from '../models/group'; import { model as User } from '../models/user'; import { recoverCron, cron } from '../libs/cron'; import { v4 as uuid } from 'uuid'; -import logger from '../libs/logger'; async function checkForActiveCron (user, now) { let _cronSignature = uuid(); @@ -120,17 +119,13 @@ async function cronAsync (req, res) { await recoverCron(recoveryStatus, res.locals); } else { - logger.error(err, {isUserUpdateErroringDuringCron: true}); // For any other error make sure to reset _cronSignature so that it doesn't prevent cron from running // at the next request await User.update({ _id: user._id, }, { _cronSignature: 'NOT_RUNNING', - }).exec() - .catch((newError) => { - logger.error(newError, {isUserUpdateErroringDuringCron: true}); - }); + }).exec(); throw err; // re-throw the original error }