From 53417adda11114d93ffc30a9c2c7ace839cb8a7d Mon Sep 17 00:00:00 2001
From: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Date: Tue, 17 Nov 2015 14:07:35 +0100
Subject: [PATCH] Replaced magic numbers with variables

---
 website/public/js/controllers/settingsCtrl.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/website/public/js/controllers/settingsCtrl.js b/website/public/js/controllers/settingsCtrl.js
index 97df03b8fb..e785c7c02e 100644
--- a/website/public/js/controllers/settingsCtrl.js
+++ b/website/public/js/controllers/settingsCtrl.js
@@ -204,12 +204,13 @@ habitrpg.controller('SettingsCtrl',
 
     $scope.gemGoldCap = function(subscription) {
       var baseCap = 25;
+      var gemCapIncrement = 5;
+      var capIncrementThreshold = 3;
       var gemCapExtra = User.user.purchased.plan.consecutive.gemCapExtra;
-      // @TODO: What are these magic numbers? 3? 5?
-      var blocks = Content.subscriptionBlocks[subscription.key].months / 3;
+      var blocks = Content.subscriptionBlocks[subscription.key].months / capIncrementThreshold;
       var flooredBlocks = Math.floor(blocks);
 
-      var userTotalDropCap = baseCap + gemCapExtra + flooredBlocks * 5;
+      var userTotalDropCap = baseCap + gemCapExtra + flooredBlocks * gemCapIncrement;
       var maxDropCap = 50;
 
       return [userTotalDropCap, maxDropCap];