From 563a5845f0759681aa30c9519f8527c23b03b2fb Mon Sep 17 00:00:00 2001 From: Alys Date: Tue, 30 Jan 2018 06:56:46 +1000 Subject: [PATCH] refund gems when deleting a "Public Challenge" (Tavern challenge) (#9752) --- website/server/models/challenge.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/website/server/models/challenge.js b/website/server/models/challenge.js index 9a48c1b455..93f6120897 100644 --- a/website/server/models/challenge.js +++ b/website/server/models/challenge.js @@ -7,7 +7,6 @@ import * as Tasks from './task'; import { model as User } from './user'; import { model as Group, - TAVERN_ID, } from './group'; import { removeFromArray } from '../libs/collectionManipulators'; import shared from '../../common'; @@ -297,8 +296,8 @@ schema.methods.closeChal = async function closeChal (broken = {}) { // Delete the challenge await this.model('Challenge').remove({_id: challenge._id}).exec(); - // Refund the leader if the challenge is closed and the group not the tavern - if (challenge.group !== TAVERN_ID && brokenReason === 'CHALLENGE_DELETED') { + // Refund the leader if the challenge is deleted (no winner chosen) + if (brokenReason === 'CHALLENGE_DELETED') { await User.update({_id: challenge.leader}, {$inc: {balance: challenge.prize / 4}}).exec(); }