From 6343f32f792ee8a877403260f039732b8196b8d8 Mon Sep 17 00:00:00 2001 From: Kalista Payne Date: Thu, 19 Mar 2026 19:02:56 -0500 Subject: [PATCH] fix(tests): lint, expects, correct downscoring for Gold --- test/common/ops/scoreTask.test.js | 4 ++-- website/common/script/content/spells.js | 3 ++- website/common/script/ops/scoreTask.js | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/test/common/ops/scoreTask.test.js b/test/common/ops/scoreTask.test.js index bee676a1fd..9b1168da1b 100644 --- a/test/common/ops/scoreTask.test.js +++ b/test/common/ops/scoreTask.test.js @@ -239,14 +239,14 @@ describe('shared.ops.scoreTask', () => { }); const firstTaskDelta = ref.afterUser.party.quest.progress.up; expect(firstTaskDelta).to.be.greaterThan(0); - expect(ref.afterUser._tmp.quest.progressDelta).to.eql(firstTaskDelta); + expect(ref.afterUser._tmp.quest.progressDelta).to.eql(Math.ceil(firstTaskDelta)); scoreTask({ user: ref.afterUser, task: habit, direction: 'up', cron: false, }); const secondTaskDelta = ref.afterUser.party.quest.progress.up - firstTaskDelta; expect(secondTaskDelta).to.be.greaterThan(0); - expect(ref.afterUser._tmp.quest.progressDelta).to.eql(secondTaskDelta); + expect(ref.afterUser._tmp.quest.progressDelta).to.eql(Math.ceil(secondTaskDelta)); }); context('habits', () => { diff --git a/website/common/script/content/spells.js b/website/common/script/content/spells.js index c4c4bd244a..dfe8fc8edc 100644 --- a/website/common/script/content/spells.js +++ b/website/common/script/content/spells.js @@ -263,7 +263,8 @@ spells.healer = { notes: t('spellHealerHealAllNotes'), cast (user, target) { each(target, member => { - member.stats.hp += Math.ceil((statsComputed(user).con + statsComputed(user).int + 5) * 0.04); + member.stats.hp += Math.ceil( + (statsComputed(user).con + statsComputed(user).int + 5) * 0.04); if (member.stats.hp > 50) member.stats.hp = 50; }); }, diff --git a/website/common/script/ops/scoreTask.js b/website/common/script/ops/scoreTask.js index e0b53b4959..245d2d2d07 100644 --- a/website/common/script/ops/scoreTask.js +++ b/website/common/script/ops/scoreTask.js @@ -147,9 +147,9 @@ function _addPoints (user, task, stats, direction, delta) { user._tmp.streakBonus = afterStreak - gpMod; } - stats.gp += Math.ceil(afterStreak); + stats.gp += (direction === 'down' ? Math.floor(afterStreak) : Math.ceil(afterStreak)); } else { - stats.gp += Math.ceil(gpMod); + stats.gp += (direction === 'down' ? Math.floor(gpMod) : Math.ceil(gpMod)); } }