From 6a0f9564e03a70d2ac290c9bf6c2ac9d9f77e984 Mon Sep 17 00:00:00 2001 From: Matteo Pagliazzi Date: Wed, 9 Dec 2015 10:40:40 +0100 Subject: [PATCH] begins testing score task route --- .../tasks/POST-tasks_score_id_direction.test.js | 17 +++++++++++++++-- website/src/controllers/api-v3/tasks.js | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/test/api/v3/integration/tasks/POST-tasks_score_id_direction.test.js b/test/api/v3/integration/tasks/POST-tasks_score_id_direction.test.js index 46264aee7c..502a75a1ac 100644 --- a/test/api/v3/integration/tasks/POST-tasks_score_id_direction.test.js +++ b/test/api/v3/integration/tasks/POST-tasks_score_id_direction.test.js @@ -3,6 +3,7 @@ import { requester, translate as t, } from '../../../../helpers/api-integration.helper'; +import { v4 as generateUUID } from 'uuid'; describe('POST /tasks/score/:id/:direction', () => { let user, api; @@ -15,9 +16,21 @@ describe('POST /tasks/score/:id/:direction', () => { }); context('all', () => { - it('requires a task id'); + it('requires a task id', () => { + return expect(api.post('/tasks/score/123/up')).to.eventually.be.rejected.and.eql({ + code: 400, + error: 'BadRequest', + message: t('invalidReqParams'), + }); + }); - it('requires a task direction'); + it('requires a task direction', () => { + return expect(api.post(`/tasks/score/${generateUUID()}/tt`)).to.eventually.be.rejected.and.eql({ + code: 400, + error: 'BadRequest', + message: t('invalidReqParams'), + }); + }); }); context('todos', () => { diff --git a/website/src/controllers/api-v3/tasks.js b/website/src/controllers/api-v3/tasks.js index 2f36b8881a..d5fd1a587f 100644 --- a/website/src/controllers/api-v3/tasks.js +++ b/website/src/controllers/api-v3/tasks.js @@ -235,7 +235,7 @@ function _generateWebhookTaskData (task, direction, delta, stats, user) { */ api.scoreTask = { method: 'POST', - url: 'tasks/score/:taskId/:direction', + url: '/tasks/score/:taskId/:direction', middlewares: [authWithHeaders()], handler (req, res, next) { req.checkParams('taskId', res.t('taskIdRequired')).notEmpty().isUUID();