Fix 9248: challenge creator should not automatically join their own challenge (#10383)

* fix(challenges): creator should not join challenge automatically

* change behavior on the client side as well

* update tests and fix membercount

* update tests

* fix tests

test/api/v3/integration/user/DELETE-user.test.js

@@ -117,6 +117,7 @@ describe('DELETE /user', () => {
       let authorizedUser = populatedGroup.members[1];
 
       let challenge = await generateChallenge(populatedGroup.groupLeader, group);
+      await populatedGroup.groupLeader.post(`/challenges/${challenge._id}/join`);
       await authorizedUser.post(`/challenges/${challenge._id}/join`);
 
       await challenge.sync();

test/api/v3/integration/user/POST-user_class_cast_spellId.test.js

@@ -109,6 +109,7 @@ describe('POST /user/class/cast/:spellId', () => {
   it('returns an error if a challenge task was targeted', async () => {
     let {group, groupLeader} = await createAndPopulateGroup();
     let challenge = await generateChallenge(groupLeader, group);
+    await groupLeader.post(`/challenges/${challenge._id}/join`);
     await groupLeader.post(`/tasks/challenge/${challenge._id}`, [
       {type: 'habit', text: 'task text'},
     ]);
@@ -238,6 +239,7 @@ describe('POST /user/class/cast/:spellId', () => {
   it('searing brightness does not affect challenge or group tasks', async () => {
     let guild = await generateGroup(user);
     let challenge = await generateChallenge(user, guild);
+    await user.post(`/challenges/${challenge._id}/join`);
     await user.post(`/tasks/challenge/${challenge._id}`, {
       text: 'test challenge habit',
       type: 'habit',

test/api/v3/integration/user/POST-user_reset.test.js

@@ -90,6 +90,7 @@ describe('POST /user/reset', () => {
   it('does not delete challenge or group tasks', async () => {
     let guild = await generateGroup(user);
     let challenge = await generateChallenge(user, guild);
+    await user.post(`/challenges/${challenge._id}/join`);
     await user.post(`/tasks/challenge/${challenge._id}`, {
       text: 'test challenge habit',
       type: 'habit',