antidote display and functionality (#10199)

* update antidote display and functionality - fixes #9758 and #10160

update antidote display and functionality - fixes #9758 and #10160

update antidote display and functionality - fixes #9758 and #10160

update antidote display and functionality - fixes #9758 and #10160

* clean up / refactor

* prevent unpin of all items which don't have a pinType

* remove the double boolean casting / fix lint

website/common/script/content/spells.js

@@ -282,6 +282,7 @@ spells.special = {
     mana: 0,
     value: 5,
     immediateUse: true,
+    purchaseType: 'debuffPotion',
     target: 'self',
     notes: t('spellSpecialSaltNotes'),
     cast (user) {
@@ -312,6 +313,7 @@ spells.special = {
     mana: 0,
     value: 5,
     immediateUse: true,
+    purchaseType: 'debuffPotion',
     target: 'self',
     notes: t('spellSpecialOpaquePotionNotes'),
     cast (user) {
@@ -342,6 +344,7 @@ spells.special = {
     mana: 0,
     value: 5,
     immediateUse: true,
+    purchaseType: 'debuffPotion',
     target: 'self',
     notes: t('spellSpecialPetalFreePotionNotes'),
     cast (user) {
@@ -372,6 +375,7 @@ spells.special = {
     mana: 0,
     value: 5,
     immediateUse: true,
+    purchaseType: 'debuffPotion',
     target: 'self',
     notes: t('spellSpecialSandNotes'),
     cast (user) {

website/common/script/ops/buy/buyMarketGear.js

@@ -26,9 +26,7 @@ export class BuyMarketGearOperation extends AbstractGoldItemOperation {
   extractAndValidateParams (user, req) {
     let key = this.key = get(req, 'params.key');
     if (!key) throw new BadRequest(this.i18n('missingKeyParam'));
-
     let item = content.gear.flat[key];
-
     if (!item) throw new NotFound(this.i18n('itemNotFound', {key}));
 
     this.canUserPurchase(user, item);