Upgrade tests tools and lint migrations and scripts (part 2) (#9998)

* upgrade gulp-babel

* upgrade babel-eslint

* upgrade eslint-friendly-formatter

* start upgrading chai

* start to upgrade eslint

* restore skipped tests

* start to upgrqde monk

* fix linting and remove unused file

* fix mocha notifications, and common tests

* fix unit tests

* start to fix initrgration tests

* more integration tests fixes

* upgrade monk to latest version

* lint /scripts

* migrations: start moving to /archive unused migrations and run eslint with --fix

* lint migrations

* fix more integration tests

* fix test

test/api/v3/integration/debug/POST-debug_addTenGems.test.js

@@ -26,10 +26,10 @@ describe('POST /debug/add-ten-gems', () => {
     nconf.set('IS_PROD', true);
 
     await expect(userToGainTenGems.post('/debug/add-ten-gems'))
-    .eventually.be.rejected.and.to.deep.equal({
-      code: 404,
-      error: 'NotFound',
-      message: 'Not found.',
-    });
+      .eventually.be.rejected.and.to.deep.equal({
+        code: 404,
+        error: 'NotFound',
+        message: 'Not found.',
+      });
   });
 });

test/api/v3/integration/debug/POST-debug_make-admin.test.js

@@ -26,10 +26,10 @@ describe('POST /debug/make-admin (pended for v3 prod testing)', () => {
     nconf.set('IS_PROD', true);
 
     await expect(user.post('/debug/make-admin'))
-    .eventually.be.rejected.and.to.deep.equal({
-      code: 404,
-      error: 'NotFound',
-      message: 'Not found.',
-    });
+      .eventually.be.rejected.and.to.deep.equal({
+        code: 404,
+        error: 'NotFound',
+        message: 'Not found.',
+      });
   });
 });

test/api/v3/integration/debug/POST-debug_modify-inventory.test.js

@@ -151,10 +151,10 @@ describe('POST /debug/modify-inventory', () => {
     nconf.set('IS_PROD', true);
 
     await expect(user.post('/debug/modify-inventory'))
-    .eventually.be.rejected.and.to.deep.equal({
-      code: 404,
-      error: 'NotFound',
-      message: 'Not found.',
-    });
+      .eventually.be.rejected.and.to.deep.equal({
+        code: 404,
+        error: 'NotFound',
+        message: 'Not found.',
+      });
   });
 });

test/api/v3/integration/debug/POST-debug_quest-progress.test.js

@@ -16,11 +16,11 @@ describe('POST /debug/quest-progress', () => {
 
   it('errors if user is not on a quest', async () => {
     await expect(user.post('/debug/quest-progress'))
-    .to.eventually.be.rejected.and.to.deep.equal({
-      code: 400,
-      error: 'BadRequest',
-      message: 'User is not on a valid quest.',
-    });
+      .to.eventually.be.rejected.and.to.deep.equal({
+        code: 400,
+        error: 'BadRequest',
+        message: 'User is not on a valid quest.',
+      });
   });
 
   it('increases boss quest progress by 1000', async () => {
@@ -51,10 +51,10 @@ describe('POST /debug/quest-progress', () => {
     nconf.set('IS_PROD', true);
 
     await expect(user.post('/debug/quest-progress'))
-    .eventually.be.rejected.and.to.deep.equal({
-      code: 404,
-      error: 'NotFound',
-      message: 'Not found.',
-    });
+      .eventually.be.rejected.and.to.deep.equal({
+        code: 404,
+        error: 'NotFound',
+        message: 'Not found.',
+      });
   });
 });

test/api/v3/integration/debug/POST-debug_set-cron.test.js

@@ -30,10 +30,10 @@ describe('POST /debug/set-cron', () => {
     nconf.set('IS_PROD', true);
 
     await expect(user.post('/debug/set-cron'))
-    .eventually.be.rejected.and.to.deep.equal({
-      code: 404,
-      error: 'NotFound',
-      message: 'Not found.',
-    });
+      .eventually.be.rejected.and.to.deep.equal({
+        code: 404,
+        error: 'NotFound',
+        message: 'Not found.',
+      });
   });
 });