sep 25 fixes (#9075)

* on class change: remove owned gear from pinned items

* move dragging item-info closer to the cursor (food / hatching potion)

* remove v-once at attributesPopover (if the parent component is recycled the old data stays active)

* prevent popover to show data of an item that was removed - but the popover stays opened

website/common/script/ops/changeClass.js

@@ -7,7 +7,7 @@ import {
   NotAuthorized,
   BadRequest,
 } from '../libs/errors';
-import { removePinnedGearByClass, addPinnedGearByClass } from './pinnedGearUtils';
+import { removePinnedGearByClass, removePinnedItemsByOwnedGear, addPinnedGearByClass } from './pinnedGearUtils';
 
 function resetClass (user, req = {}) {
   removePinnedGearByClass(user);
@@ -49,6 +49,8 @@ module.exports = function changeClass (user, req = {}, analytics) {
     user.items.gear.owned[`weapon_${klass}_0`] = true;
     if (klass === 'rogue')  user.items.gear.owned[`shield_${klass}_0`] = true;
 
+    removePinnedItemsByOwnedGear(user);
+
     if (analytics) {
       analytics.track('change class', {
         uuid: user._id,

website/common/script/ops/pinnedGearUtils.js

@@ -104,6 +104,18 @@ function removePinnedGearAddPossibleNewOnes (user, itemPath, newItemKey) {
   }
 }
 
+/**
+ * removes all pinned gear that the user already owns (like class starter gear which has been pinned before)
+ * @param user
+ */
+function removePinnedItemsByOwnedGear (user) {
+  each(user.items.gear.owned, (bool, key) => {
+    if (bool) {
+      removeItemByPath(user, `gear.flat.${key}`);
+    }
+  });
+}
+
 /**
  * @returns {boolean} TRUE added the item / FALSE removed it
  */
@@ -150,6 +162,7 @@ module.exports = {
   addPinnedGear,
   removePinnedGearByClass,
   removePinnedGearAddPossibleNewOnes,
+  removePinnedItemsByOwnedGear,
   togglePinnedItem,
   removeItemByPath,
   isPinned,