From 7d5a7503cba2e49ed3afb073a1b349ea9571dcfc Mon Sep 17 00:00:00 2001 From: Matteo Pagliazzi Date: Thu, 14 Jan 2016 20:55:13 +0100 Subject: [PATCH] fix access to user.tasksOrder --- website/src/controllers/api-v3/tasks.js | 2 +- website/src/models/user.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/website/src/controllers/api-v3/tasks.js b/website/src/controllers/api-v3/tasks.js index a3610f7913..cee1ba4527 100644 --- a/website/src/controllers/api-v3/tasks.js +++ b/website/src/controllers/api-v3/tasks.js @@ -838,7 +838,7 @@ api.removeTagFromTask = { // Remove a task from (user|challenge).tasksOrder function _removeTaskTasksOrder (userOrChallenge, taskId, taskType) { - let list = userOrChallenge.tasksOrder[taskType]; + let list = userOrChallenge.tasksOrder[`${taskType}s`]; let index = list.indexOf(taskId); if (index !== -1) list.splice(index, 1); diff --git a/website/src/models/user.js b/website/src/models/user.js index 55fdd49bdb..40181108d0 100644 --- a/website/src/models/user.js +++ b/website/src/models/user.js @@ -660,7 +660,7 @@ schema.methods.unlinkChallengeTasks = async function unlinkChallengeTasks (chall tasks = tasks.map(task => { // Remove task from user.tasksOrder and delete them if (task.type !== 'todo' || !task.completed) { - let list = user.tasksOrder[task.type]; + let list = user.tasksOrder[`${task.type}s`]; let index = list.indexOf(task._id); if (index !== -1) list.splice(index, 1); }