From 8012f0294daedaccae1767fe6bf0e4686cfd8268 Mon Sep 17 00:00:00 2001 From: SabreCat Date: Tue, 10 Oct 2023 11:47:59 -0500 Subject: [PATCH] fix(groups): use assigned keys as source of truth --- website/server/models/group.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/website/server/models/group.js b/website/server/models/group.js index 6ca51cc955..143394eb89 100644 --- a/website/server/models/group.js +++ b/website/server/models/group.js @@ -1432,11 +1432,6 @@ schema.methods.syncTask = async function groupSyncTask (taskToSync, users, assig completed: false, }; - if (!taskToSync.group.assignedUsers) { - taskToSync.group.assignedUsers = []; - } - taskToSync.group.assignedUsers.push(user._id); - if (!taskToSync.group.assignedUsersDetail) { taskToSync.group.assignedUsersDetail = {}; } @@ -1445,6 +1440,8 @@ schema.methods.syncTask = async function groupSyncTask (taskToSync, users, assig } taskToSync.markModified('group.assignedUsersDetail'); + taskToSync.group.assignedUsers = _.keys(taskToSync.group.assignedUsersDetail); + // Sync tags const userTags = user.tags; const i = _.findIndex(userTags, { id: group._id });