From 40eb8588ac2a0c82d9060820a3bd986e5cd26447 Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Wed, 8 May 2013 17:33:39 +0100 Subject: [PATCH 1/3] tags: remove tags from tasks when the tag gets deleted --- src/app/filters.coffee | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/app/filters.coffee b/src/app/filters.coffee index e944c565fa..699da10955 100644 --- a/src/app/filters.coffee +++ b/src/app/filters.coffee @@ -23,10 +23,14 @@ module.exports.app = (appExports, model) -> tags = user.get('tags') tagId = $(el).attr('data-tag-id') model.del "_user.filters.#{tagId}" - #TODO remove tag from each task _.each tags, (tag, i) -> if tag.id is tagId tags.splice(i,1) model.del "_user.filters.#{tag.id}" + + # remove tag from all tasks + _.each user.get("tasks"), (task) -> + user.del "tasks.#{task.id}.tags.#{tagId}" + model.set "_user.tags", tags , -> browser.resetDom(model) From d7ad379ec1d01d884c264f6197a5064b9844334f Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Wed, 8 May 2013 20:13:47 +0100 Subject: [PATCH 2/3] achievements: extra note on contrib badge --- views/app/avatar.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/views/app/avatar.html b/views/app/avatar.html index 345e939d05..f193d97951 100644 --- a/views/app/avatar.html +++ b/views/app/avatar.html @@ -192,7 +192,7 @@ Contributor {{/}} - Has contributed to HabitRPG (code, design, pixel art, legal advice, etc) + Has contributed to HabitRPG (code, design, pixel art, legal advice, docs, etc). Want this badge? Fix a bug :) From 78944e93ef723afcf5bbbd9a285cee07608a69fa Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Wed, 8 May 2013 21:30:35 +0100 Subject: [PATCH 3/3] party: chat - better messages.length check --- src/app/helpers.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/helpers.coffee b/src/app/helpers.coffee index c3118253ce..89495d4570 100644 --- a/src/app/helpers.coffee +++ b/src/app/helpers.coffee @@ -183,7 +183,7 @@ viewHelpers = (view) -> view.fn 'newChatMessages', (messages, lastMessageSeen) -> return false unless messages?.length > 0 - messages && messages[0].id != lastMessageSeen + messages?[0] and (messages[0].id != lastMessageSeen) view.fn 'indexOf', (str1, str2) -> return false unless str1 && str2