Kai/habitica
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix test lint

Browse Source
This commit is contained in:
Matteo Pagliazzi
2019-10-08 20:45:38 +02:00
parent e37f4467f8
commit 85fb5f33aa
367 changed files with 6635 additions and 6080 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/api/v3/integration/members/GET-achievements.test.js
+7 -7
View File
@@ -1,8 +1,8 @@
import { v4 as generateUUID } from 'uuid';
import {
generateUser,
translate as t,
} from '../../../../helpers/api-integration/v3';
import { v4 as generateUUID } from 'uuid';
describe('GET /members/:memberId/achievements', () => {
let user;
@@ -20,11 +20,11 @@ describe('GET /members/:memberId/achievements', () => {
});
it('returns achievements based on given user', async () => {
let member = await generateUser({
contributor: {level: 1},
backer: {tier: 3},
const member = await generateUser({
contributor: { level: 1 },
backer: { tier: 3 },
});
let achievementsRes = await user.get(`/members/${member._id}/achievements`);
const achievementsRes = await user.get(`/members/${member._id}/achievements`);
expect(achievementsRes.special.achievements.contributor.earned).to.equal(true);
expect(achievementsRes.special.achievements.contributor.value).to.equal(1);
@@ -34,11 +34,11 @@ describe('GET /members/:memberId/achievements', () => {
});
it('handles non-existing members', async () => {
let dummyId = generateUUID();
const dummyId = generateUUID();
await expect(user.get(`/members/${dummyId}/achievements`)).to.eventually.be.rejected.and.eql({
code: 404,
error: 'NotFound',
message: t('userWithIDNotFound', {userId: dummyId}),
message: t('userWithIDNotFound', { userId: dummyId }),
});
});
});
test/api/v3/integration/members/GET-members_id.test.js
+8 -7
View File
@@ -1,8 +1,8 @@
import { v4 as generateUUID } from 'uuid';
import {
generateUser,
translate as t,
} from '../../../../helpers/api-integration/v3';
import { v4 as generateUUID } from 'uuid';
import common from '../../../../../website/common';
describe('GET /members/:memberId', () => {
@@ -21,15 +21,16 @@ describe('GET /members/:memberId', () => {
});
it('returns a member public data only', async () => {
let member = await generateUser({ // make sure user has all the fields that can be returned by the getMember call
contributor: {level: 1},
backer: {tier: 3},
// make sure user has all the fields that can be returned by the getMember call
const member = await generateUser({
contributor: { level: 1 },
backer: { tier: 3 },
preferences: {
costume: false,
background: 'volcano',
},
});
let memberRes = await user.get(`/members/${member._id}`);
const memberRes = await user.get(`/members/${member._id}`);
expect(memberRes).to.have.all.keys([ // works as: object has all and only these keys
'_id', 'id', 'preferences', 'profile', 'stats', 'achievements', 'party',
'backer', 'contributor', 'auth', 'items', 'inbox', 'loginIncentives', 'flags',
@@ -48,11 +49,11 @@ describe('GET /members/:memberId', () => {
});
it('handles non-existing members', async () => {
let dummyId = generateUUID();
const dummyId = generateUUID();
await expect(user.get(`/members/${dummyId}`)).to.eventually.be.rejected.and.eql({
code: 404,
error: 'NotFound',
message: t('userWithIDNotFound', {userId: dummyId}),
message: t('userWithIDNotFound', { userId: dummyId }),
});
});
});
test/api/v3/integration/members/GET-objections_interaction.test.js
+11 -11
View File
@@ -1,8 +1,8 @@
import { v4 as generateUUID } from 'uuid';
import {
generateUser,
translate as t,
} from '../../../../helpers/api-integration/v3';
import { v4 as generateUUID } from 'uuid';
describe('GET /members/:toUserId/objections/:interaction', () => {
let user;
@@ -13,7 +13,7 @@ describe('GET /members/:toUserId/objections/:interaction', () => {
it('validates req.params.memberId', async () => {
await expect(
user.get('/members/invalidUUID/objections/send-private-message')
user.get('/members/invalidUUID/objections/send-private-message'),
).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
@@ -22,21 +22,21 @@ describe('GET /members/:toUserId/objections/:interaction', () => {
});
it('handles non-existing members', async () => {
let dummyId = generateUUID();
const dummyId = generateUUID();
await expect(
user.get(`/members/${dummyId}/objections/send-private-message`)
user.get(`/members/${dummyId}/objections/send-private-message`),
).to.eventually.be.rejected.and.eql({
code: 404,
error: 'NotFound',
message: t('userWithIDNotFound', {userId: dummyId}),
message: t('userWithIDNotFound', { userId: dummyId }),
});
});
it('handles non-existing interactions', async () => {
let receiver = await generateUser();
const receiver = await generateUser();
await expect(
user.get(`/members/${receiver._id}/objections/hug-a-whole-forest-of-trees`)
user.get(`/members/${receiver._id}/objections/hug-a-whole-forest-of-trees`),
).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
@@ -45,18 +45,18 @@ describe('GET /members/:toUserId/objections/:interaction', () => {
});
it('returns an empty array if there are no objections', async () => {
let receiver = await generateUser();
const receiver = await generateUser();
await expect(
user.get(`/members/${receiver._id}/objections/send-private-message`)
user.get(`/members/${receiver._id}/objections/send-private-message`),
).to.eventually.be.fulfilled.and.eql([]);
});
it('returns an array of objections if any exist', async () => {
let receiver = await generateUser({'inbox.blocks': [user._id]});
const receiver = await generateUser({ 'inbox.blocks': [user._id] });
await expect(
user.get(`/members/${receiver._id}/objections/send-private-message`)
user.get(`/members/${receiver._id}/objections/send-private-message`),
).to.eventually.be.fulfilled.and.eql([
t('notAuthorizedToSendMessageToThisUser'),
]);
test/api/v3/integration/members/POST-send_private_message.test.js
+45 -38
View File
@@ -1,12 +1,12 @@
import { v4 as generateUUID } from 'uuid';
import {
generateUser,
translate as t,
} from '../../../../helpers/api-integration/v3';
import { v4 as generateUUID } from 'uuid';
describe('POST /members/send-private-message', () => {
let userToSendMessage;
let messageToSend = 'Test Private Message';
const messageToSend = 'Test Private Message';
beforeEach(async () => {
userToSendMessage = await generateUser();
@@ -43,7 +43,7 @@ describe('POST /members/send-private-message', () => {
});
it('returns error when to user has blocked the sender', async () => {
let receiver = await generateUser({'inbox.blocks': [userToSendMessage._id]});
const receiver = await generateUser({ 'inbox.blocks': [userToSendMessage._id] });
await expect(userToSendMessage.post('/members/send-private-message', {
message: messageToSend,
@@ -56,8 +56,8 @@ describe('POST /members/send-private-message', () => {
});
it('returns error when sender has blocked to user', async () => {
let receiver = await generateUser();
let sender = await generateUser({'inbox.blocks': [receiver._id]});
const receiver = await generateUser();
const sender = await generateUser({ 'inbox.blocks': [receiver._id] });
await expect(sender.post('/members/send-private-message', {
message: messageToSend,
@@ -70,7 +70,7 @@ describe('POST /members/send-private-message', () => {
});
it('returns error when to user has opted out of messaging', async () => {
let receiver = await generateUser({'inbox.optOut': true});
const receiver = await generateUser({ 'inbox.optOut': true });
await expect(userToSendMessage.post('/members/send-private-message', {
message: messageToSend,
@@ -83,8 +83,8 @@ describe('POST /members/send-private-message', () => {
});
it('returns an error when chat privileges are revoked', async () => {
let userWithChatRevoked = await generateUser({'flags.chatRevoked': true});
let receiver = await generateUser();
const userWithChatRevoked = await generateUser({ 'flags.chatRevoked': true });
const receiver = await generateUser();
await expect(userWithChatRevoked.post('/members/send-private-message', {
message: messageToSend,
@@ -97,7 +97,7 @@ describe('POST /members/send-private-message', () => {
});
it('sends a private message to a user', async () => {
let receiver = await generateUser();
const receiver = await generateUser();
// const initialNotifications = receiver.notifications.length;
const response = await userToSendMessage.post('/members/send-private-message', {
@@ -105,16 +105,18 @@ describe('POST /members/send-private-message', () => {
toUserId: receiver._id,
});
let updatedReceiver = await receiver.get('/user');
let updatedSender = await userToSendMessage.get('/user');
const updatedReceiver = await receiver.get('/user');
const updatedSender = await userToSendMessage.get('/user');
let sendersMessageInReceiversInbox = _.find(updatedReceiver.inbox.messages, (message) => {
return message.uuid === userToSendMessage._id && message.text === messageToSend;
});
const sendersMessageInReceiversInbox = _.find(
updatedReceiver.inbox.messages,
message => message.uuid === userToSendMessage._id && message.text === messageToSend,
);
let sendersMessageInSendersInbox = _.find(updatedSender.inbox.messages, (message) => {
return message.uuid === receiver._id && message.text === messageToSend;
});
const sendersMessageInSendersInbox = _.find(
updatedSender.inbox.messages,
message => message.uuid === receiver._id && message.text === messageToSend,
);
expect(response.message.text).to.deep.equal(sendersMessageInSendersInbox.text);
expect(response.message.uuid).to.deep.equal(sendersMessageInSendersInbox.uuid);
@@ -135,20 +137,21 @@ describe('POST /members/send-private-message', () => {
// @TODO waiting for mobile support
xit('creates a notification with an excerpt if the message is too long', async () => {
let receiver = await generateUser();
let longerMessageToSend = 'A very long message, that for sure exceeds the limit of 100 chars for the excerpt that we set to 100 chars';
let messageExcerpt = `${longerMessageToSend.substring(0, 100)}...`;
const receiver = await generateUser();
const longerMessageToSend = 'A very long message, that for sure exceeds the limit of 100 chars for the excerpt that we set to 100 chars';
const messageExcerpt = `${longerMessageToSend.substring(0, 100)}...`;
await userToSendMessage.post('/members/send-private-message', {
message: longerMessageToSend,
toUserId: receiver._id,
});
let updatedReceiver = await receiver.get('/user');
const updatedReceiver = await receiver.get('/user');
let sendersMessageInReceiversInbox = _.find(updatedReceiver.inbox.messages, (message) => {
return message.uuid === userToSendMessage._id && message.text === longerMessageToSend;
});
const sendersMessageInReceiversInbox = _.find(
updatedReceiver.inbox.messages,
message => message.uuid === userToSendMessage._id && message.text === longerMessageToSend,
);
const notification = updatedReceiver.notifications[updatedReceiver.notifications.length - 1];
@@ -161,7 +164,7 @@ describe('POST /members/send-private-message', () => {
userToSendMessage = await generateUser({
'contributor.admin': 1,
});
const receiver = await generateUser({'inbox.blocks': [userToSendMessage._id]});
const receiver = await generateUser({ 'inbox.blocks': [userToSendMessage._id] });
await userToSendMessage.post('/members/send-private-message', {
message: messageToSend,
@@ -171,13 +174,15 @@ describe('POST /members/send-private-message', () => {
const updatedReceiver = await receiver.get('/user');
const updatedSender = await userToSendMessage.get('/user');
const sendersMessageInReceiversInbox = _.find(updatedReceiver.inbox.messages, (message) => {
return message.uuid === userToSendMessage._id && message.text === messageToSend;
});
const sendersMessageInReceiversInbox = _.find(
updatedReceiver.inbox.messages,
message => message.uuid === userToSendMessage._id && message.text === messageToSend,
);
const sendersMessageInSendersInbox = _.find(updatedSender.inbox.messages, (message) => {
return message.uuid === receiver._id && message.text === messageToSend;
});
const sendersMessageInSendersInbox = _.find(
updatedSender.inbox.messages,
message => message.uuid === receiver._id && message.text === messageToSend,
);
expect(sendersMessageInReceiversInbox).to.exist;
expect(sendersMessageInSendersInbox).to.exist;
@@ -187,7 +192,7 @@ describe('POST /members/send-private-message', () => {
userToSendMessage = await generateUser({
'contributor.admin': 1,
});
const receiver = await generateUser({'inbox.optOut': true});
const receiver = await generateUser({ 'inbox.optOut': true });
await userToSendMessage.post('/members/send-private-message', {
message: messageToSend,
@@ -197,13 +202,15 @@ describe('POST /members/send-private-message', () => {
const updatedReceiver = await receiver.get('/user');
const updatedSender = await userToSendMessage.get('/user');
const sendersMessageInReceiversInbox = _.find(updatedReceiver.inbox.messages, (message) => {
return message.uuid === userToSendMessage._id && message.text === messageToSend;
});
const sendersMessageInReceiversInbox = _.find(
updatedReceiver.inbox.messages,
message => message.uuid === userToSendMessage._id && message.text === messageToSend,
);
const sendersMessageInSendersInbox = _.find(updatedSender.inbox.messages, (message) => {
return message.uuid === receiver._id && message.text === messageToSend;
});
const sendersMessageInSendersInbox = _.find(
updatedSender.inbox.messages,
message => message.uuid === receiver._id && message.text === messageToSend,
);
expect(sendersMessageInReceiversInbox).to.exist;
expect(sendersMessageInSendersInbox).to.exist;
test/api/v3/integration/members/POST-transfer_gems.test.js
+33 -29
View File
@@ -1,13 +1,11 @@
import { v4 as generateUUID } from 'uuid';
import {
generateUser,
translate as t,
} from '../../../../helpers/api-integration/v3';
import { v4 as generateUUID } from 'uuid';
function findMessage (messages, receiverId) {
let message = _.find(messages, (inboxMessage) => {
return inboxMessage.uuid === receiverId;
});
const message = _.find(messages, inboxMessage => inboxMessage.uuid === receiverId);
return message;
}
@@ -15,11 +13,11 @@ function findMessage (messages, receiverId) {
describe('POST /members/transfer-gems', () => {
let userToSendMessage;
let receiver;
let message = 'Test Private Message';
let gemAmount = 20;
const message = 'Test Private Message';
const gemAmount = 20;
beforeEach(async () => {
userToSendMessage = await generateUser({balance: 5});
userToSendMessage = await generateUser({ balance: 5 });
receiver = await generateUser();
});
@@ -68,7 +66,7 @@ describe('POST /members/transfer-gems', () => {
});
it('returns error when recipient has blocked the sender', async () => {
let receiverWhoBlocksUser = await generateUser({'inbox.blocks': [userToSendMessage._id]});
const receiverWhoBlocksUser = await generateUser({ 'inbox.blocks': [userToSendMessage._id] });
await expect(userToSendMessage.post('/members/transfer-gems', {
message,
@@ -82,7 +80,7 @@ describe('POST /members/transfer-gems', () => {
});
it('returns error when sender has blocked recipient', async () => {
let sender = await generateUser({'inbox.blocks': [receiver._id]});
const sender = await generateUser({ 'inbox.blocks': [receiver._id] });
await expect(sender.post('/members/transfer-gems', {
message,
@@ -96,7 +94,7 @@ describe('POST /members/transfer-gems', () => {
});
it('returns an error when chat privileges are revoked', async () => {
let userWithChatRevoked = await generateUser({'flags.chatRevoked': true});
const userWithChatRevoked = await generateUser({ 'flags.chatRevoked': true });
await expect(userWithChatRevoked.post('/members/transfer-gems', {
message,
@@ -110,7 +108,7 @@ describe('POST /members/transfer-gems', () => {
});
it('works when only the recipient\'s chat privileges are revoked', async () => {
let receiverWithChatRevoked = await generateUser({'flags.chatRevoked': true});
const receiverWithChatRevoked = await generateUser({ 'flags.chatRevoked': true });
await expect(userToSendMessage.post('/members/transfer-gems', {
message,
@@ -118,8 +116,8 @@ describe('POST /members/transfer-gems', () => {
toUserId: receiverWithChatRevoked._id,
})).to.eventually.be.fulfilled;
let updatedReceiver = await receiverWithChatRevoked.get('/user');
let updatedSender = await userToSendMessage.get('/user');
const updatedReceiver = await receiverWithChatRevoked.get('/user');
const updatedSender = await userToSendMessage.get('/user');
expect(updatedReceiver.balance).to.equal(gemAmount / 4);
expect(updatedSender.balance).to.equal(0);
@@ -179,18 +177,20 @@ describe('POST /members/transfer-gems', () => {
toUserId: receiver._id,
});
let updatedReceiver = await receiver.get('/user');
let updatedSender = await userToSendMessage.get('/user');
const updatedReceiver = await receiver.get('/user');
const updatedSender = await userToSendMessage.get('/user');
let sendersMessageInReceiversInbox = findMessage(updatedReceiver.inbox.messages, userToSendMessage._id);
let sendersMessageInSendersInbox = findMessage(updatedSender.inbox.messages, receiver._id);
const sendersMessageInReceiversInbox = findMessage(
updatedReceiver.inbox.messages, userToSendMessage._id,
);
const sendersMessageInSendersInbox = findMessage(updatedSender.inbox.messages, receiver._id);
let messageSentContent = t('privateMessageGiftGemsMessage', {
receiverName: receiver.profile.name,
senderName: userToSendMessage.profile.name,
gemAmount,
});
messageSentContent = `\`${messageSentContent}\` `;
messageSentContent = `\`${messageSentContent}\` `;
messageSentContent += message;
expect(sendersMessageInReceiversInbox).to.exist;
@@ -208,18 +208,20 @@ describe('POST /members/transfer-gems', () => {
toUserId: receiver._id,
});
let updatedReceiver = await receiver.get('/user');
let updatedSender = await userToSendMessage.get('/user');
const updatedReceiver = await receiver.get('/user');
const updatedSender = await userToSendMessage.get('/user');
let sendersMessageInReceiversInbox = findMessage(updatedReceiver.inbox.messages, userToSendMessage._id);
let sendersMessageInSendersInbox = findMessage(updatedSender.inbox.messages, receiver._id);
const sendersMessageInReceiversInbox = findMessage(
updatedReceiver.inbox.messages, userToSendMessage._id,
);
const sendersMessageInSendersInbox = findMessage(updatedSender.inbox.messages, receiver._id);
let messageSentContent = t('privateMessageGiftGemsMessage', {
receiverName: receiver.profile.name,
senderName: userToSendMessage.profile.name,
gemAmount,
});
messageSentContent = `\`${messageSentContent}\` `;
messageSentContent = `\`${messageSentContent}\` `;
expect(sendersMessageInReceiversInbox).to.exist;
expect(sendersMessageInReceiversInbox.text).to.equal(messageSentContent);
@@ -242,14 +244,16 @@ describe('POST /members/transfer-gems', () => {
toUserId: receiver._id,
});
let updatedReceiver = await receiver.get('/user');
let updatedSender = await userToSendMessage.get('/user');
const updatedReceiver = await receiver.get('/user');
const updatedSender = await userToSendMessage.get('/user');
let sendersMessageInReceiversInbox = findMessage(updatedReceiver.inbox.messages, userToSendMessage._id);
let sendersMessageInSendersInbox = findMessage(updatedSender.inbox.messages, receiver._id);
const sendersMessageInReceiversInbox = findMessage(
updatedReceiver.inbox.messages, userToSendMessage._id,
);
const sendersMessageInSendersInbox = findMessage(updatedSender.inbox.messages, receiver._id);
let [receieversMessageContent, sendersMessageContent] = ['es', 'cs'].map((lang) => {
let messageContent = t('privateMessageGiftGemsMessage', {
const [receieversMessageContent, sendersMessageContent] = ['es', 'cs'].map(lang => {
const messageContent = t('privateMessageGiftGemsMessage', {
receiverName: receiver.profile.name,
senderName: userToSendMessage.profile.name,
gemAmount,