Kai/habitica
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix test lint

Browse Source
This commit is contained in:
Matteo Pagliazzi
2019-10-08 20:45:38 +02:00
parent e37f4467f8
commit 85fb5f33aa
367 changed files with 6635 additions and 6080 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/common/fns/autoAllocate.test.js
+2 -2
View File
@@ -9,8 +9,8 @@ describe('shared.fns.autoAllocate', () => {
beforeEach(() => {
user = generateUser();
// necessary to test task training reset behavior
user.stats.toObject = function () {
let obj = JSON.parse(JSON.stringify(this));
user.stats.toObject = function toObject () {
const obj = JSON.parse(JSON.stringify(this));
return obj;
};
test/common/fns/crit.test.js
+1 -1
View File
@@ -11,7 +11,7 @@ describe('crit', () => {
});
it('computes', () => {
let result = crit.crit(user);
const result = crit.crit(user);
expect(result).to.eql(1);
});
});
test/common/fns/handleTwoHanded.js
+6 -6
View File
@@ -13,11 +13,11 @@ describe('shared.fns.handleTwoHanded', () => {
});
it('uses "messageTwoHandedUnequip" message if item is a shield and current weapon is two handed (and sets the user\'s weapon to the base one)', () => {
let item = content.gear.tree.shield.warrior['2'];
let currentWeapon = content.gear.tree.weapon.armoire.rancherLasso;
const item = content.gear.tree.shield.warrior['2'];
const currentWeapon = content.gear.tree.weapon.armoire.rancherLasso;
user.items.gear.equipped.weapon = 'weapon_armoire_rancherLasso';
let message = handleTwoHanded(user, item);
const message = handleTwoHanded(user, item);
expect(message).to.equal(i18n.t('messageTwoHandedUnequip', {
twoHandedText: currentWeapon.text(), offHandedText: item.text(),
}));
@@ -25,11 +25,11 @@ describe('shared.fns.handleTwoHanded', () => {
});
it('uses "messageTwoHandedEquip" message if item is two handed and currentShield exists but is not "shield_base_0" (and sets the user\'s shield to the base one)', () => {
let item = content.gear.tree.weapon.armoire.rancherLasso;
let currentShield = content.gear.tree.shield.armoire.gladiatorShield;
const item = content.gear.tree.weapon.armoire.rancherLasso;
const currentShield = content.gear.tree.shield.armoire.gladiatorShield;
user.items.gear.equipped.shield = 'shield_armoire_gladiatorShield';
let message = handleTwoHanded(user, item);
const message = handleTwoHanded(user, item);
expect(message).to.equal(i18n.t('messageTwoHandedEquip', {
twoHandedText: item.text(), offHandedText: currentShield.text(),
}));
test/common/fns/predictableRandom.test.js
+8 -8
View File
@@ -18,8 +18,8 @@ describe('shared.fns.predictableRandom', () => {
user.stats.hp = 43;
user.stats.gp = 34;
let val1 = predictableRandom(user);
let val2 = predictableRandom(user);
const val1 = predictableRandom(user);
const val2 = predictableRandom(user);
expect(val2).to.equal(val1);
});
@@ -27,24 +27,24 @@ describe('shared.fns.predictableRandom', () => {
it('returns a different value when user.stats is not the same and no seed is passed', () => {
user.stats.hp = 43;
user.stats.gp = 34;
let val1 = predictableRandom(user);
const val1 = predictableRandom(user);
user.stats.gp = 35;
let val2 = predictableRandom(user);
const val2 = predictableRandom(user);
expect(val2).to.not.equal(val1);
});
it('returns the same value when the same seed is passed', () => {
let val1 = predictableRandom(user, 4452673762);
let val2 = predictableRandom(user, 4452673762);
const val1 = predictableRandom(user, 4452673762);
const val2 = predictableRandom(user, 4452673762);
expect(val2).to.equal(val1);
});
it('returns a different value when a different seed is passed', () => {
let val1 = predictableRandom(user, 4452673761);
let val2 = predictableRandom(user, 4452673762);
const val1 = predictableRandom(user, 4452673761);
const val2 = predictableRandom(user, 4452673762);
expect(val2).to.not.equal(val1);
});
test/common/fns/randomDrop.test.js
+5 -4
View File
@@ -113,8 +113,9 @@ describe('common.fns.randomDrop', () => {
randomDrop(user, { task, predictableRandom });
expect(user._tmp.drop.type).to.eql('HatchingPotion');
expect(user._tmp.drop.value).to.eql(4);
let acceptableDrops = ['Zombie', 'CottonCandyPink', 'CottonCandyBlue'];
expect(acceptableDrops).to.contain(user._tmp.drop.key); // deterministically 'CottonCandyBlue'
const acceptableDrops = ['Zombie', 'CottonCandyPink', 'CottonCandyBlue'];
// deterministically 'CottonCandyBlue'
expect(acceptableDrops).to.contain(user._tmp.drop.key);
});
it('drops an uncommon potion', () => {
@@ -123,7 +124,7 @@ describe('common.fns.randomDrop', () => {
randomDrop(user, { task, predictableRandom });
expect(user._tmp.drop.type).to.eql('HatchingPotion');
expect(user._tmp.drop.value).to.eql(3);
let acceptableDrops = ['Red', 'Shade', 'Skeleton'];
const acceptableDrops = ['Red', 'Shade', 'Skeleton'];
expect(acceptableDrops).to.contain(user._tmp.drop.key); // always skeleton
});
@@ -133,7 +134,7 @@ describe('common.fns.randomDrop', () => {
randomDrop(user, { task, predictableRandom });
expect(user._tmp.drop.type).to.eql('HatchingPotion');
expect(user._tmp.drop.value).to.eql(2);
let acceptableDrops = ['Base', 'White', 'Desert'];
const acceptableDrops = ['Base', 'White', 'Desert'];
expect(acceptableDrops).to.contain(user._tmp.drop.key); // always Desert
});
});
test/common/fns/statsComputed.test.js
+9 -9
View File
@@ -11,7 +11,7 @@ describe('common.fns.statsComputed', () => {
});
it('returns default values', () => {
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.per).to.eql(0);
expect(result.con).to.eql(0);
expect(result.str).to.eql(0);
@@ -20,7 +20,7 @@ describe('common.fns.statsComputed', () => {
it('calculates stat bonuses for equipment', () => {
user.items.gear.equipped.weapon = 'weapon_rogue_1';
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.str).to.eql(2);
expect(result.gearBonus.str).to.eql(2);
@@ -28,7 +28,7 @@ describe('common.fns.statsComputed', () => {
it('calculates stat bonuses for class', () => {
user.items.gear.equipped.weapon = 'weapon_warrior_1';
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.str).to.eql(4.5);
expect(result.gearBonus.str).to.eql(3);
@@ -37,7 +37,7 @@ describe('common.fns.statsComputed', () => {
it('calculates stat bonuses for level', () => {
user.stats.lvl = 25;
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.str).to.eql(12);
expect(result.levelBonus.str).to.eql(12);
@@ -45,7 +45,7 @@ describe('common.fns.statsComputed', () => {
it('correctly caps level stat bonuses', () => {
user.stats.lvl = 150;
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.str).to.eql(50);
expect(result.levelBonus.str).to.eql(50);
@@ -53,7 +53,7 @@ describe('common.fns.statsComputed', () => {
it('sets baseStat field', () => {
user.stats.str = 20;
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.str).to.eql(20);
expect(result.baseStat.str).to.eql(20);
@@ -61,7 +61,7 @@ describe('common.fns.statsComputed', () => {
it('sets buffs field', () => {
user.stats.buffs.str = 150;
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.str).to.eql(150);
expect(result.buff.str).to.eql(150);
@@ -70,14 +70,14 @@ describe('common.fns.statsComputed', () => {
it('calculates mp from intelligence', () => {
user.stats.int = 150;
user.stats.buffs.int = 50;
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.maxMP).to.eql(430);
});
it('calculates stat bonuses for back equipment', () => {
user.items.gear.equipped.back = 'back_special_takeThis';
let result = statsComputed(user);
const result = statsComputed(user);
expect(result.int).to.eql(1);
expect(result.per).to.eql(1);
test/common/fns/ultimateGear.js
+15 -19
View File
@@ -8,24 +8,22 @@ describe('shared.fns.ultimateGear', () => {
beforeEach(() => {
user = generateUser();
user.achievements.ultimateGearSets.toObject = function () {
user.achievements.ultimateGearSets.toObject = function toIbject () {
return this;
};
user.addNotification = sinon.spy();
});
it('sets armoirEnabled when partial achievement already achieved', () => {
let items = {
const items = {
gear: {
owned: {
toObject: () => {
return {
armor_warrior_5: true, // eslint-disable-line camelcase
shield_warrior_5: true, // eslint-disable-line camelcase
head_warrior_5: true, // eslint-disable-line camelcase
weapon_warrior_6: true, // eslint-disable-line camelcase
};
},
toObject: () => ({
armor_warrior_5: true, // eslint-disable-line camelcase
shield_warrior_5: true, // eslint-disable-line camelcase
head_warrior_5: true, // eslint-disable-line camelcase
weapon_warrior_6: true, // eslint-disable-line camelcase
}),
},
},
};
@@ -40,17 +38,15 @@ describe('shared.fns.ultimateGear', () => {
it('does not set armoireEnabled when gear is not owned', () => {
user.flags.armoireEnabled = false;
let items = {
const items = {
gear: {
owned: {
toObject: () => {
return {
armor_warrior_5: true, // eslint-disable-line camelcase
shield_warrior_5: true, // eslint-disable-line camelcase
head_warrior_5: true, // eslint-disable-line camelcase
weapon_warrior_6: false, // eslint-disable-line camelcase
};
},
toObject: () => ({
armor_warrior_5: true, // eslint-disable-line camelcase
shield_warrior_5: true, // eslint-disable-line camelcase
head_warrior_5: true, // eslint-disable-line camelcase
weapon_warrior_6: false, // eslint-disable-line camelcase
}),
},
},
};
test/common/fns/updateStats.test.js
+9 -9
View File
@@ -12,8 +12,8 @@ describe('common.fns.updateStats', () => {
});
context('No Hp', () => {
it('updates user\s hp', () => {
let stats = { hp: 0 };
it('updates user\'s hp', () => {
const stats = { hp: 0 };
expect(user.stats.hp).to.not.eql(0);
updateStats(user, stats);
expect(user.stats.hp).to.eql(0);
@@ -22,7 +22,7 @@ describe('common.fns.updateStats', () => {
});
it('does not lower hp below 0', () => {
let stats = {
const stats = {
hp: -5,
};
updateStats(user, stats);
@@ -32,7 +32,7 @@ describe('common.fns.updateStats', () => {
context('Stat Allocation', () => {
it('adds only attribute points up to user\'s level', () => {
let stats = {
const stats = {
exp: 261,
};
expect(user.stats.points).to.eql(0);
@@ -45,7 +45,7 @@ describe('common.fns.updateStats', () => {
});
it('adds an attibute point when user\'s stat points are less than max level', () => {
let stats = {
const stats = {
exp: 3581,
};
@@ -61,7 +61,7 @@ describe('common.fns.updateStats', () => {
});
it('does not add an attibute point when user\'s stat points are equal to max level', () => {
let stats = {
const stats = {
exp: 3581,
};
@@ -77,7 +77,7 @@ describe('common.fns.updateStats', () => {
});
it('does not add an attibute point when user\'s stat points + unallocated points are equal to max level', () => {
let stats = {
const stats = {
exp: 3581,
};
@@ -94,7 +94,7 @@ describe('common.fns.updateStats', () => {
});
it('only awards stat points up to level 100 if user is missing unallocated stat points and is over level 100', () => {
let stats = {
const stats = {
exp: 5581,
};
@@ -182,7 +182,7 @@ describe('common.fns.updateStats', () => {
xit('auto allocates stats if automaticAllocation is turned on', () => {
sandbox.stub(user.fns, 'autoAllocate');
let stats = {
const stats = {
exp: 261,
};