From 8f211ee3e2f7decf9426004ae5feb031a3d34fca Mon Sep 17 00:00:00 2001
From: SabreCat <sabe@habitica.com>
Date: Mon, 25 Sep 2023 17:32:04 -0500
Subject: [PATCH] fix(profile): fix admin actions Correct "user is banned"
 banner Fix bouncing modal Add "Days" smart plural Fix leaky CSS on Market
 page Refactor some redundant functions

---
 .../src/components/shops/market/sellModal.vue |  78 +++++----
 .../src/components/userMenu/profile.vue       | 160 ++++++------------
 .../src/components/userMenu/profileModal.vue  |  10 +-
 website/client/src/router/index.js            |   9 +-
 4 files changed, 98 insertions(+), 159 deletions(-)

diff --git a/website/client/src/components/shops/market/sellModal.vue b/website/client/src/components/shops/market/sellModal.vue
index 6bbc95599c..1f839c8fca 100644
--- a/website/client/src/components/shops/market/sellModal.vue
+++ b/website/client/src/components/shops/market/sellModal.vue
@@ -265,25 +265,24 @@
         align-items: center;
       }
     }
-  }
 
-  .how-many-to-sell {
-    font-weight: bold !important;
-  }
-
-  .number-increment {
-     margin-top: 16px;
-  }
-
-  .total-row {
-    font-weight: bold;
-    font-size: 0.875rem;
-    margin-top: 16px;
-
-    &.gold {
-      color: $yellow-5;
+    .how-many-to-sell {
+      font-weight: bold !important;
+    }
+
+    .number-increment {
+      margin-top: 16px;
+    }
+
+    .total-row {
+      font-weight: bold;
+      font-size: 0.875rem;
+      margin-top: 16px;
+
+      &.gold {
+        color: $yellow-5;
+      }
     }
-  }
 
     .total-text {
       color: $gray-50;
@@ -291,32 +290,31 @@
       font-size: 0.875rem;
       line-height: 1.71;
 
-    &.gold {
-      color: $yellow-5;
-    }
-  }
-
-  button.btn.btn-primary {
-    margin-top: 16px;
-    padding: 4px 16px;
-    height: 32px;
-
-    &:focus {
-      border: 2px solid black;
+      &.gold {
+        color: $yellow-5;
+      }
     }
 
-  .balance {
-    width: 74px;
-    height: 16px;
-    font-size: 12px;
-    font-weight: bold;
-    line-height: 1.33;
-    color: $gray-200;
+    button.btn.btn-primary {
+      margin-top: 16px;
+      padding: 4px 16px;
+      height: 32px;
+
+      &:focus {
+        border: 2px solid black;
+      }
+
+      .balance {
+        width: 74px;
+        height: 16px;
+        font-size: 12px;
+        font-weight: bold;
+        line-height: 1.33;
+        color: $gray-200;
+      }
+    }
   }
-
-
-}
-</style>
+  </style>
 
 <script>
 import svgClose from '@/assets/svg/close.svg';
diff --git a/website/client/src/components/userMenu/profile.vue b/website/client/src/components/userMenu/profile.vue
index c1224ef44c..c952a97d76 100644
--- a/website/client/src/components/userMenu/profile.vue
+++ b/website/client/src/components/userMenu/profile.vue
@@ -22,30 +22,28 @@
         </div>
       </div>
       <!-- PAGE STATE CHANGES -->
-      <div class="row state-pages">
+      <div class="state-pages pt-3">
         <div
           v-if="userBlocked"
-          class="blocked-user d-flex mx-auto"
+          class="blocked-banned text-center mb-3 mx-4 py-2 px-3"
           v-html="$t('blockedUser')"
         >
         </div>
         <div
-          v-if="hasPermission(userLoggedIn, 'moderator')"
-          class="banned-user d-flex mx-auto"
+          v-if="hasPermission(userLoggedIn, 'moderator') && hero.auth.blocked"
+          class="blocked-banned mb-3 mx-4 py-2 px-3
+            d-flex align-items-middle justify-content-center"
         >
-          <span
-            v-if="hero.auth.blocked = true"
+          <div
+            v-once
+            class="svg-icon icon-16 color my-auto ml-auto mr-2"
+            v-html="icons.block"
+          ></div>
+          <div
+            class="my-auto mr-auto"
+            v-html="$t('bannedUser')"
           >
-            <span
-              v-once
-              class="svg-icon icon-16 color"
-              v-html="icons.block"
-            ></span>
-            <span
-              v-html="$t('bannedUser')"
-            >
-            </span>
-          </span>
+          </div>
         </div>
         <div class="text-center nav">
           <div
@@ -193,7 +191,7 @@
                 <b-dropdown-item
                   v-if="!userBlocked"
                   class="selectListItem block-ban"
-                  @click="blockUser()"
+                  @click.native.capture.stop="blockUser()"
                 >
                   <span class="with-icon">
                     <span
@@ -209,7 +207,7 @@
                 <b-dropdown-item
                   v-else
                   class="selectListItem block-ban"
-                  @click="unblockUser()"
+                  @click.native.capture.stop="unblockUser()"
                 >
                   <span class="with-icon">
                     <span
@@ -258,7 +256,7 @@
                   <b-dropdown-item
                     v-if="!hero.auth.blocked"
                     class="selectListItem block-ban"
-                    @click.native.capture.stop="adminBlockUser()"
+                    @click.native.capture.stop="adminToggleBan()"
                   >
                     <span class="with-icon">
                       <span
@@ -274,7 +272,7 @@
                   <b-dropdown-item
                     v-else
                     class="selectListItem block-ban"
-                    @click.native.capture.stop="adminUnblockUser()"
+                    @click.native.capture.stop="adminToggleBan()"
                   >
                     <span class="with-icon">
                       <span
@@ -291,9 +289,7 @@
                   <!-- SHADOW MUTE PLAYER WITH TOGGLE -->
                   <b-dropdown-item
                     class="selectListItem"
-                    @click.native.capture.stop="!hero.flags.chatShadowMuted
-                      ? adminTurnOnShadowMuting()
-                      : adminTurnOffShadowMuting()"
+                    @click.native.capture.stop="adminToggleShadowMute()"
                   >
                     <span class="with-icon">
                       <span
@@ -310,9 +306,7 @@
                       <toggle-switch
                         v-model="hero.flags.chatShadowMuted"
                         class="toggle-switch-outer ml-auto"
-                        @change.native.capture.stop="!hero.flags.chatShadowMuted
-                          ? adminTurnOnShadowMuting()
-                          : adminTurnOffShadowMuting()"
+                        @change.native.capture.stop="adminToggleShadowMute()"
                       />
                     </span>
                   </b-dropdown-item>
@@ -320,9 +314,7 @@
                   <!-- MUTE PLAYER WITH TOGGLE -->
                   <b-dropdown-item
                     class="selectListItem"
-                    @click.native.capture.stop="!hero.flags.chatRevoked
-                      ? adminRevokeChat()
-                      : adminReinstateChat()"
+                    @click.native.capture.stop="adminToggleChatRevoke()"
                   >
                     <span class="with-icon">
                       <span
@@ -336,9 +328,7 @@
                       <toggle-switch
                         v-model="hero.flags.chatRevoked"
                         class="toggle-switch-outer ml-auto"
-                        @change.native.capture.stop="!hero.flags.chatRevoked
-                          ? adminRevokeChat()
-                          : adminReinstateChat()"
+                        @change.native.capture.stop="adminToggleChatRevoke()"
                       />
                     </span>
                   </b-dropdown-item>
@@ -377,7 +367,7 @@
                   {{ $t('nextReward') }}:
                 </div>
                 <div class="info-item-value">
-                  {{ nextIncentive }} {{ $t('days') }}
+                  {{ getNextIncentive() }} {{ getNextIncentive() === 1 ? $t('day') : $t('days') }}
                 </div>
               </div>
             </div>
@@ -576,19 +566,22 @@
       width: 210px;
     }
 
-    .dropdown-item.disabled {
-      color: $gray-50 !important;
-      opacity: 0.75;
+    .dropdown-item {
       svg {
         color: $gray-50;
-        opacity: 0.75;
       }
-    }
-
-    .dropdown-item:not(.disabled):hover,
-    .dropdown-item:not(.disabled):focus {
-      a, svg {
-        color: $purple-300;
+      &.disabled {
+        color: $gray-50 !important;
+        opacity: 0.75;
+        svg {
+          color: $gray-50;
+          opacity: 0.75;
+        }
+      }
+      &:not(.disabled):hover, &:not(.disabled):focus {
+        a, svg {
+          color: $purple-300;
+        }
       }
     }
 
@@ -731,36 +724,16 @@
     }
   }
 
-  .svg-icon {
-    color: $gray-50 !important;
-    display: block;
-    margin: 0 auto;
-  }
-
   .message-icon svg {
     height: 11px;
     margin-top: 1px;
   }
 
-  .gift-icon svg {
-    height: 16px;
-    margin: auto;
-    width: 14px;
-  }
-
   .dots-icon {
     height: 16px;
     width: 4px;
   }
 
-  .block-icon, .report-icon {
-    width: 16px;
-  }
-
-  .positive-icon {
-    width: 14px;
-  }
-
   .toggle-switch-outer {
     margin-bottom: 2px;
   }
@@ -782,31 +755,14 @@
     }
   }
 
-  .blocked-user {
+  .blocked-banned {
     background-color: $maroon-100;
     border-radius: 4px;
     color: $white;
-    height: 40px;
     line-height: 1.71;
-    margin-top: 16px;
-    padding: 8px 16px;
-  }
-
-  .banned-user {
-    background-color: $maroon-100;
-    border-radius: 4px;
-    color: $white;
-    height: 40px;
-    line-height: 1.71;
-    margin-top: 16px;
-    padding: 8px 16px;
-
-    .color {
-      color: $white !important;
-    }
 
     svg {
-      display: inline;
+      color: $white;
     }
   }
 
@@ -1123,9 +1079,6 @@ export default {
     costumeItems () {
       return this.user.items.gear.costume;
     },
-    nextIncentive () {
-      return this.getNextIncentive();
-    },
     classText () {
       const classTexts = {
         warrior: this.$t('warrior'),
@@ -1303,45 +1256,28 @@ export default {
       this.$root.$emit('habitica::send-gift', this.user);
     },
 
-    adminTurnOnShadowMuting () {
+    adminToggleShadowMute () {
       if (!this.hero.flags) {
         this.hero.flags = {};
+        this.hero.flags.chatShadowMuted = true;
+      } else {
+        this.hero.flags.chatShadowMuted = !this.hero.flags.chatShadowMuted;
       }
-      this.hero.flags.chatShadowMuted = true;
       this.$store.dispatch('hall:updateHero', { heroDetails: this.hero });
     },
 
-    adminTurnOffShadowMuting () {
+    adminToggleChatRevoke () {
       if (!this.hero.flags) {
         this.hero.flags = {};
+        this.hero.flags.chatRevoked = true;
+      } else {
+        this.hero.flags.chatRevoked = !this.hero.flags.chatRevoked;
       }
-      this.hero.flags.chatShadowMuted = false;
       this.$store.dispatch('hall:updateHero', { heroDetails: this.hero });
     },
 
-    adminRevokeChat () {
-      if (!this.hero.flags) {
-        this.hero.flags = {};
-      }
-      this.hero.flags.chatRevoked = true;
-      this.$store.dispatch('hall:updateHero', { heroDetails: this.hero });
-    },
-
-    adminReinstateChat () {
-      if (!this.hero.flags) {
-        this.hero.flags = {};
-      }
-      this.hero.flags.chatRevoked = false;
-      this.$store.dispatch('hall:updateHero', { heroDetails: this.hero });
-    },
-
-    adminBlockUser () {
-      this.hero.auth.blocked = true;
-      this.$store.dispatch('hall:updateHero', { heroDetails: this.hero });
-    },
-
-    adminUnblockUser () {
-      this.hero.auth.blocked = false;
+    adminToggleBan () {
+      this.hero.auth.blocked = !this.hero.auth.blocked;
       this.$store.dispatch('hall:updateHero', { heroDetails: this.hero });
     },
 
diff --git a/website/client/src/components/userMenu/profileModal.vue b/website/client/src/components/userMenu/profileModal.vue
index 4eb584e4a2..96f1609713 100644
--- a/website/client/src/components/userMenu/profileModal.vue
+++ b/website/client/src/components/userMenu/profileModal.vue
@@ -65,14 +65,16 @@ export default {
     return {
       userId: undefined,
       startingPage: undefined,
-      path: undefined,
+      fromPath: undefined,
+      toPath: undefined,
     };
   },
   mounted () {
     this.$root.$on('habitica:show-profile', data => {
       this.userId = data.userId;
       this.startingPage = data.startingPage || 'profile';
-      this.path = data.path;
+      this.fromPath = data.fromPath;
+      this.toPath = data.toPath;
       this.$root.$emit('bv::show::modal', 'profile');
     });
   },
@@ -81,11 +83,11 @@ export default {
   },
   methods: {
     onShown () {
-      window.history.pushState('', null, this.path);
+      window.history.pushState('', null, this.toPath);
     },
     beforeHide () {
       if (this.$route.path !== window.location.pathname) {
-        this.$router.back();
+        window.history.pushState('', null, this.fromPath);
       }
     },
     close () {
diff --git a/website/client/src/router/index.js b/website/client/src/router/index.js
index 41a728deec..3238f17c44 100644
--- a/website/client/src/router/index.js
+++ b/website/client/src/router/index.js
@@ -323,14 +323,16 @@ router.beforeEach(async (to, from, next) => {
       setTimeout(() => router.app.$emit('habitica:show-profile', {
         userId: to.params.userId,
         startingPage,
-        path: to.path,
+        fromPath: '/',
+        toPath: to.path,
       }), 500);
       return next({ name: 'tasks' });
     }
     router.app.$emit('habitica:show-profile', {
       userId: to.params.userId,
       startingPage,
-      path: to.path,
+      fromPath: from.path,
+      toPath: to.path,
     });
 
     return null;
@@ -344,7 +346,8 @@ router.beforeEach(async (to, from, next) => {
   if ((to.name === 'stats' || to.name === 'achievements' || to.name === 'profile') && from.name !== null) {
     router.app.$emit('habitica:show-profile', {
       startingPage: to.name,
-      path: to.path,
+      fromPath: from.path,
+      toPath: to.path,
     });
     return null;
   }