Upgrade ESLint to v3 (#8299)

* upgraded habitrpg-eslint-config to v2 and eslint to v3

* adapt to eslint3 rules

* update shrinkwrap

* update shrinkwrap again

test/api/v3/integration/groups/GET-groups_groupId_members.test.js

@@ -82,8 +82,10 @@ describe('GET /groups/:groupId/members', () => {
       'backer', 'contributor', 'auth', 'items', 'inbox',
     ]);
     expect(Object.keys(memberRes.auth)).to.eql(['timestamps']);
-    expect(Object.keys(memberRes.preferences).sort()).to.eql(['size', 'hair', 'skin', 'shirt',
-      'chair', 'costume', 'sleep', 'background'].sort());
+    expect(Object.keys(memberRes.preferences).sort()).to.eql([
+      'size', 'hair', 'skin', 'shirt',
+      'chair', 'costume', 'sleep', 'background',
+    ].sort());
 
     expect(memberRes.stats.maxMP).to.exist;
     expect(memberRes.stats.maxHealth).to.equal(common.maxHealth);

test/api/v3/integration/members/GET-members_id.test.js

@@ -35,8 +35,10 @@ describe('GET /members/:memberId', () => {
       'backer', 'contributor', 'auth', 'items', 'inbox',
     ]);
     expect(Object.keys(memberRes.auth)).to.eql(['timestamps']);
-    expect(Object.keys(memberRes.preferences).sort()).to.eql(['size', 'hair', 'skin', 'shirt',
-      'chair', 'costume', 'sleep', 'background'].sort());
+    expect(Object.keys(memberRes.preferences).sort()).to.eql([
+      'size', 'hair', 'skin', 'shirt',
+      'chair', 'costume', 'sleep', 'background',
+    ].sort());
 
     expect(memberRes.stats.maxMP).to.exist;
     expect(memberRes.stats.maxHealth).to.equal(common.maxHealth);

test/api/v3/integration/tasks/GET-tasks_user.test.js

@@ -115,7 +115,7 @@ describe('GET /tasks/user', () => {
     for (let i = 0; i < numberOfTodos; i++) {
       let id = todos[i]._id;
 
-      await user.post(`/tasks/${id}/score/up`); // eslint-disable-line babel/no-await-in-loop
+      await user.post(`/tasks/${id}/score/up`); // eslint-disable-line no-await-in-loop
     }
     await user.sync();
 

test/api/v3/integration/tasks/POST-tasks_clearCompletedTodos.test.js

@@ -29,7 +29,7 @@ describe('POST /tasks/clearCompletedTodos', () => {
 
     for (let task of tasks) {
       if (['todo 2', 'todo 3', 'todo 6'].indexOf(task.text) !== -1) {
-        await user.post(`/tasks/${task._id}/score/up`); // eslint-disable-line babel/no-await-in-loop
+        await user.post(`/tasks/${task._id}/score/up`); // eslint-disable-line no-await-in-loop
       }
     }
 

test/api/v3/unit/libs/analyticsService.test.js

@@ -353,7 +353,8 @@ describe('analyticsService', () => {
         purchaseType: 'checkout',
         gift: false,
         quantity: 1,
-        headers: {'x-client': 'habitica-web',
+        headers: {
+          'x-client': 'habitica-web',
           'user-agent': '',
         },
       };

test/api/v3/unit/libs/cron.test.js

@@ -300,7 +300,7 @@ describe('cron', () => {
         startDate: new Date(),
       };
 
-      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line babel/new-cap
+      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line new-cap
       tasksByType.dailys.push(task);
       tasksByType.dailys[0].completed = true;
 
@@ -321,7 +321,7 @@ describe('cron', () => {
         value: 0,
       };
 
-      let task = new Tasks.todo(Tasks.Task.sanitize(todo)); // eslint-disable-line babel/new-cap
+      let task = new Tasks.todo(Tasks.Task.sanitize(todo)); // eslint-disable-line new-cap
       tasksByType.todos.push(task);
     });
 
@@ -347,7 +347,7 @@ describe('cron', () => {
         type: 'daily',
       };
 
-      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line babel/new-cap
+      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line new-cap
       tasksByType.dailys = [];
       tasksByType.dailys.push(task);
 
@@ -449,7 +449,7 @@ describe('cron', () => {
         type: 'habit',
       };
 
-      let task = new Tasks.habit(Tasks.Task.sanitize(habit)); // eslint-disable-line babel/new-cap
+      let task = new Tasks.habit(Tasks.Task.sanitize(habit)); // eslint-disable-line new-cap
       tasksByType.habits = [];
       tasksByType.habits.push(task);
     });
@@ -490,7 +490,7 @@ describe('cron', () => {
         type: 'daily',
       };
 
-      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line babel/new-cap
+      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line new-cap
       tasksByType.dailys = [];
       tasksByType.dailys.push(task);
 
@@ -633,7 +633,7 @@ describe('cron', () => {
         type: 'daily',
       };
 
-      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line babel/new-cap
+      let task = new Tasks.daily(Tasks.Task.sanitize(daily)); // eslint-disable-line new-cap
       tasksByType.dailys = [];
       tasksByType.dailys.push(task);
 

test/api/v3/unit/models/challenge.test.js

@@ -166,7 +166,7 @@ describe('Challenge Model', () => {
 
   context('type specific updates', () => {
     it('updates habit specific field to challenge and challenge members', async () => {
-      task = new Tasks.habit(Tasks.Task.sanitize(tasksToTest.habit)); // eslint-disable-line babel/new-cap
+      task = new Tasks.habit(Tasks.Task.sanitize(tasksToTest.habit)); // eslint-disable-line new-cap
       task.challenge.id = challenge._id;
       await task.save();
 
@@ -185,7 +185,7 @@ describe('Challenge Model', () => {
     });
 
     it('updates todo specific field to challenge and challenge members', async () => {
-      task = new Tasks.todo(Tasks.Task.sanitize(tasksToTest.todo)); // eslint-disable-line babel/new-cap
+      task = new Tasks.todo(Tasks.Task.sanitize(tasksToTest.todo)); // eslint-disable-line new-cap
       task.challenge.id = challenge._id;
       await task.save();
 
@@ -201,7 +201,7 @@ describe('Challenge Model', () => {
     });
 
     it('does not update checklists on the user task', async () => {
-      task = new Tasks.todo(Tasks.Task.sanitize(tasksToTest.todo)); // eslint-disable-line babel/new-cap
+      task = new Tasks.todo(Tasks.Task.sanitize(tasksToTest.todo)); // eslint-disable-line new-cap
       task.challenge.id = challenge._id;
       await task.save();
 
@@ -219,7 +219,7 @@ describe('Challenge Model', () => {
     });
 
     it('updates daily specific field to challenge and challenge members', async () => {
-      task = new Tasks.daily(Tasks.Task.sanitize(tasksToTest.daily)); // eslint-disable-line babel/new-cap
+      task = new Tasks.daily(Tasks.Task.sanitize(tasksToTest.daily)); // eslint-disable-line new-cap
       task.challenge.id = challenge._id;
       await task.save();
 

test/api/v3/unit/models/task.test.js

@@ -81,7 +81,7 @@ describe('Task Model', () => {
         user = new User();
         await user.save();
 
-        taskWithAlias = new Tasks.todo({ // eslint-disable-line babel/new-cap
+        taskWithAlias = new Tasks.todo({ // eslint-disable-line new-cap
           text: 'some text',
           alias: 'short-name',
           userId: user.id,