Kai/habitica
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lint: Correct linting errors in api v3 tests

Browse Source
This commit is contained in:
Blade Barringer
2015-12-31 08:50:02 -06:00
parent 70151fd073
commit 9428c6d997
25 changed files with 218 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/api/v3/unit/libs/analyticsService.test.js
+28 -28
View File
@@ -6,12 +6,12 @@ describe('analyticsService', () => {
let amplitudeNock, gaNock;
beforeEach(() => {
amplitudeNock = nock( 'https://api.amplitude.com')
amplitudeNock = nock('https://api.amplitude.com')
.filteringPath(/httpapi.*/g, '')
.post('/')
.reply(200, {status: 'OK'});
gaNock = nock( 'http://www.google-analytics.com');
gaNock = nock('http://www.google-analytics.com');
});
describe('#track', () => {
@@ -23,14 +23,14 @@ describe('analyticsService', () => {
category: 'behavior',
uuid: 'unique-user-id',
resting: true,
cronCount: 5
cronCount: 5,
};
});
context('Amplitude', () => {
it('calls out to amplitude', () => {
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -42,7 +42,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*user_id.*no-user-id-was-provided.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -52,7 +52,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*platform.*server.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -62,7 +62,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*event_properties%22%3A%7B%22category%22%3A%22behavior%22%2C%22resting%22%3Atrue%2C%22cronCount%22%3A5%7D%2C%22.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -74,7 +74,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*itemName.*Fox%20Ears.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -86,7 +86,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*itemName.*Wolf%20Egg.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -98,7 +98,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*itemName.*Bare%20Bones%20Cake.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -110,7 +110,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*itemName.*Golden%20Hatching%20Potion.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -122,7 +122,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*itemName.*Attack%20of%20the%20Mundane%2C%20Part%201%3A%20Dish%20Disaster!.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -134,7 +134,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*itemName.*Seafoam.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -142,14 +142,14 @@ describe('analyticsService', () => {
it('sends user data if provided', () => {
let stats = { class: 'wizard', exp: 5, gp: 23, hp: 10, lvl: 4, mp: 30 };
let user = {
stats: stats,
stats,
contributor: { level: 1 },
purchased: { plan: { planId: 'foo-plan' } },
flags: {tour: {intro: -2}},
habits: [{_id: 'habit'}],
dailys: [{_id: 'daily'}],
todos: [{_id: 'todo'}],
rewards: [{_id: 'reward'}]
rewards: [{_id: 'reward'}],
};
data.user = user;
@@ -158,7 +158,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*user_properties%22%3A%7B%22Class%22%3A%22wizard%22%2C%22Experience%22%3A5%2C%22Gold%22%3A23%2C%22Health%22%3A10%2C%22Level%22%3A4%2C%22Mana%22%3A30%2C%22tutorialComplete%22%3Atrue%2C%22Number%20Of%20Tasks%22%3A%7B%22habits%22%3A1%2C%22dailys%22%3A1%2C%22todos%22%3A1%2C%22rewards%22%3A1%7D%2C%22contributorLevel%22%3A1%2C%22subscription%22%3A%22foo-plan%22%7D%2C%22.*/g, '');
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -171,7 +171,7 @@ describe('analyticsService', () => {
.reply(200, {status: 'OK'});
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
gaNock.done();
});
});
@@ -182,7 +182,7 @@ describe('analyticsService', () => {
.reply(200, {status: 'OK'});
return analyticsService.track(eventType, data)
.then((res) => {
.then(() => {
gaNock.done();
});
});
@@ -201,14 +201,14 @@ describe('analyticsService', () => {
purchaseValue: 8,
purchaseType: 'checkout',
gift: false,
quantity: 1
quantity: 1,
};
});
context('Amplitude', () => {
it('calls out to amplitude', () => {
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -220,7 +220,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*user_id.*no-user-id-was-provided.*/g, '');
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -230,7 +230,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*platform.*server.*/g, '');
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -240,7 +240,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*aypal-checkout%22%2C%22paymentMethod%22%3A%22PayPal%22%2C%22itemPurchased%22%3A%22Gems%22%2C%22purchaseType%22%3A%22checkout%22%2C%22gift%22%3Afalse%2C%22quantity%22%3A1%7D%2C%22event_type%22%3A%22purchase%22%2C%22revenue.*/g, '');
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -248,14 +248,14 @@ describe('analyticsService', () => {
it('sends user data if provided', () => {
let stats = { class: 'wizard', exp: 5, gp: 23, hp: 10, lvl: 4, mp: 30 };
let user = {
stats: stats,
stats,
contributor: { level: 1 },
purchased: { plan: { planId: 'foo-plan' } },
flags: {tour: {intro: -2}},
habits: [{_id: 'habit'}],
dailys: [{_id: 'daily'}],
todos: [{_id: 'todo'}],
rewards: [{_id: 'reward'}]
rewards: [{_id: 'reward'}],
};
data.user = user;
@@ -264,7 +264,7 @@ describe('analyticsService', () => {
.filteringPath(/httpapi.*user_properties%22%3A%7B%22Class%22%3A%22wizard%22%2C%22Experience%22%3A5%2C%22Gold%22%3A23%2C%22Health%22%3A10%2C%22Level%22%3A4%2C%22Mana%22%3A30%2C%22tutorialComplete%22%3Atrue%2C%22Number%20Of%20Tasks%22%3A%7B%22habits%22%3A1%2C%22dailys%22%3A1%2C%22todos%22%3A1%2C%22rewards%22%3A1%7D%2C%22contributorLevel%22%3A1%2C%22subscription%22%3A%22foo-plan%22%7D%2C%22.*/g, '');
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
amplitudeNock.done();
});
});
@@ -277,7 +277,7 @@ describe('analyticsService', () => {
.reply(200, {status: 'OK'});
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
gaNock.done();
});
});
@@ -290,7 +290,7 @@ describe('analyticsService', () => {
.reply(200, {status: 'OK'});
return analyticsService.trackPurchase(data)
.then((res) => {
.then(() => {
gaNock.done();
});
});
test/api/v3/unit/libs/baseModel.test.js
+5 -5
View File
@@ -32,7 +32,7 @@ describe('Base model plugin', () => {
it('can sanitize input objects', () => {
baseModel(schema, {
noSet: ['noUpdateForMe']
noSet: ['noUpdateForMe'],
});
expect(schema.statics.sanitize).to.exist;
@@ -45,7 +45,7 @@ describe('Base model plugin', () => {
it('accepts an array of additional fields to sanitize at runtime', () => {
baseModel(schema, {
noSet: ['noUpdateForMe']
noSet: ['noUpdateForMe'],
});
expect(schema.statics.sanitize).to.exist;
@@ -59,7 +59,7 @@ describe('Base model plugin', () => {
it('can make fields private', () => {
baseModel(schema, {
private: ['amPrivate']
private: ['amPrivate'],
});
expect(schema.options.toJSON.transform).to.exist;
@@ -73,7 +73,7 @@ describe('Base model plugin', () => {
it('accepts a further transform function for toJSON', () => {
let options = {
private: ['amPrivate'],
toJSONTransform: sandbox.stub().returns(true)
toJSONTransform: sandbox.stub().returns(true),
};
baseModel(schema, options);
@@ -88,7 +88,7 @@ describe('Base model plugin', () => {
it('accepts a transform function for sanitize', () => {
let options = {
private: ['amPrivate'],
sanitizeTransform: sandbox.stub().returns(true)
sanitizeTransform: sandbox.stub().returns(true),
};
baseModel(schema, options);
test/api/v3/unit/libs/buildManifest.test.js
+3 -2
View File
@@ -11,8 +11,9 @@ describe('Build Manifest', () => {
});
it('throws an error in case the page does not exist', () => {
let getManifestFilesFn = () => { getManifestFiles('strange name here'); };
expect(getManifestFilesFn).to.throw(Error);
expect(() => {
getManifestFiles('strange name here');
}).to.throw(Error);
});
});
});
test/api/v3/unit/libs/email.test.js
+20 -20
View File
@@ -1,3 +1,4 @@
/* eslint-disable global-require */
import request from 'request';
import nconf from 'nconf';
import nodemailer from 'nodemailer';
@@ -14,17 +15,17 @@ function getUser () {
},
facebook: {
emails: [{
value: 'email@facebook'
value: 'email@facebook',
}],
displayName: 'fb display name',
}
},
},
profile: {
name: 'profile name',
},
preferences: {
emailNotifications: {
unsubscribeFromAll: false
unsubscribeFromAll: false,
},
},
};
@@ -63,7 +64,7 @@ describe('emails', () => {
attachEmail.send();
expect(sendMailSpy).to.be.calledOnce;
deferred.reject();
deferred.promise.catch((err) => {
deferred.promise.catch(() => {
expect(logger.error).to.be.calledOnce;
done();
});
@@ -93,8 +94,8 @@ describe('emails', () => {
let attachEmail = require(pathToEmailLib);
let getUserInfo = attachEmail.getUserInfo;
let user = getUser();
delete user.profile['name'];
delete user.auth['local'];
delete user.profile.name;
delete user.auth.local;
let data = getUserInfo(user, ['name', 'email', '_id', 'canSend']);
@@ -108,9 +109,9 @@ describe('emails', () => {
let attachEmail = require(pathToEmailLib);
let getUserInfo = attachEmail.getUserInfo;
let user = getUser();
delete user.profile['name'];
delete user.auth.local['email'];
delete user.auth['facebook'];
delete user.profile.name;
delete user.auth.local.email;
delete user.auth.facebook;
let data = getUserInfo(user, ['name', 'email', '_id', 'canSend']);
@@ -148,8 +149,8 @@ describe('emails', () => {
to: sinon.match((value) => {
return Array.isArray(value) && value[0].name === mailingInfo.name;
}, 'matches mailing info array'),
}
}
},
},
}));
});
@@ -160,7 +161,7 @@ describe('emails', () => {
let emailType = 'an email type';
let mailingInfo = {
name: 'my name',
//email: 'my@email',
// email: 'my@email',
};
sendTxnEmail(mailingInfo, emailType);
@@ -180,8 +181,8 @@ describe('emails', () => {
data: {
emailType: sinon.match.same(emailType),
to: sinon.match(val => val[0]._id === mailingInfo._id),
}
}
},
},
}));
});
@@ -204,13 +205,12 @@ describe('emails', () => {
return value[0].name === 'BASE_URL';
}, 'matches variables'),
personalVariables: sinon.match((value) => {
return (value[0].rcpt === mailingInfo.email
&& value[0].vars[0].name === 'RECIPIENT_NAME'
&& value[0].vars[1].name === 'RECIPIENT_UNSUB_URL'
);
return value[0].rcpt === mailingInfo.email &&
value[0].vars[0].name === 'RECIPIENT_NAME' &&
value[0].vars[1].name === 'RECIPIENT_UNSUB_URL';
}, 'matches personal variables'),
}
}
},
},
}));
});
});
test/api/v3/unit/libs/webhooks.test.js
+21 -22
View File
@@ -2,7 +2,6 @@ import request from 'request';
import { sendTaskWebhook } from '../../../../../website/src/libs/api-v3/webhook';
describe('webhooks', () => {
beforeEach(() => {
sandbox.stub(request, 'post');
});
@@ -15,12 +14,12 @@ describe('webhooks', () => {
let task = {
details: { _id: 'task-id' },
delta: 1.4,
direction: 'up'
direction: 'up',
};
let data = {
task: task,
user: { _id: 'user-id' }
task,
user: { _id: 'user-id' },
};
it('does not send if no webhook endpoints exist', () => {
@@ -37,8 +36,8 @@ describe('webhooks', () => {
sort: 0,
id: 'some-id',
enabled: false,
url: 'http://example.org/endpoint'
}
url: 'http://example.org/endpoint',
},
};
sendTaskWebhook(webhooks, data);
@@ -52,8 +51,8 @@ describe('webhooks', () => {
sort: 0,
id: 'some-id',
enabled: true,
url: 'http://malformedurl/endpoint'
}
url: 'http://malformedurl/endpoint',
},
};
sendTaskWebhook(webhooks, data);
@@ -67,8 +66,8 @@ describe('webhooks', () => {
sort: 0,
id: 'some-id',
enabled: true,
url: 'http://example.org/endpoint'
}
url: 'http://example.org/endpoint',
},
};
sendTaskWebhook(webhooks, data);
@@ -81,10 +80,10 @@ describe('webhooks', () => {
task: { _id: 'task-id' },
delta: 1.4,
user: {
_id: 'user-id'
}
_id: 'user-id',
},
},
json: true
json: true,
});
});
@@ -94,14 +93,14 @@ describe('webhooks', () => {
sort: 0,
id: 'some-id',
enabled: true,
url: 'http://example.org/endpoint'
url: 'http://example.org/endpoint',
},
'second-webhook': {
sort: 1,
id: 'second-webhook',
enabled: true,
url: 'http://example.com/2/endpoint'
}
url: 'http://example.com/2/endpoint',
},
};
sendTaskWebhook(webhooks, data);
@@ -114,10 +113,10 @@ describe('webhooks', () => {
task: { _id: 'task-id' },
delta: 1.4,
user: {
_id: 'user-id'
}
_id: 'user-id',
},
},
json: true
json: true,
});
expect(request.post).to.be.calledWith({
url: 'http://example.com/2/endpoint',
@@ -126,10 +125,10 @@ describe('webhooks', () => {
task: { _id: 'task-id' },
delta: 1.4,
user: {
_id: 'user-id'
}
_id: 'user-id',
},
},
json: true
json: true,
});
});
});
test/api/v3/unit/middlewares/analytics.test.js
+3 -2
View File
@@ -1,3 +1,4 @@
/* eslint-disable global-require */
import {
generateRes,
generateReq,
@@ -6,7 +7,7 @@ import {
import analyticsService from '../../../../../website/src/libs/api-v3/analyticsService';
import nconf from 'nconf';
describe('analytics middleware', function () {
describe('analytics middleware', () => {
let res, req, next;
let pathToAnalyticsMiddleware = '../../../../../website/src/middlewares/api-v3/analytics';
@@ -23,7 +24,7 @@ describe('analytics middleware', function () {
delete require.cache[require.resolve(pathToAnalyticsMiddleware)];
});
it('attaches analytics object res.locals', function () {
it('attaches analytics object res.locals', () => {
let attachAnalytics = require(pathToAnalyticsMiddleware);
attachAnalytics(req, res, next);
test/api/v3/unit/middlewares/errorHandler.test.js
+3 -3
View File
@@ -115,7 +115,7 @@ describe('errorHandler', () => {
error: 'BadRequest',
message: 'Invalid request parameters.',
errors: [
{param: error[0].param, value: error[0].value, message: error[0].msg}
{ param: error[0].param, value: error[0].value, message: error[0].msg },
],
});
});
@@ -142,8 +142,8 @@ describe('errorHandler', () => {
error: 'BadRequest',
message: 'User validation failed.',
errors: [
{path: 'auth.local.email', message: 'Invalid email.', value: 'not an email'}
]
{ path: 'auth.local.email', message: 'Invalid email.', value: 'not an email' },
],
});
});
test/api/v3/unit/middlewares/getUserLanguage.test.js
+27 -29
View File
@@ -7,15 +7,13 @@ import getUserLanguage from '../../../../../website/src/middlewares/api-v3/getUs
import { i18n } from '../../../../../common';
import Q from 'q';
import { model as User } from '../../../../../website/src/models/user';
import { translations } from '../../../../../website/src/libs/api-v3/i18n';
import accepts from 'accepts';
describe('getUserLanguage', () => {
let res, req, next;
let checkResT = (req) => {
expect(res.t).to.be.a('function');
expect(res.t('help')).to.equal(i18n.t('help', req.language));
let checkResT = (resToCheck) => {
expect(resToCheck.t).to.be.a('function');
expect(resToCheck.t('help')).to.equal(i18n.t('help', req.language));
};
beforeEach(() => {
@@ -32,7 +30,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, next);
expect(req.language).to.equal('es');
checkResT(req);
checkResT(res);
});
it('falls back to english if the query parameter language does not exists', () => {
@@ -42,7 +40,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, next);
expect(req.language).to.equal('en');
checkResT(req);
checkResT(res);
});
it('uses query even if the request includes a user and session', () => {
@@ -59,12 +57,12 @@ describe('getUserLanguage', () => {
};
req.session = {
userId: 123
userId: 123,
};
getUserLanguage(req, res, next);
expect(req.language).to.equal('es');
checkResT(req);
checkResT(res);
});
});
@@ -80,7 +78,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, next);
expect(req.language).to.equal('it');
checkResT(req);
checkResT(res);
});
it('falls back to english if the user preferred language is not avalaible', (done) => {
@@ -94,7 +92,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('en');
checkResT(req);
checkResT(res);
done();
});
});
@@ -109,12 +107,12 @@ describe('getUserLanguage', () => {
};
req.session = {
userId: 123
userId: 123,
};
getUserLanguage(req, res, next);
expect(req.language).to.equal('it');
checkResT(req);
checkResT(res);
});
});
@@ -125,18 +123,18 @@ describe('getUserLanguage', () => {
return Q.resolve({
preferences: {
language: 'it',
}
},
});
}
},
});
req.session = {
userId: 123
userId: 123,
};
getUserLanguage(req, res, () => {
expect(req.language).to.equal('it');
checkResT(req);
checkResT(res);
done();
});
});
@@ -148,7 +146,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('pt');
checkResT(req);
checkResT(res);
done();
});
});
@@ -158,7 +156,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('he');
checkResT(req);
checkResT(res);
done();
});
});
@@ -168,7 +166,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('he');
checkResT(req);
checkResT(res);
done();
});
});
@@ -178,7 +176,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('fr');
checkResT(req);
checkResT(res);
done();
});
});
@@ -188,7 +186,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('fr');
checkResT(req);
checkResT(res);
done();
});
});
@@ -198,7 +196,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('es');
checkResT(req);
checkResT(res);
done();
});
});
@@ -208,7 +206,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('es_419');
checkResT(req);
checkResT(res);
done();
});
});
@@ -218,7 +216,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('es_419');
checkResT(req);
checkResT(res);
done();
});
});
@@ -228,7 +226,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('zh_TW');
checkResT(req);
checkResT(res);
done();
});
});
@@ -238,7 +236,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('en');
checkResT(req);
checkResT(res);
done();
});
});
@@ -248,7 +246,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('en');
checkResT(req);
checkResT(res);
done();
});
});
@@ -258,7 +256,7 @@ describe('getUserLanguage', () => {
getUserLanguage(req, res, () => {
expect(req.language).to.equal('en');
checkResT(req);
checkResT(res);
done();
});
});
test/api/v3/unit/middlewares/response.js
+4 -4
View File
@@ -5,7 +5,7 @@ import {
} from '../../../../helpers/api-unit.helper';
import responseMiddleware from '../../../../../website/src/middlewares/api-v3/response';
describe('response middleware', function () {
describe('response middleware', () => {
let res, req, next;
beforeEach(() => {
@@ -15,13 +15,13 @@ describe('response middleware', function () {
});
it('attaches respond method to res', function () {
it('attaches respond method to res', () => {
responseMiddleware(req, res, next);
expect(res.respond).to.exist;
});
it('can be used to respond to requests', function () {
it('can be used to respond to requests', () => {
responseMiddleware(req, res, next);
res.respond(200, {field: 1});
@@ -34,7 +34,7 @@ describe('response middleware', function () {
});
});
it('treats status >= 400 as failures', function () {
it('treats status >= 400 as failures', () => {
responseMiddleware(req, res, next);
res.respond(403, {field: 1});