From 9c973cca2a92918a36d2a7578bae64169a6167a9 Mon Sep 17 00:00:00 2001
From: negue <eugen.bolz@gmail.com>
Date: Mon, 8 May 2023 21:15:46 +0200
Subject: [PATCH] fix selectDifficulty.vue - refactor selectList.vue

---
 .../tasks/modal-controls/selectDifficulty.vue |  3 +-
 .../client/src/components/ui/selectList.vue   | 64 ++++++++++---------
 2 files changed, 36 insertions(+), 31 deletions(-)

diff --git a/website/client/src/components/tasks/modal-controls/selectDifficulty.vue b/website/client/src/components/tasks/modal-controls/selectDifficulty.vue
index 1dfc16c3c4..019ccdc544 100644
--- a/website/client/src/components/tasks/modal-controls/selectDifficulty.vue
+++ b/website/client/src/components/tasks/modal-controls/selectDifficulty.vue
@@ -2,7 +2,6 @@
   <div>
     <select-list
       :items="items"
-      :key-prop="'icon'"
       class="difficulty-select"
       :class="{disabled: disabled}"
       :disabled="disabled"
@@ -10,7 +9,7 @@
       :hide-icon="true"
       @select="$emit('select', $event.value)"
     >
-      <template v-slot:item="{ item, button }">
+      <template #item="{ item, button }">
         <div
           v-if="item"
           class="difficulty-item"
diff --git a/website/client/src/components/ui/selectList.vue b/website/client/src/components/ui/selectList.vue
index e6dd5e342c..c661f72a44 100644
--- a/website/client/src/components/ui/selectList.vue
+++ b/website/client/src/components/ui/selectList.vue
@@ -21,8 +21,8 @@
       </template>
       <b-dropdown-item
         v-for="item in items"
-        :key="keyProp ? item[keyProp] : item"
-        :disabled="typeof item[disabledProp] === 'undefined' ? false : item[disabledProp]"
+        :key="getKeyProp(item)"
+        :disabled="isDisabled(item)"
         :active="isSelected(item)"
         :class="{
           active: isSelected(item),
@@ -51,39 +51,39 @@
 </template>
 
 <style lang="scss" scoped>
-  @import '~@/assets/scss/colors.scss';
+@import '~@/assets/scss/colors.scss';
 
-  .select-list ::v-deep {
-    .dropdown-toggle {
-      white-space: nowrap;
-      overflow: hidden;
-      text-overflow: ellipsis;
-      padding-right: 25px; /* To allow enough room for the down arrow to be displayed */
+.select-list ::v-deep {
+  .dropdown-toggle {
+    white-space: nowrap;
+    overflow: hidden;
+    text-overflow: ellipsis;
+    padding-right: 25px; /* To allow enough room for the down arrow to be displayed */
+  }
+
+  .selectListItem {
+    position: relative;
+
+    .dropdown-item {
+      display: flex;
+      align-items: center;
+      justify-content: space-between;
     }
 
-    .selectListItem {
-      position: relative;
-
-      .dropdown-item {
-        display: flex;
-        align-items: center;
-        justify-content: space-between;
+    &:not(.showIcon) {
+      .svg-icon.check-icon {
+        display: none;
       }
+    }
 
-      &:not(.showIcon) {
-        .svg-icon.check-icon {
-          display: none;
-        }
-      }
-
-      .svg-icon.check-icon.color {
-        margin-left: 10px; /* So the flex item (checkmark) will have some spacing from the text */
-        width: 0.77rem;
-        height: 0.615rem;
-        color: $purple-300;
-      }
+    .svg-icon.check-icon.color {
+      margin-left: 10px; /* So the flex item (checkmark) will have some spacing from the text */
+      width: 0.77rem;
+      height: 0.615rem;
+      color: $purple-300;
     }
   }
+}
 </style>
 
 <script>
@@ -131,8 +131,14 @@ export default {
     };
   },
   methods: {
+    getKeyProp (item) {
+      return this.keyProp ? item[this.keyProp] : item;
+    },
+    isDisabled (item) {
+      return typeof item[this.disabledProp] === 'undefined' ? false : item[this.disabledProp];
+    },
     selectItem (item) {
-      this.selected = this.keyProp ? item[this.keyProp] : item;
+      this.selected = this.getKeyProp(item);
       this.$emit('select', item);
     },
     isSelected (item) {