From a1e1ac211fa1ab697c65dc6cc02797cdcd3287df Mon Sep 17 00:00:00 2001
From: Phillip Thelen <viirus@pherth.net>
Date: Fri, 4 Mar 2016 14:00:26 +0100
Subject: [PATCH] improve improvement category validation

---
 website/src/models/user.js | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/website/src/models/user.js b/website/src/models/user.js
index d950bc27fc..d23d401f0d 100644
--- a/website/src/models/user.js
+++ b/website/src/models/user.js
@@ -391,14 +391,12 @@ var UserSchema = new Schema({
       raisePet: {type: Boolean, 'default': false},
       streak: {type: Boolean, 'default': false}
     },
-    improvementCategories: {type: Array, validate: function (categories) {
-      var validValues = true;
-      categories.forEach(function (cat) {
-        if (['work', 'exercise', 'healthWellness', 'school', 'teams', 'chores', 'creativity'].indexOf(cat) === -1){
-          validValues = false;
-        }
-      });
-      return validValues;
+    improvementCategories: {
+      type: Array,
+      validate: (categories) => {
+        const validCategories = ['work', 'exercise', 'healthWellness', 'school', 'teams', 'chores', 'creativity'];
+        let isValidCategory = categories.every(category => validValues.indexOf(category) !== -1);
+        return isValidCategory;
     }}
   },
   profile: {