From ab0c5106a11786df6ec1a85dd41d29af2a622605 Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Wed, 25 Mar 2015 17:52:15 +0100
Subject: [PATCH] move quest-started email to batch mode

---
 website/src/controllers/groups.js | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/website/src/controllers/groups.js b/website/src/controllers/groups.js
index 8eda273a34..be1dea5d22 100644
--- a/website/src/controllers/groups.js
+++ b/website/src/controllers/groups.js
@@ -810,19 +810,22 @@ questStart = function(req, res, next) {
 
     groupClone.members = results[lastIndex].members;
 
-    // Send quest started email and remove auth information
+    // Send quest started email
+    var usersToEmail = groupClone.members.filter(function(user){
+      return (
+        user.preferences.emailNotifications.questStarted !== false &&
+        user._id !== res.locals.user._id &&
+        group.quest.members[user._id] == true
+      )
+    });
+
+    utils.txnEmail(usersToEmail, 'quest-started', [
+      {name: 'PARTY_URL', content: nconf.get('BASE_URL') + '/#/options/groups/party'}
+    ]);
+
     _.each(groupClone.members, function(user){
-
-      if(user.preferences.emailNotifications.questStarted !== false &&
-         user._id !== res.locals.user._id &&
-         group.quest.members[user._id] == true
-         ){
-        utils.txnEmail(user, 'quest-started', [
-          {name: 'PARTY_URL', content: nconf.get('BASE_URL') + '/#/options/groups/party'}
-        ]);
-      }
-
       // Remove sensitive data from what is sent to the public
+      // but after having sent emails as they are needed
       user.auth.facebook = undefined;
       user.auth.local = undefined;
     });