v3 adapt v2: port tags, cast, cron, deletUser and removeMember. Fix a few bugs in v3

website/src/controllers/api-v3/tags.js

@@ -1,6 +1,7 @@
 import { authWithHeaders } from '../../middlewares/api-v3/auth';
 import cron from '../../middlewares/api-v3/cron';
 import { model as Tag } from '../../models/tag';
+import { model as Tasks } from '../../models/task';
 import {
   NotFound,
 } from '../../libs/api-v3/errors';
@@ -96,7 +97,6 @@ api.updateTag = {
     let user = res.locals.user;
 
     req.checkParams('tagId', res.t('tagIdRequired')).notEmpty().isUUID();
-    // TODO check that req.body isn't empty
 
     let tagId = req.params.tagId;
 
@@ -139,6 +139,15 @@ api.deleteTag = {
     if (!tag) throw new NotFound(res.t('tagNotFound'));
     tag.remove();
 
+    // Remove from all the tasks TODO test
+    await Tasks.Task.update({
+      userId: user._id,
+    }, {
+      $pull: {
+        tags: tag._id,
+      },
+    }, {multi: true}).exec();
+
     await user.save();
     res.respond(200, {});
   },

website/src/controllers/api-v3/user.js

@@ -373,7 +373,7 @@ api.castSpell = {
       let response = {
         tasks: isUserModified ? _.rest(saved) : saved,
       };
-      if (isUserModified) res.user = user;
+      if (isUserModified) response.user = user;
       res.respond(200, response);
     } else if (targetType === 'party' || targetType === 'user') {
       let party = await Group.getGroup({groupId: 'party', user});