From c18fbb79ed77bd4f4c185bd03bbf1121b6315250 Mon Sep 17 00:00:00 2001 From: NotGonnaGitUs Date: Mon, 4 May 2015 03:43:30 +0530 Subject: [PATCH] Separated the deletion of the challenge to its own function in the async.waterfall --- website/src/controllers/challenges.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/website/src/controllers/challenges.js b/website/src/controllers/challenges.js index 1d0d7e2273..792495e237 100644 --- a/website/src/controllers/challenges.js +++ b/website/src/controllers/challenges.js @@ -309,12 +309,16 @@ api['delete'] = function(req, res, next){ chal = _chal; if (!chal) return cb('Challenge ' + cid + ' not found'); if (chal.leader != user._id) return cb("You don't have permissions to edit this challenge"); - User.findById(user._id, cb) //Refunds to challenge leader + //Refunds to challenge leader + User.findById(user._id, cb) }, function(leader, cb){ leader.balance += chal.prize/4; leader.save(cb); - closeChal(req.params.cid, {broken: 'CHALLENGE_DELETED'}, cb); //Not descriptive enough + }, + function(save, num, cb){ + //Add prizeRefundedTo: save.profile.name? + closeChal(req.params.cid, {broken: 'CHALLENGE_DELETED'}, cb); } ], function(err){ if (err) return next(err);