fix tasks updating and reminders tests

website/src/controllers/api-v3/tasks.js

@@ -304,24 +304,7 @@ api.updateTask = {
       throw new NotFound(res.t('taskNotFound'));
     }
 
-    // If reminders are updated -> replace the original ones
-    if (req.body.reminders) {
-      task.reminders = req.body.reminders;
-      delete req.body.reminders;
-    }
-
-    // If checklist is updated -> replace the original one
-    if (req.body.checklist) {
-      task.checklist = req.body.checklist;
-      delete req.body.checklist;
-    }
-
-    // If tags are updated -> replace the original ones
-    if (req.body.tags) {
-      task.tags = req.body.tags;
-      delete req.body.tags;
-    }
-
+    Tasks.Task.sanitize(req.body);
     // TODO we have to convert task to an object because otherwise things don't get merged correctly. Bad for performances?
     // TODO regarding comment above, make sure other models with nested fields are using this trick too
     _.assign(task, common.ops.updateTask(task.toObject(), req));

website/src/models/task.js

@@ -60,12 +60,6 @@ TaskSchema.statics.sanitizeCreate = function sanitizeCreate (createObj) {
   return this.sanitize(createObj, noCreate);
 };
 
-// A list of additional fields that cannot be updated (but can be set on creation)
-let noUpdate = ['_id', 'type'];
-TaskSchema.statics.sanitizeUpdate = function sanitizeUpdate (updateObj) {
-  return this.sanitize(updateObj, noUpdate);
-};
-
 // Sanitize checklist objects (disallowing _id)
 TaskSchema.statics.sanitizeChecklist = function sanitizeChecklist (checklistObj) {
   delete checklistObj._id;