From c77dd5f200d51d5e9059c74f1f8da53ff2bd9a66 Mon Sep 17 00:00:00 2001
From: SabreCat <sabe@habitica.com>
Date: Tue, 2 May 2023 16:52:50 -0500
Subject: [PATCH] fix(analytics): move lfp events out of mounted

---
 .../client/src/components/groups/createPartyModal.vue  |  6 ------
 .../client/src/components/groups/lookingForParty.vue   |  8 --------
 website/client/src/components/header/index.vue         |  7 +++++++
 website/client/src/router/index.js                     | 10 ++++++++++
 4 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/website/client/src/components/groups/createPartyModal.vue b/website/client/src/components/groups/createPartyModal.vue
index 17c0184331..c1021b47e7 100644
--- a/website/client/src/components/groups/createPartyModal.vue
+++ b/website/client/src/components/groups/createPartyModal.vue
@@ -264,12 +264,6 @@ export default {
   },
   mounted () {
     this.seeking = Boolean(this.user.party.seeking);
-    Analytics.track({
-      eventName: 'Start a Party button',
-      eventAction: 'Start a Party button',
-      eventCategory: 'behavior',
-      hitType: 'event',
-    }, { trackOnClient: true });
   },
   methods: {
     async createParty () {
diff --git a/website/client/src/components/groups/lookingForParty.vue b/website/client/src/components/groups/lookingForParty.vue
index eda06f5759..fd22c7656a 100644
--- a/website/client/src/components/groups/lookingForParty.vue
+++ b/website/client/src/components/groups/lookingForParty.vue
@@ -243,8 +243,6 @@ import rogueIcon from '@/assets/svg/rogue.svg';
 import healerIcon from '@/assets/svg/healer.svg';
 import wizardIcon from '@/assets/svg/wizard.svg';
 
-import * as Analytics from '@/libs/analytics';
-
 export default {
   components: {
     Avatar,
@@ -287,12 +285,6 @@ export default {
         section: this.$t('lookingForPartyTitle'),
       });
       this.seekers = await this.$store.dispatch('party:lookingForParty');
-      await Analytics.track({
-        hitType: 'event',
-        eventName: 'View Find Members',
-        eventAction: 'View Find Members',
-        eventCategory: 'behavior',
-      }, { trackOnClient: true });
       this.canLoadMore = this.seekers.length === 30;
       this.loading = false;
     }
diff --git a/website/client/src/components/header/index.vue b/website/client/src/components/header/index.vue
index ebf2362e32..69da953390 100644
--- a/website/client/src/components/header/index.vue
+++ b/website/client/src/components/header/index.vue
@@ -122,6 +122,7 @@
 
 <script>
 import orderBy from 'lodash/orderBy';
+import * as Analytics from '@/libs/analytics';
 import { mapGetters, mapActions } from '@/libs/store';
 import MemberDetails from '../memberDetails';
 import createPartyModal from '../groups/createPartyModal';
@@ -237,6 +238,12 @@ export default {
         this.$router.push('/looking-for-party');
       } else {
         this.$root.$emit('bv::show::modal', 'create-party-modal');
+        Analytics.track({
+          eventName: 'Start a Party button',
+          eventAction: 'Start a Party button',
+          eventCategory: 'behavior',
+          hitType: 'event',
+        }, { trackOnClient: true });
       }
     },
     loadMembers (payload = null) {
diff --git a/website/client/src/router/index.js b/website/client/src/router/index.js
index 4a478e1047..57828f998d 100644
--- a/website/client/src/router/index.js
+++ b/website/client/src/router/index.js
@@ -1,5 +1,6 @@
 import Vue from 'vue';
 import VueRouter from 'vue-router';
+import * as Analytics from '@/libs/analytics';
 import getStore from '@/store';
 import handleRedirect from './handleRedirect';
 
@@ -439,6 +440,15 @@ router.beforeEach(async (to, from, next) => {
     router.app.$root.$emit('update-party');
   }
 
+  if (to.name === 'lookingForParty') {
+    Analytics.track({
+      hitType: 'event',
+      eventName: 'View Find Members',
+      eventAction: 'View Find Members',
+      eventCategory: 'behavior',
+    }, { trackOnClient: true });
+  }
+
   // Redirect old guild urls
   if (to.hash.indexOf('#/options/groups/guilds/') !== -1) {
     const splits = to.hash.split('/');