update quest abort route

test/api/v3/integration/quests/POST-groups_groupid_quests_abort.test.js

@@ -1,78 +1,126 @@
 import {
   createAndPopulateGroup,
   translate as t,
+  generateUser,
 } from '../../../../helpers/api-v3-integration.helper';
 import { v4 as generateUUID } from 'uuid';
 
-describe('POST /groups/:groupId/quests/abort', () => {
-  let questingGroup, member, leader;
-  const PET_QUEST = 'whale';
-  let userQuestUpdate = {
-    items: {
-      quests: {},
-    },
-    'party.quest.RSVPNeeded': true,
-    'party.quest.key': PET_QUEST,
-  };
+describe('POST /groups/:groupId/quests/leave', () => {
+  let questingGroup;
+  let partyMembers;
+  let user;
+  let leader;
 
-  before(async () => {
+  const PET_QUEST = 'whale';
+
+  beforeEach(async () => {
     let { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
-      members: 1,
+      members: 2,
     });
 
-    leader = groupLeader;
     questingGroup = group;
-    member = members[0];
+    leader = groupLeader;
+    partyMembers = members;
 
-    userQuestUpdate.items.quests[PET_QUEST] = 1;
+    await leader.update({
+      [`items.quests.${PET_QUEST}`]: 1,
+    });
+    user = await generateUser();
   });
 
-  it('returns an error when group is not found', async () => {
-    await expect(leader.post(`/groups/${generateUUID()}/quests/abort`))
+  context('failure conditions', () => {
+    it('returns an error when group is not found', async () => {
+      await expect(partyMembers[0].post(`/groups/${generateUUID()}/quests/abort`))
+        .to.eventually.be.rejected.and.eql({
+          code: 404,
+          error: 'NotFound',
+          message: t('groupNotFound'),
+        });
+    });
+
+    it('returns an error for a group in which user is not a member', async () => {
+      await expect(user.post(`/groups/${questingGroup._id}/quests/abort`))
       .to.eventually.be.rejected.and.eql({
         code: 404,
         error: 'NotFound',
         message: t('groupNotFound'),
       });
-  });
+    });
 
-  it('returns an error when quest is  not active', async () => {
-    await expect(leader.post(`/groups/${questingGroup._id}/quests/abort`))
-      .to.eventually.be.rejected.and.eql({
-        code: 404,
-        error: 'NotFound',
-        message: t('noActiveQuestToAbort'),
+    it('returns an error when group is a guild', async () => {
+      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+        groupDetails: { type: 'guild', privacy: 'private' },
       });
-  });
 
-  xit('returns an error when non quest leader attempts to abort', async () => {
-    await questingGroup.update({quest: {key: PET_QUEST, active: true, leader: leader._id}});
-
-    await expect(member.post(`/groups/${questingGroup._id}/quests/abort`))
+      await expect(guildLeader.post(`/groups/${guild._id}/quests/abort`))
       .to.eventually.be.rejected.and.eql({
         code: 401,
         error: 'NotAuthorized',
-        message: t('questLeaderCannotAbortQuest'),
+        message: t('guildQuestsNotSupported'),
       });
+    });
+
+    it('returns an error when quest is not active', async () => {
+      await expect(partyMembers[0].post(`/groups/${questingGroup._id}/quests/abort`))
+        .to.eventually.be.rejected.and.eql({
+          code: 404,
+          error: 'NotFound',
+          message: t('noActiveQuestToAbort'),
+        });
+    });
+
+    it('returns an error when non quest leader attempts to abort', async () => {
+      await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
+      await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
+      await partyMembers[1].post(`/groups/${questingGroup._id}/quests/accept`);
+
+      await expect(partyMembers[0].post(`/groups/${questingGroup._id}/quests/abort`))
+        .to.eventually.be.rejected.and.eql({
+          code: 401,
+          error: 'NotAuthorized',
+          message: t('onlyLeaderAbortQuest'),
+        });
+    });
   });
 
   it('aborts a quest', async () => {
-    await member.update(userQuestUpdate);
+    await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
+    await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
+    await partyMembers[1].post(`/groups/${questingGroup._id}/quests/accept`);
 
-    let questMembers = {};
-    questMembers[member._id] = true;
-    await questingGroup.update({'quest.members': questMembers});
-    await questingGroup.update({quest: {key: PET_QUEST, active: true, leader: leader._id}});
+    let res = await leader.post(`/groups/${questingGroup._id}/quests/abort`);
+    Promise.all([
+      leader.sync(),
+      questingGroup.sync(),
+      partyMembers[0].sync(),
+      partyMembers[1].sync(),
+    ]);
 
-    let abortResult = await leader.post(`/groups/${questingGroup._id}/quests/abort`);
-    let updatedMember = await member.get('/user');
-    let updatedLeader = await leader.get('/user');
-    let updatedGroup = await member.get(`/groups/${questingGroup._id}`);
+    let cleanUserQuestObj = {
+      key: null,
+      progress: {
+        up: 0,
+        down: 0,
+        collect: {},
+      },
+      completed: null,
+      RSVPNeeded: false,
+    };
 
-    expect(updatedMember.party.quest.key).to.be.null;
-    expect(updatedMember.party.quest.RSVPNeeded).to.be.false;
-    expect(updatedLeader.items.quests[PET_QUEST]).to.equal(1);
-    expect(updatedGroup.quest).to.deep.equal(abortResult);
+    expect(leader.party.quest).to.eql(cleanUserQuestObj);
+    expect(partyMembers[0].party.quest).to.eql(cleanUserQuestObj);
+    expect(partyMembers[1].party.quest).to.eql(cleanUserQuestObj);
+    expect(leader.items.quests[PET_QUEST]).to.equal(1);
+    expect(questingGroup.quest).to.deep.equal(abortResult);
+    expect(questingGroup.quest).to.eql({
+      key: null,
+      active: false,
+      leader: null,
+      progress: {
+       collect: {},
+      },
+      members: {},
+   });
   });
 });