various fixes: group leader's name at top of edit drop-down; Members List; etc (#9117)

* fix text describing location of subscription/gem gift box

* disable Copy As To-Do in Tavern, guilds, party because it's not working

* change members label on group pages to Member List

* remove outdated info about seeing number of Gems available to buy

* allow Danger Zone to be seen by players without local authentication

Also add an hr because the Danger Zone heading was crammed up against the button above it.

* put current group leader's name at top of Leader change drop-down

website/client/components/groups/groupFormModal.vue

@@ -9,7 +9,7 @@
         label
           strong(v-once) {{$t('guildOrPartyLeader')}} *
         select.form-control(v-model="workingGroup.newLeader")
-          option(v-for='member in members', :value="member._id") {{ member.profile.name }}
+          option(v-for='potentialLeader in potentialLeaders', :value="potentialLeader._id") {{ potentialLeader.name }}
 
       .form-group(v-if='!this.workingGroup.id')
         label
@@ -316,6 +316,17 @@ export default {
     isParty () {
       return this.workingGroup.type === 'party';
     },
+    potentialLeaders () {
+      let leaders = [{ _id: this.user._id, name: this.user.profile.name }];
+      // @TODO consider pushing all recent posters to the top of the list if they are guild members - more likely to be the ones the leader wants to see (and then ignore them in the while below)
+      let i = 0;
+      while (this.members[i]) {
+        let memb = this.members[i];
+        i++;
+        if (memb._id !== this.user._id) leaders.push({_id: memb._id, name: memb.profile.name});
+      }
+      return leaders;
+    },
   },
   watch: {
     editingGroup () {