From cb9083d9ba03854eabe4ff628f61ded809f7059d Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Sat, 6 Dec 2014 10:25:07 -0700 Subject: [PATCH] fix(webhooks): don't send webhooks if not valid url (also if not enabled), fixes #4357 --- src/controllers/user.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/controllers/user.js b/src/controllers/user.js index a1c71908a0..bceb3eb677 100644 --- a/src/controllers/user.js +++ b/src/controllers/user.js @@ -17,6 +17,7 @@ var acceptablePUTPaths; var api = module.exports; var qs = require('qs'); var request = require('request'); +var validator = require('validator'); // api.purchase // Shared.ops @@ -111,6 +112,7 @@ api.score = function(req, res, next) { // Webhooks _.each(user.preferences.webhooks, function(h){ + if (!h.enabled || !validator.isURL(h.url)) return; request.post({ url: h.url, //form: {task: task, delta: delta, user: _.pick(user, ['stats', '_tmp'])} // this is causing "Maximum Call Stack Exceeded"