From cc73b44b25d1f3dd6507754d2a68652e111d8703 Mon Sep 17 00:00:00 2001
From: negue <eugen.bolz@gmail.com>
Date: Wed, 29 Mar 2023 23:40:30 +0200
Subject: [PATCH] remove advancedCollapsed settings to start it opened

---
 test/common/ops/addTask.js                       |  8 --------
 .../client/src/components/tasks/taskModal.vue    |  1 -
 .../pages/settings/settingRows/taskSettings.vue  | 16 ----------------
 website/common/locales/en/settings.json          |  2 --
 website/common/script/ops/addTask.js             |  1 -
 5 files changed, 28 deletions(-)

diff --git a/test/common/ops/addTask.js b/test/common/ops/addTask.js
index 6f02f47fdc..e32c3525a6 100644
--- a/test/common/ops/addTask.js
+++ b/test/common/ops/addTask.js
@@ -126,13 +126,5 @@ describe('shared.ops.addTask', () => {
       expect(addTask(user)._editing).not.be.ok;
       expect(addTask(user)._edit).to.not.be.ok;
     });
-
-    it('respects advancedCollapsed preference', () => {
-      user.preferences.advancedCollapsed = true;
-      expect(addTask(user)._advanced).not.be.ok;
-
-      user.preferences.advancedCollapsed = false;
-      expect(addTask(user)._advanced).to.be.ok;
-    });
   });
 });
diff --git a/website/client/src/components/tasks/taskModal.vue b/website/client/src/components/tasks/taskModal.vue
index 95c7d333c3..e5a9b3cee0 100644
--- a/website/client/src/components/tasks/taskModal.vue
+++ b/website/client/src/components/tasks/taskModal.vue
@@ -1183,7 +1183,6 @@ export default {
     },
   },
   async mounted () {
-    this.showAdvancedOptions = !this.user.preferences.advancedCollapsed;
     if (this.groupId) {
       const groupResponse = await axios.get(`/api/v4/groups/${this.groupId}`);
       this.managers = Object.keys(groupResponse.data.data.managers);
diff --git a/website/client/src/pages/settings/settingRows/taskSettings.vue b/website/client/src/pages/settings/settingRows/taskSettings.vue
index ea5d825481..24766f812a 100644
--- a/website/client/src/pages/settings/settingRows/taskSettings.vue
+++ b/website/client/src/pages/settings/settingRows/taskSettings.vue
@@ -1,21 +1,5 @@
 <template>
   <fragment>
-    <tr>
-      <td class="settings-label">
-        <span
-          v-b-popover.hover.right="$t('startAdvCollapsedPop')"
-          class="hint"
-        >{{ $t('startAdvCollapsed') }}</span>
-      </td>
-      <td class="settings-value">
-      </td>
-      <td class="settings-button">
-        <toggle-switch
-          v-model="user.preferences.advancedCollapsed"
-          @change="setUserPreference('advancedCollapsed')"
-        />
-      </td>
-    </tr>
     <tr>
       <td class="settings-label">
         <span
diff --git a/website/common/locales/en/settings.json b/website/common/locales/en/settings.json
index cc730ac113..bdfbaecc82 100644
--- a/website/common/locales/en/settings.json
+++ b/website/common/locales/en/settings.json
@@ -16,8 +16,6 @@
     "dailyDueDefaultView": "Set Dailies default to 'due' tab",
     "dailyDueDefaultViewPop": "With this option set, the Dailies tasks will default to 'due' instead of 'all'",
     "reverseChatOrder": "Show chat messages in reverse order",
-    "startAdvCollapsed": "Advanced Settings in tasks start collapsed",
-    "startAdvCollapsedPop": "With this option set, Advanced Settings will be hidden when you first open a task for editing.",
     "dontShowAgain": "Don't show this again",
     "showLevelUpModal": "When Gaining a Level",
     "showHatchPetModal": "When Hatching a Pet",
diff --git a/website/common/script/ops/addTask.js b/website/common/script/ops/addTask.js
index e89485bb3c..1907c59034 100644
--- a/website/common/script/ops/addTask.js
+++ b/website/common/script/ops/addTask.js
@@ -12,7 +12,6 @@ export default function addTask (user, req = { body: {} }) {
   if (task._editing) {
     task._edit = clone(task);
   }
-  task._advanced = !user.preferences.advancedCollapsed;
 
   return task;
 }