From db62d1add0b3f038acd822b0af0ebbf629f9ca35 Mon Sep 17 00:00:00 2001 From: Blade Barringer Date: Sat, 9 Apr 2016 08:03:32 -0500 Subject: [PATCH] fix: correct coupon generation code --- test/api-legacy/coupons.js | 15 +++++++++------ website/src/controllers/api-v2/coupon.js | 3 ++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/test/api-legacy/coupons.js b/test/api-legacy/coupons.js index 1f4fcda3b6..31d840de61 100644 --- a/test/api-legacy/coupons.js +++ b/test/api-legacy/coupons.js @@ -40,26 +40,29 @@ describe("Coupons", function() { describe("POST /api/v2/coupons/generate/:event", function() { context("while sudo user", function() { before(function(done) { - return makeSudoUser(user, done); + makeSudoUser(user, done); }); - return it("generates coupons", function(done) { + + it("generates coupons", function(done) { var queries; queries = '?count=10'; - return request.post(baseURL + '/coupons/generate/wondercon' + queries).end(function(err, res) { + + request.post(baseURL + '/coupons/generate/wondercon' + queries).end(function(err, res) { expectCode(res, 200); - return Coupon.find({ + Coupon.find({ event: 'wondercon' }, function(err, _coupons) { coupons = _coupons; expect(coupons.length).to.equal(10); _(coupons).each(function(c) { - return expect(c.event).to.equal('wondercon'); + expect(c.event).to.equal('wondercon'); }).value(); - return done(); + done(); }); }); }); }); + return context("while regular user", function() { before(function(done) { return registerNewUser(done, true); diff --git a/website/src/controllers/api-v2/coupon.js b/website/src/controllers/api-v2/coupon.js index 8ab576cb6e..a69c41e326 100644 --- a/website/src/controllers/api-v2/coupon.js +++ b/website/src/controllers/api-v2/coupon.js @@ -10,7 +10,8 @@ api.ensureAdmin = function(req, res, next) { } api.generateCoupons = function(req,res,next) { - Coupon.generate(req.params.event, req.query.count, function(err){ + let count = Number(req.query.count); + Coupon.generate(req.params.event, count, function(err){ if(err) return next(err); res.sendStatus(200); });