From e01ff99610c5cdf059e63e8d3e3bef578ac197dd Mon Sep 17 00:00:00 2001
From: Phillip Thelen <viirus@pherth.net>
Date: Sun, 8 Jun 2014 16:08:14 +0200
Subject: [PATCH] Only refund quest scroll to leader if quest was active

otherwise quest leader gets more quest scrolls than they had to begin with.
---
 src/controllers/groups.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/controllers/groups.js b/src/controllers/groups.js
index 036c9b13c9..e232b433fa 100644
--- a/src/controllers/groups.js
+++ b/src/controllers/groups.js
@@ -607,11 +607,11 @@ api.questAbort = function(req, res, next){
     },
     // Refund party leader quest scroll
     function(cb){
-      var update = {$inc:{}};
-      update['$inc']['items.quests.' + group.quest.key] = 1;
-      User.update({_id:group.quest.leader}, update, cb);
-    },
-    function(cb) {
+      if (group.quest.active) {
+        var update = {$inc:{}};
+        update['$inc']['items.quests.' + group.quest.key] = 1;
+        User.update({_id:group.quest.leader}, update, cb);
+      }
       group.quest = {key:null,progress:{},leader:null};
       group.markModified('quest');
       group.save(cb);