lint common

2019-10-09 20:08:36 +02:00
parent 0c27fb24a5
commit e0e9811ab6
330 changed files with 6885 additions and 7668 deletions
@@ -66,6 +66,7 @@ import tier9 from '@/assets/svg/tier-staff.svg';
 import tierNPC from '@/assets/svg/tier-npc.svg';

 export default {
+  mixins: [styleHelper],
  props: ['selections', 'text', 'caretPosition', 'coords', 'chat', 'textbox'],
  data () {
    return {
@@ -93,7 +94,7 @@ export default {
  computed: {
    autocompleteStyle () {
      function heightToUse (textBox, topCoords) {
-        let textBoxHeight = textBox['user-entry'].clientHeight;
+        const textBoxHeight = textBox['user-entry'].clientHeight;
        return topCoords < textBoxHeight ? topCoords + 30 : textBoxHeight + 10;
      }
      return {
@@ -113,15 +114,10 @@ export default {
      this.currentSearch = this.atRegex.exec(this.text)[0]; // eslint-disable-line vue/no-side-effects-in-computed-properties
      this.currentSearch = this.currentSearch.substring(1, this.currentSearch.length); // eslint-disable-line vue/no-side-effects-in-computed-properties

-      return this.tmpSelections.filter((option) => {
-        return option.displayName.toLowerCase().indexOf(this.currentSearch.toLowerCase()) !== -1 || option.username && option.username.toLowerCase().indexOf(this.currentSearch.toLowerCase()) !== -1;
-      }).slice(0, 4);
+      return this.tmpSelections.filter(option => option.displayName.toLowerCase().indexOf(this.currentSearch.toLowerCase()) !== -1 || option.username && option.username.toLowerCase().indexOf(this.currentSearch.toLowerCase()) !== -1).slice(0, 4);
    },

  },
-  mounted () {
-    this.grabUserNames();
-  },
  watch: {
    text (newText) {
      if (!newText[newText.length - 1] || newText[newText.length - 1] === ' ') {
@@ -143,6 +139,9 @@ export default {
      this.grabUserNames();
    },
  },
+  mounted () {
+    this.grabUserNames();
+  },
  methods: {
    resetDefaults () {
      // Mounted is not called when switching between group pages because they have the
@@ -153,9 +152,9 @@ export default {
      this.resetSelection();
    },
    grabUserNames () {
-      let usersThatMessage = groupBy(this.chat, 'user');
-      for (let userKey in usersThatMessage) {
-        let systemMessage = userKey === 'undefined';
+      const usersThatMessage = groupBy(this.chat, 'user');
+      for (const userKey in usersThatMessage) {
+        const systemMessage = userKey === 'undefined';
        if (!systemMessage && this.tmpSelections.indexOf(userKey) === -1) {
          this.tmpSelections.push({
            displayName: userKey,
@@ -204,18 +203,18 @@ export default {
    selectNext () {
      if (this.searchResults.length > 0) {
        this.clearHover();
-        this.selected = this.selected === null ?
-          0 :
-          (this.selected + 1) % this.searchResults.length;
+        this.selected = this.selected === null
+          ? 0
+          : (this.selected + 1) % this.searchResults.length;
        this.searchResults[this.selected].hover = true;
      }
    },
    selectPrevious () {
      if (this.searchResults.length > 0) {
        this.clearHover();
-        this.selected = this.selected === null ?
-          this.searchResults.length - 1 :
-          (this.selected - 1 + this.searchResults.length) % this.searchResults.length;
+        this.selected = this.selected === null
+          ? this.searchResults.length - 1
+          : (this.selected - 1 + this.searchResults.length) % this.searchResults.length;
        this.searchResults[this.selected].hover = true;
      }
    },
@@ -231,6 +230,5 @@ export default {
      this.resetSelection();
    },
  },
-  mixins: [styleHelper],
 };
 </script>
@@ -140,7 +140,16 @@ import { highlightUsers } from '../../libs/highlightUsers';
 import { CHAT_FLAG_LIMIT_FOR_HIDING, CHAT_FLAG_FROM_SHADOW_MUTE } from '@/../../common/script/constants';

 export default {
-  components: {userLink},
+  components: { userLink },
+  filters: {
+    timeAgo (value) {
+      return moment(value).fromNow();
+    },
+    date (value) {
+      // @TODO: Vue doesn't support this so we cant user preference
+      return moment(value).toDate().toString();
+    },
+  },
  props: {
    msg: {},
    inbox: {
@@ -161,20 +170,11 @@ export default {
      reported: false,
    };
  },
-  filters: {
-    timeAgo (value) {
-      return moment(value).fromNow();
-    },
-    date (value) {
-      // @TODO: Vue doesn't support this so we cant user preference
-      return moment(value).toDate().toString();
-    },
-  },
  computed: {
-    ...mapState({user: 'user.data'}),
+    ...mapState({ user: 'user.data' }),
    isUserMentioned () {
      const message = this.msg;
-      const user = this.user;
+      const { user } = this;

      if (message.hasOwnProperty('highlight')) return message.highlight;

@@ -190,7 +190,7 @@ export default {
      const pattern = `@(${escapedUsername}|${escapedDisplayName})(\\b)`;
      const precedingChar = messageText.substring(mentioned - 1, mentioned);
      if (mentioned === 0 || precedingChar.trim() === '' || precedingChar === '@') {
-        let regex = new RegExp(pattern, 'i');
+        const regex = new RegExp(pattern, 'i');
        message.highlight = regex.test(messageText);
      }

@@ -201,8 +201,8 @@ export default {
      if (!message.likes) return 0;

      let likeCount = 0;
-      for (let key in message.likes) {
-        let like = message.likes[key];
+      for (const key in message.likes) {
+        const like = message.likes[key];
        if (like) likeCount += 1;
      }
      return likeCount;
@@ -217,9 +217,14 @@ export default {
      return 'Message hidden (shadow-muted)';
    },
  },
+  mounted () {
+    this.CHAT_FLAG_LIMIT_FOR_HIDING = CHAT_FLAG_LIMIT_FOR_HIDING;
+    this.CHAT_FLAG_FROM_SHADOW_MUTE = CHAT_FLAG_FROM_SHADOW_MUTE;
+    this.$emit('chat-card-mounted', this.msg.id);
+  },
  methods: {
    async like () {
-      let message = cloneDeep(this.msg);
+      const message = cloneDeep(this.msg);

      await this.$store.dispatch('chat:like', {
        groupId: this.groupId,
@@ -279,10 +284,5 @@ export default {
      return habiticaMarkdown.render(String(text));
    },
  },
-  mounted () {
-    this.CHAT_FLAG_LIMIT_FOR_HIDING = CHAT_FLAG_LIMIT_FOR_HIDING;
-    this.CHAT_FLAG_FROM_SHADOW_MUTE = CHAT_FLAG_FROM_SHADOW_MUTE;
-    this.$emit('chat-card-mounted', this.msg.id);
-  },
 };
 </script>
@@ -140,15 +140,20 @@
 <script>
 import moment from 'moment';
 import axios from 'axios';
-import { mapState } from '@/libs/store';
 import debounce from 'lodash/debounce';
 import findIndex from 'lodash/findIndex';
+import { mapState } from '@/libs/store';

 import Avatar from '../avatar';
 import copyAsTodoModal from './copyAsTodoModal';
 import chatCard from './chatCard';

 export default {
+  components: {
+    copyAsTodoModal,
+    chatCard,
+    Avatar,
+  },
  props: {
    chat: {},
    inbox: {
@@ -162,20 +167,6 @@ export default {
    isLoading: Boolean,
    canLoadMore: Boolean,
  },
-  components: {
-    copyAsTodoModal,
-    chatCard,
-    Avatar,
-  },
-  mounted () {
-    this.loadProfileCache();
-  },
-  created () {
-    window.addEventListener('scroll', this.handleScroll);
-  },
-  destroyed () {
-    window.removeEventListener('scroll', this.handleScroll);
-  },
  data () {
    return {
      currentDayDividerDisplay: moment().day(),
@@ -187,8 +178,17 @@ export default {
      lastOffset: -1,
    };
  },
+  mounted () {
+    this.loadProfileCache();
+  },
+  created () {
+    window.addEventListener('scroll', this.handleScroll);
+  },
+  destroyed () {
+    window.removeEventListener('scroll', this.handleScroll);
+  },
  computed: {
-    ...mapState({user: 'user.data'}),
+    ...mapState({ user: 'user.data' }),
    // @TODO: We need a different lazy load mechnism.
    // But honestly, adding a paging route to chat would solve this
    messages () {
@@ -201,7 +201,7 @@ export default {
      this.loadProfileCache(window.scrollY / 1000);
    },
    async triggerLoad () {
-      const container = this.$refs.container;
+      const { container } = this.$refs;

      // get current offset
      this.lastOffset = container.scrollTop - (container.scrollHeight - container.clientHeight);
@@ -226,7 +226,7 @@ export default {
      if (this.loading) return;
      this.loading = true;

-      let promises = [];
+      const promises = [];
      const noProfilesLoaded = Object.keys(this.cachedProfileData).length === 0;

      // @TODO: write an explination
@@ -237,9 +237,9 @@ export default {
        return;
      }

-      let aboutToCache = {};
+      const aboutToCache = {};
      this.messages.forEach(message => {
-        let uuid = message.uuid;
+        const { uuid } = message;

        if (message.userStyles) {
          this.$set(this.cachedProfileData, uuid, message.userStyles);
@@ -253,21 +253,21 @@ export default {
        }
      });

-      let results = await Promise.all(promises);
+      const results = await Promise.all(promises);
      results.forEach(result => {
        // We could not load the user. Maybe they were deleted. So, let's cache empty so we don't try again
        if (!result || !result.data || result.status >= 400) {
          return;
        }

-        let userData = result.data.data;
+        const userData = result.data.data;
        this.$set(this.cachedProfileData, userData._id, userData);
      });

      // Merge in any attempts that were rejected so we don't attempt again
-      for (let uuid in aboutToCache) {
+      for (const uuid in aboutToCache) {
        if (!this.cachedProfileData[uuid]) {
-          this.$set(this.cachedProfileData, uuid, {rejected: true});
+          this.$set(this.cachedProfileData, uuid, { rejected: true });
        }
      }

@@ -293,22 +293,21 @@ export default {
            type: 'error',
            timeout: false,
          });
-        } else {
-          this.cachedProfileData[memberId] = result.data.data;
-          profile = result.data.data;
        }
+        this.cachedProfileData[memberId] = result.data.data;
+        profile = result.data.data;
      }

      // Open the modal only if the data is available
      if (profile && !profile.rejected) {
-        this.$router.push({name: 'userProfile', params: {userId: profile._id}});
+        this.$router.push({ name: 'userProfile', params: { userId: profile._id } });
      }
    },
-    itemWasMounted: debounce(function itemWasMounted ()  {
+    itemWasMounted: debounce(function itemWasMounted () {
      if (this.handleScrollBack) {
        this.handleScrollBack = false;

-        const container = this.$refs.container;
+        const { container } = this.$refs;
        const offset = container.scrollHeight - container.clientHeight;

        const newOffset = offset + this.lastOffset;
@@ -319,9 +318,7 @@ export default {
      }
    }, 50),
    messageLiked (message) {
-      const chatIndex = findIndex(this.chat, chatMessage => {
-        return chatMessage.id === message.id;
-      });
+      const chatIndex = findIndex(this.chat, chatMessage => chatMessage.id === message.id);
      this.chat.splice(chatIndex, 1, message);
    },
    messageRemoved (message) {
@@ -330,9 +327,7 @@ export default {
        return;
      }

-      const chatIndex = findIndex(this.chat, chatMessage => {
-        return chatMessage.id === message.id;
-      });
+      const chatIndex = findIndex(this.chat, chatMessage => chatMessage.id === message.id);
      this.chat.splice(chatIndex, 1);
    },
  },
@@ -59,11 +59,10 @@ export default {
    groupPath () {
      if (this.groupId === TAVERN_ID) {
        return `${baseUrl}/groups/tavern`;
-      } else if (this.groupType === 'party') {
+      } if (this.groupType === 'party') {
        return `${baseUrl}/party`;
-      } else {
-        return `${baseUrl}/groups/guild/${this.groupId}`;
      }
+      return `${baseUrl}/groups/guild/${this.groupId}`;
    },
    close () {
      this.$root.$emit('bv::hide::modal', 'copyAsTodo');
@@ -66,15 +66,15 @@ import notifications from '@/mixins/notifications';
 import markdownDirective from '@/directives/markdown';

 export default {
-  mixins: [notifications],
  directives: {
    markdown: markdownDirective,
  },
+  mixins: [notifications],
  computed: {
-    ...mapState({user: 'user.data'}),
+    ...mapState({ user: 'user.data' }),
    reportData () {
      let reportMessage = this.abuseObject.user;
-      let isSystemMessage = this.abuseObject.uuid === 'system';
+      const isSystemMessage = this.abuseObject.uuid === 'system';
      if (isSystemMessage) reportMessage = this.$t('systemMessage');
      return {
        name: `<span class='text-danger'>${reportMessage}</span>`,
@@ -82,7 +82,7 @@ export default {
    },
  },
  data () {
-    let abuseFlagModalBody = {
+    const abuseFlagModalBody = {
      firstLinkStart: '<a href="/static/community-guidelines" target="_blank">',
      secondLinkStart: '<a href="/static/terms" target="_blank">',
      linkEnd: '</a>',
@@ -108,7 +108,7 @@ export default {
    async reportAbuse () {
      this.text(this.$t(this.groupId === 'privateMessage' ? 'pmReported' : 'abuseReported'));

-      let result = await this.$store.dispatch('chat:flag', {
+      const result = await this.$store.dispatch('chat:flag', {
        groupId: this.groupId,
        chatId: this.abuseObject.id,
        comment: this.reportComment,