From e9ed561907eee5fb6df2947519ed243db8931c35 Mon Sep 17 00:00:00 2001
From: Sabe Jones <sabrecat@gmail.com>
Date: Mon, 27 Jul 2015 14:34:31 -0500
Subject: [PATCH] fix(analytics): Add missing ID update

Also make the order of partyID and partySize consistent across updateUser calls.
---
 website/public/js/controllers/groupsCtrl.js | 2 +-
 website/public/js/services/groupServices.js | 8 ++++----
 website/public/js/services/questServices.js | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/website/public/js/controllers/groupsCtrl.js b/website/public/js/controllers/groupsCtrl.js
index 6908ca1d70..52bd43cf39 100644
--- a/website/public/js/controllers/groupsCtrl.js
+++ b/website/public/js/controllers/groupsCtrl.js
@@ -267,7 +267,7 @@ habitrpg.controller("GroupsCtrl", ['$scope', '$rootScope', 'Shared', 'Groups', '
         $scope.message.content = '';
         $scope._sending = false;
         if (group.type == 'party') {
-          Analytics.updateUser({'partySize':group.memberCount});
+          Analytics.updateUser({'partyID':group.id,'partySize':group.memberCount});
         }
         if (group.privacy == 'public'){
           Analytics.track({'hitType':'event','eventCategory':'behavior','eventAction':'group chat','groupType':group.type,'privacy':group.privacy,'groupName':group.name,'message':message});
diff --git a/website/public/js/services/groupServices.js b/website/public/js/services/groupServices.js
index fc31b706f0..c75474ea5f 100644
--- a/website/public/js/services/groupServices.js
+++ b/website/public/js/services/groupServices.js
@@ -64,25 +64,25 @@ function($rootScope, ApiUrl, $resource, $q, $http, User, Challenges, Analytics,
     },
 
     questAccept: function(party){
-      Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id});
+      Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
       party.$questAccept()
         .then(syncUser, logError);
     },
 
     questReject: function(party){
-      Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id});
+      Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
       party.$questReject()
         .then(syncUser, logError);
     },
 
     questCancel: function(party){
-      Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id});
+      Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
       party.$questCancel()
         .then(syncUser, logError);
     },
 
     questAbort: function(party){
-      Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id});
+      Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
       party.$questAbort()
         .then(syncUser, logError);
     },
diff --git a/website/public/js/services/questServices.js b/website/public/js/services/questServices.js
index 7e7252a0d0..9483837d7b 100644
--- a/website/public/js/services/questServices.js
+++ b/website/public/js/services/questServices.js
@@ -87,7 +87,7 @@
 
     function questInit(){
       Analytics.track({'hitType':'event','eventCategory':'behavior','eventAction':'quest','owner':true,'response':'accept','questName':$rootScope.selectedQuest.key});
-      Analytics.updateUser({'partySize':party.memberCount,'partyID':party.id});
+      Analytics.updateUser({'partyID':party.id,'partySize':party.memberCount});
       party.$questAccept({key:$rootScope.selectedQuest.key}, function(){
         party.$get();
         $rootScope.$state.go('options.social.party');