From f49f67ff5cd6e0a46b2343e871bbaa168768f12d Mon Sep 17 00:00:00 2001
From: negue <eugen.bolz@gmail.com>
Date: Wed, 5 Apr 2023 22:56:37 +0200
Subject: [PATCH] remove unused settings

---
 .../client/src/components/tasks/column.vue    |  1 -
 .../src/pages/settings/generalSettings.vue    | 14 ------
 .../settings/settingRows/taskSettings.vue     | 50 -------------------
 website/common/locales/en/settings.json       |  2 -
 website/server/models/user/schema.js          |  2 +
 5 files changed, 2 insertions(+), 67 deletions(-)
 delete mode 100644 website/client/src/pages/settings/settingRows/taskSettings.vue

diff --git a/website/client/src/components/tasks/column.vue b/website/client/src/components/tasks/column.vue
index 3cae7ba8ed..849d0b009d 100644
--- a/website/client/src/components/tasks/column.vue
+++ b/website/client/src/components/tasks/column.vue
@@ -674,7 +674,6 @@ export default {
       // loads and not on subsequent reloads.
       if (
         type === 'daily' && filter === '' && !this.challenge
-        && this.user.preferences.dailyDueDefaultView
       ) {
         filter = 'due'; // eslint-disable-line no-param-reassign
       }
diff --git a/website/client/src/pages/settings/generalSettings.vue b/website/client/src/pages/settings/generalSettings.vue
index 7e63b627e6..de79a3e468 100644
--- a/website/client/src/pages/settings/generalSettings.vue
+++ b/website/client/src/pages/settings/generalSettings.vue
@@ -66,18 +66,6 @@
           </td>
         </tr>
       </table>
-
-      <h2 v-once>
-        {{ $t('taskSettings') }}
-      </h2>
-
-      <table class="table">
-        <task-settings />
-        <tr>
-          <td colspan="3">
-          </td>
-        </tr>
-      </table>
     </div>
   </div>
 </template>
@@ -111,7 +99,6 @@ import AudioThemeSetting from '@/pages/settings/settingRows/audioThemeSetting.vu
 import ClassSetting from '@/pages/settings/settingRows/classSetting.vue';
 import FixValuesSetting from '@/pages/settings/settingRows/fixValuesSetting.vue';
 import LoginMethods from '@/pages/settings/settingRows/loginMethods.vue';
-import TaskSettings from '@/pages/settings/settingRows/taskSettings.vue';
 import { GenericUserPreferencesMixin } from '@/pages/settings/components/genericUserPreferencesMixin';
 import { mapState } from '@/libs/store';
 import SleepMode from '@/pages/settings/settingRows/sleepMode.vue';
@@ -119,7 +106,6 @@ import SleepMode from '@/pages/settings/settingRows/sleepMode.vue';
 export default {
   components: {
     SleepMode,
-    TaskSettings,
     LoginMethods,
     FixValuesSetting,
     ClassSetting,
diff --git a/website/client/src/pages/settings/settingRows/taskSettings.vue b/website/client/src/pages/settings/settingRows/taskSettings.vue
deleted file mode 100644
index 24766f812a..0000000000
--- a/website/client/src/pages/settings/settingRows/taskSettings.vue
+++ /dev/null
@@ -1,50 +0,0 @@
-<template>
-  <fragment>
-    <tr>
-      <td class="settings-label">
-        <span
-          v-b-popover.hover.right="$t('dailyDueDefaultViewPop')"
-          class="hint"
-        >{{ $t('dailyDueDefaultView') }}</span>
-      </td>
-      <td class="settings-value">
-      </td>
-      <td class="settings-button">
-        <toggle-switch
-          v-model="user.preferences.dailyDueDefaultView"
-          @change="setUserPreference('dailyDueDefaultView')"
-        />
-      </td>
-    </tr>
-  </fragment>
-</template>
-
-<style lang="scss" scoped>
-@import '~@/assets/scss/colors.scss';
-
-::v-deep {
-  .toggle-switch-outer {
-    display: inline-block;
-  }
-}
-</style>
-
-<script>
-import { mapState } from '@/libs/store';
-
-import { InlineSettingMixin } from '../components/inlineSettingMixin';
-import ToggleSwitch from '@/components/ui/toggleSwitch.vue';
-import { GenericUserPreferencesMixin } from '../components/genericUserPreferencesMixin';
-
-
-export default {
-  components: { ToggleSwitch },
-  mixins: [InlineSettingMixin, GenericUserPreferencesMixin],
-  computed: {
-    ...mapState({
-      user: 'user.data',
-    }),
-  },
-  methods: {},
-};
-</script>
diff --git a/website/common/locales/en/settings.json b/website/common/locales/en/settings.json
index bdfbaecc82..73ed0080ff 100644
--- a/website/common/locales/en/settings.json
+++ b/website/common/locales/en/settings.json
@@ -13,8 +13,6 @@
     "helpWithTranslation": "Are you interested in helping with the translation of Habitica? Great! Then visit <a href=\"/groups/guild/7732f64c-33ee-4cce-873c-fc28f147a6f7\">the Aspiring Linguists Guild</a>!",
     "stickyHeader": "Sticky header",
     "newTaskEdit": "Open new tasks in edit mode",
-    "dailyDueDefaultView": "Set Dailies default to 'due' tab",
-    "dailyDueDefaultViewPop": "With this option set, the Dailies tasks will default to 'due' instead of 'all'",
     "reverseChatOrder": "Show chat messages in reverse order",
     "dontShowAgain": "Don't show this again",
     "showLevelUpModal": "When Gaining a Level",
diff --git a/website/server/models/user/schema.js b/website/server/models/user/schema.js
index 8ef257aca7..59d916602d 100644
--- a/website/server/models/user/schema.js
+++ b/website/server/models/user/schema.js
@@ -531,7 +531,9 @@ export const UserSchema = new Schema({
     stickyHeader: { $type: Boolean, default: true },
     disableClasses: { $type: Boolean, default: false },
     newTaskEdit: { $type: Boolean, default: false },
+    // deprecated, unused
     dailyDueDefaultView: { $type: Boolean, default: false },
+    // deprecated, unused
     advancedCollapsed: { $type: Boolean, default: false },
     toolbarCollapsed: { $type: Boolean, default: false },
     reverseChatOrder: { $type: Boolean, default: false },