* Issue 12220 - Show dailies protected by Stealth
A feature on the old site showed the number of
dailies protected by casting Stealth. This is
now showing again in the Stealth tooltip. The
skillNotes section was not being called. It
adds additional skill-specific info: the dailies
avoided by stealth, whether stealth no longer
needs to be cast (dailies already avoided) and
whether frost is no longer useful to cast.
Speculation: the spellDisabled method had some
commented out code regarding Stealth, which
may have broken due to a change in how dailies
are referenced. I have fixed this line, so it
seemed alright to keep the entirety of the
skillNotes function as it had been. However,
this includes more than just showing dailies
in the tooltip.
Behavior changes:
- tooltip shows dailies avoided for Stealth
- tooltip shows maxed out message for
Stealth when all dailies are covered
- tooltip shows frost already cast message
when frost has already been cast
* clean up conditions in skillNotes
* use future tense for rogue stealth dailies tooltip
* use getter for accurate task length
* consider stealth disabled based on incomplete dailies due, not all dailies
* Issue 12220 - Show dailies protected by Stealth
A feature on the old site showed the number of
dailies protected by casting Stealth. This is
now showing again in the Stealth tooltip. The
skillNotes section was not being called. It
adds additional skill-specific info: the dailies
avoided by stealth, whether stealth no longer
needs to be cast (dailies already avoided) and
whether frost is no longer useful to cast.
Speculation: the spellDisabled method had some
commented out code regarding Stealth, which
may have broken due to a change in how dailies
are referenced. I have fixed this line, so it
seemed alright to keep the entirety of the
skillNotes function as it had been. However,
this includes more than just showing dailies
in the tooltip.
Behavior changes:
- tooltip shows dailies avoided for Stealth
- tooltip shows maxed out message for
Stealth when all dailies are covered
- tooltip shows frost already cast message
when frost has already been cast
* factor out stealthBuffsToAdd for casting stealth + tooltip previewing dailies avoided
* fix merge conflict
by @Shuyinsama
Squashed commit of the following:
commit 0c05ff510e4bd0d7161c49245dd11e6abe882d96
Author: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Sat Jun 27 19:41:58 2020 +0200
fix lint
commit 2e1e1e4071d57fa2853a4a8f481c94bd5836037f
Merge: cbc9af4ef5fc46d73b1d
Author: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Sat Jun 27 19:39:58 2020 +0200
Merge branch 'feature/Deleting-a-reward-asks-you-if-you-want-to-delete-the-task' of https://github.com/Shuyinsama/habitica into Shuyinsama-feature/Deleting-a-reward-asks-you-if-you-want-to-delete-the-task
commit fc46d73b1d
Author: Patrick van Zadel <Shuyinsama@users.noreply.github.com>
Date: Sat Jun 27 18:54:08 2020 +0200
Renamed keys and fixed a check in the modal
commit ec5b765f5c
Author: Patrick van Zadel <Shuyinsama@users.noreply.github.com>
Date: Sat Jun 27 18:45:25 2020 +0200
Renamed translation keys
commit f0837dc571
Author: Patrick van Zadel <patrickvanzadel@eleven.nl>
Date: Tue Jun 23 23:06:59 2020 +0200
Added the task type to the "Delete" alert window so it now asks if you want to delete the task of type
Edited the "Delete this ..." button in the edit task modal to represent the task type
* Make links to deleted profiles display 404
* Implement some requested changes
- remove comments
- remove 'await'
- rename error -> 404error
- remove catch block -> just check for 404
* Fix bug: Logged in user profile showing 404
- Initiallty logged in user will display fine
- This bug only appeared after you view a deleted users modal
* Remove 'user.active' attribute
- add change to data():
- user: undefined -> user: {}
* Shorten showMemberModal()
- Remove unused fetch profile data
- Remove unnecessary conditional
* Change user initial value to null
- Add userLoaded to data
* Habits in the challenge view have incorrect and misaligned negative icon
Change the check for the negative icon to something more suitable so the lock icon is shown when needed
* Habits in the challenge view have incorrect and misaligned negative icon
Removed the check for task.group.id
Co-authored-by: Patrick van Zadel <patrickvanzadel@eleven.nl>
Sabe Jones