Commit Graph

10 Commits

Author SHA1 Message Date
Kaitlin Hipkin a3f83b9076 Improvement #6912: New achievement modal service and more achievement tests (#6943)
* add tests for beastMaster, mountMaster, and triadBingo achievements

* add tests for challengeWon, streak, ultimateGear, rebirth, and contributor achievements

* add achievement service that has openModal function

* achievement test pass again

* fix indentation, rename openModal to more descriptive displayAchievement

* add unit tests for achievements service

* initialize user.preferences.suppressModals in specHelper.newUser

* update achievement tests to account for new notification service

* add new achievementServices file to manifest.json

* fix tests

* award wonChallenge achiev like other achievs

* differentiate between small and normal achiev modals

* refactor achievementService.displayAchievement() to take options param
2016-09-09 07:58:44 -05:00
hairlessbear 0e4e7a032a Added explanatory comment 2015-06-22 21:36:06 -04:00
hairlessbear f0ddbae775 Added quest completion modal test for when RSVPNeeded is true; modified quest invite test to use 'to.not.be.calledWith' 2015-06-22 21:33:38 -04:00
hairlessbear c942c10c17 Added a line break 2015-06-22 21:21:38 -04:00
hairlessbear b249e103de Removed duplicated test 2015-06-22 21:04:28 -04:00
hairlessbear f75bbb6e5f Modified 'RSVPNeeded is not true' test to not set user.party.quest.completed because it is not needed for the test 2015-06-22 20:55:50 -04:00
hairlessbear 8026e99219 Added quest completion modal watch tests 2015-06-22 20:48:11 -04:00
hairlessbear c5292e7ff8 Changed 'invite modal does not open' tests to focus on completion modal opening, but being the only modal to open. Also modified the named of two tests to be more intuitive and accurate 2015-06-22 20:33:49 -04:00
Blade Barringer 11fcb54c03 Corrected watch check
https://github.com/hairlessbear/habitrpg/commit/4fc04fea24889d3550cfb01f508466ff56c5ad40#commitcomment-11784493
2015-06-21 10:44:59 -05:00
Blade Barringer 4fc04fea24 Adjustments to PR #5298
* Put watch on $scope
* Check for quest.completed !== true or false
* Add test for quest invite modal watch
2015-06-20 21:10:18 -05:00