* Issue #14175 - Created a categoryOptions.js file in website/common/script/content to store list of category Options. Imported and added the list to website/client/src/components : challenges/challengeModal, challenges/sidebar, groups/groupFormModal, and groups/groupSidebar. This replaced the statically typed lists that previously existed. Tested the challengeModal and sidebar but unable to test the groups files due to credit card requirements. -@Tundrian
* Issue #14175 - Created a categoryOptions.js file in website/common/script/content to store list of category Options. Imported and added the list to website/client/src/components : challenges/challengeModal, challenges/sidebar, groups/groupFormModal, and groups/groupSidebar. This replaced the statically typed lists that previously existed. Tested the challengeModal and sidebar but unable to test the groups files due to credit card requirements. -@Tundrian
Co-authored-by: SabreCat <sabe@habitica.com>
Fix props' change handler which is called when guild is changed from
notification.
Tests:
+ Guild challenges updated successfully when guild is changed from
notification center.
Co-authored-by: neel <neel@helpshift.com>
* create Admin Panel page with initial content from Hall's admin section
* reorganise Admin Panel form and add more accordians
* add lastCron to fields returned by api.getHeroes
* improve timestamps and authentication section
* add party and quest info to Admin Panel, add party to heroAdminFields
* move Admin Panel menu item to top of menu, make invisible to non-admins
* remove code used for displaying all Heroes
* add avatar appearance and drops section in Admin Panel
* allow logged-in user to be the default hero loaded
* add time zones to timestamp/authentication section
* rename Items to Update Items
This will allow a new Items section to be added.
* add read-only Items display with button to copy data to Update Items section
* remove never-used allItemsPaths code that had been copied from Hall
* update tests for the attributes added to heroAdminFields
* supply names for items and also set information for gear/equipment
* remove code that loads subsections of content
We use enough of the content that it's easier to load it all and
access it through the content object, especially when we're looping
through different item types.
* add gear names and set details to Avatar Costume/Battle Gear section
* make the wiki URLs clickable and make minor item format improvements
* add gear sets for Check-In Incentives and animal ears and tails
* add gear set for Gold-Purchasable Quest Lines
Also merges the existing Mystery of the Masterclassers quest set into it.
* fix error with Kickstarter gear set and include wiki link
* improve description of check-in incentive gear set
* fix description of Items section
* fix lint warnings
* update another test for the attributes added to heroAdminFields
* allow "@" to be included when specifying Username to load
* create GetHeroParty API v3 route to fetch a given user's party data
Only some data from the party will be loaded (e.g., not private
data such as name, description).
Includes tests for the route.
See the next commit for front-end changes that use this.
* display data from a given user's party in admin panel
Only some data from the party will be loaded (e.g., not private
data such as name, description).
Also adds support for finding and displaying errors from the
user's data.
* use new error handling method for other sections
- Time zone differences
- Cron bugs
- Privilege removal (mute/block) - not a bug but needs to be highlighted
* redirect non-admin users away from admin-only page (WIP)
This needs more work. Currently, admin users are also redirected
if they access the page by direct URL or after reload.
* clarify source of items from Check-In Incentives and Lunar Battle quests
* replace non-standard form fields with HTML forms
* add user's language, remove unused export blocks
* convert functions to filters: formatDate, formatTimeZone
* improve display of minutes portion of time zone in Admin Panel
* move basic details about user to a new component
* move Timestamp/Cron/Auth/etc details to a new component - WIP, has errors
The automatic expand and error warnings don't reset themselves when
you fetch data for a new user.
* replace non-standard form fields with HTML forms
Most of this was done in 26fdcbbee5
* move Timestamp/Cron/Auth/etc details to a new component (fixed)
* move Avatar and Drops section to a new component
* move Party and Quest section to a new component
* move Contributor Details to new component, add checkbox for admin, add preview
This adds a markdown-enabled preview of the Contributions textarea.
It also removes the code that automatically set contributor.admin
to true when the Tier was above 7.
That feature wasn't secure because the Tier can be accidentally
changed if you scroll while the cursor is over the Tier form field
(we accidentally demoted a Socialite once by doing that and if
we'd scrolled in the other direction we would have given her
admin privileges).
Instead there's now a checkbox for giving moderator-level privileges.
We'll want that anyway when we move to a system of selected
privileges for each admin instead of all admin privileges being
given to all mods/staff.
There's also a commented-out checkbox for giving Bailey CMS
privileges, for when we're ready to use that. The User model doesn't
yet have support for it.
* move Privileges and Gems section to a new component
* rename formatItems to getItemDescription; make other minor fixes
* remove an outdated test description
This "pended" explanation probably wasn't needed after "x" was
removed from "describe" in 2ab76db27c
* add newsPoster Bailey CMS permission to User model and Admin Panel
* move formatDate from mixins to filters
* make lint fixes
* remove development comments from hall.js
I'll be handling the TODO comment and I've left in my "XXX" marker
to remind me
* fix bug in Hall's castItemVal: mounts are null not false
* move Items section to a new component and delete Update Items section
The Update Items section is no longer needed because the new Items
component has in-place editing.
* remove unused imports
* add "secret" field to "Privileges, Gem Balance" section.
Also move the markdownPreview style from contributorDetails.vue to
index.vue since it's used in two components now.
* show non-Standard never-owned Pets and Mounts in Items section
* redirect non-admin users away from admin-only page
This completes the work started in commit a4f9c754ad
It now allows admins to access the page when coming from another
page on the site or from a direct link, including if the admin user
isn't logged in yet.
* display memberCount for party
* add secret.text field to Contributor Details
This is in addition to showing it in the Privileges section because
the secret text could be about either troublesome behaviour or
contributions.
* allow user to be loaded into Admin Panel via a URL
This includes:
- router config has a child route for the admin panel with a
Username/ID as a parameter
- loadHero code moved from top-level index page into a new
"user support" index page
- links in the Hall changed to point to admin panel route
- admin panel link added to admin section of user profile modal
* keep list of known titles on their own lines
* sort heroFields alphabetically
No actual changes.
* return all flags for use in Admin Panel and fix Hall tests for flags
Future Admin Panel changes will display more flags.
NB 'flags' wasn't in the tests before, even though two optional
flags were being fetched.
The tests weren't failing because the test users hadn't been given
data for those optional flags.
The primary reason for this change now is to fix the tests.
* show part of the API Token in the Admin Panel
* send full hero object into cronAndAuth.vue
This is a prelude to allowing this component to change the hero.
* split heroAdminFields string into two: one for fetching data and one for showing it
This is because apiToken must be fetched but not shown,
while apiTokenObscured is calculated (not fetched) and shown.
* let admin change a user's API Token
* restore sanity
* remove code to show obscured version of API Token
It will return with tighter permissions for viewing it.
* add Custom Day Start time (CDS) to Timestamps, Time Zone... section
* commit lint's automatic fixes - one for admin-panel changes in hall.js
The other fixes aren't related to this PR but I figured they may
as well go live.
* apply fixes from paglias's comments, excluding style/CSS changesd
The comments that this PR fixes start at
https://github.com/HabitRPG/habitica/pull/12035#pullrequestreview-500422316
Style fixes will be in a future commit.
* fix styles/CSS
* allow profile modal to close when using admin panel link
Also removes an empty components block.
* prevent Admin Panel being used without new userSupport privilege
Also adds initial support for other contributor.priv privileges
and changes Debug Menu to add userSupport privilege
* don't do this: this.hero = { ...hero };
* enhance quest error messages
* redirect to admin-panel home page when using "Save and Clear Data"
The user's ID / name is still in the form for easy refetching.
* create ensurePriv function, use in api.getHeroParty
* fix lint problems and integration tests
* add page title to top-level Admin Panel
Also add more details to a router comment (consistent with a similar
comment) in case it helps anyone.
* fix tests
* display Moderation Notes above Contributions
* lint fix
* remove placeholder code for new privileges
I had planned to have each of these implemented in stages, but
paglias wanted it all done at once. I'm afraid that's too big a
project for me to take on in a single PR so I'm cancelling
the plans for adjusting the privileges.
* Improve permission handling
* Don't report timezone error on first day
* fix lint error
* .
* Fix lint error
* fix failing tests
* Fix more tests
* .
* ..
* ...
* fix(admin): always include permissions when querying user
also remove unnecessary failing test case
* permission improvements
* show transactions in admin panel
* fix lint errors
* fix permission check
* fix(panel): missing mixin, handle empty perms object
Co-authored-by: Alys <alice.harris@oldgods.net>
Co-authored-by: SabreCat <sabe@habitica.com>
* i18n string updates (issue #9210)
* change offHand to offHandCapitalized
* added removeTasks to challenge.json
* added hairBangs back to character.json
* added hairBangs back to character.json
* more hairBangs nonsense
* added hairBangs to hair-settings.vue, removed same from character.json
* changed levelUp to levelup in levelUp.vue and achievements.json
* fix duplicate string values
* fixed different strings with same content in different files
* updated test/api/v3 and test/api/v4 with messageTaskNotFound
* Delete POST-tasks_taskId_checklist_itemId_score.test.js
File got copied to a new directory, doesn't need to be here.
* fix: userID token in patrons.vue and heroes.vue
* removed: unused clock of code
* Restored eggsItemType to inventory.json
Co-authored-by: Sabe Jones <sabrecat@gmail.com>
* change 'role' options and filters to 'membership'
* added membership filtering function to discover challenges
* fix accidental deletion
* complete removal of roles from challenge filters
* abstract challenge "participating" filtering into mixin
* selecting "participating" and "not participating" shows all challenges
* move groups/sidebar to groupSidebar.vue
* lint files
* extract group/party sidebar to rightSidebar.vue
* wip stories with example data
* update stories - wip sidebar re-styling
* message party / group leader + move items to the menu
* update paddings /place for quest section
* invite to party / guild
* update labels (* Party / Guild )
* guild-background to group-background
* correct menu order + missing a label based on the group type
* no quest - styles / layout applied
* quest owner / not started - styles applied + extracted questActions from questDetailsModal.vue to a mixin
* no challenge style
* hover with underlines
* quest-pending area layout / margins
* "Collection Quest/Quest Owner Participating" Styling Done
* group sidebar menu with icons / background
* remove most participate button styles
* fix quest-invite panel
* move "Start Quest" + add "Leave Quest"
* Not Participating + Boss + Rage Quests restyling
* party quest changes - invitedToQuest + button styles + no-items style + view details
* fix icons + rage value + colors
* fix duplicate key
* hide items label if 0 items found + hide pending damage if there is none + sidebar section margin + fix percent calculation 0 => 0%
* combine quest abandon / cancel to one call + hide begin if quest has already started + close modal if quest was canceled
* remove unused translate string
* allow leaving an accepted but inactive quest + disable leave when user is quest leader
* update "are you sure" questions - remove "doubleSureAbort" - add "sureLeaveInactive"
* sidebar margins + menu icon color
* refactored css rules
* improve some styles
* fix button spacing
* fix dropmenu with icon hover
* hide leave quest for leaders + fix quest buttons spacing
* add pending items label
* remove "X items found" label
* first round of fixes
* last v-once
* Update Quest Dialogs (#13112)
* new quest rewards panel + extract questPopover and itemWithLabel
* WIP: questInfo still not applying the row-height..
* split up start-quest-modal into select and detail modal - also rename the current quest-details to be the group-quest-details modal
* remove start-quest-modal from modal-scss
* update package-lock
* WIP before using the quest sidebar branch as a base
* move quest detail actions to the "new" details dialog
* quest details layout for owner / participant
* fix quest rewards - open details modal from sidebar
* apply quest-details dialog styles to the buyQuestModal one
* fix quest reward icons / popover / texts
* WIP back to quest selection
* fix lint
* merge selectQuestModal.vue with questDetailModal.vue + UI for the select quest
* fix margins / layout / labels
* fix quest detail + wip invitationListModal.vue / participantListModal.vue
* fix questmodal user label centered
* fix centered reward items + grouping items and adding a count-badge
* sort quests by AZ or quantity
* invitations modal
* remove console.info
* complete participantListModal.vue + extracted getClassName
* missed a file for getClassName extraction
* fix invitations
* select the actual quest on details
* fix margins on invite to party / start quest buttons
* replace buyQuestModal close button and title
* fix recursion due to the same name
* missing import
* sort quantity by highest first
* fix "Can't find a Quest to start" styles
* fix "your balance" padding
* fix quest collections / drop items
* fix member details in participants list
* fix quest info
* remove nullable because the build doesn't like it (on this file..)
* add questCompleted to the stories + fix getDropName
* replace quest-rewards in questCompleted.vue
* fix questCompleted.vue style
* delete obsolete components
* add missing spritesheets to storebook
* requested pr changes
* refactored fetchMember
* revert optional chaining
* fix merge conflicts
* fix rightSidebar hover colors - $scss var to css var
* overflow auto instead of scroll
* prevent wrapping of quest collections
* rollback to multi line quest items
* use min-width for the quest popover
* membersModal use the new select component instead of html select
* update dropdown styles on challengeDetail (add task) and on inventory unequip
* change the width to "min-width"
* Update title for tabs not including challenges, guild and team
* add section titles to challenges, guilds, and groups
* Update dynamic title to use vuex action
* Remove duplicate key
* Actually remove duplicate key
* Fix section sub section in group
* Add note to implement setTitle when adding a page
* Add missing sections to dynamic title
* Features string not translated
* Use onGroupUpdate to update group titles
* Add watcher to challenges for dynamic title updates
* Small fixes
* Add register and login to title, remove duplicate keys
* Add home page dynamic title functionality
* Minor name changes
* remove wrong i18n strings from front.js
* refactor router note
Co-authored-by: Matteo Pagliazzi <matteopagliazzi@gmail.com>
* prevent some lint warnings by turning off some rules we don't seem to care about
require-prop-types has 167 violations
require-default-prop has 93 violations
* fix some lint warnings by adding eslint-disable-line comments
* prevent lint warnings by moving vue hooks to a different order
* apply some automatic lint fixes
* fix lint error by making line shorter
* prevent lint warnings from whitespace and @input, @click positioning
* revert 723fa38271
Reenables vue/require-prop-types and vue/require-default-prop
* wip
* refactor world state
* allow resource to be reloaded when the server is updated
* fix#9242
* fix event listeners
* remove un-needed code
* add tests for asyncResourceFactory reloadOnAppVersionChange
* fix double cron notifications and party members showing up in the header after a party invitation is accepted
* remove console.log
* do not send vm info to loggly due to circular dependency + fix typo
* fix#12181
* do not load invites multiple times in members modal
* add hover to challenge member count
* groups: load members only on demand
* minor ui fixes
* choose class: fix vue duplicate key warning
* minor ui fixes
* challanges: load members on demand
* add loading spinner
* change loading mechanism
* fix loading gryphon issues
* reduce code duplication
* Change where members info is retrieved in Group component.
In Group component, changes the place where members data is retrieved from the load function originally to within the watch group function, so that when group data has changed, the code will update the corresponding members data as well.
* Moving the code for loading members data from watcher to inside fetchGuilds function
* Complying with lint
Co-authored-by: kazekunGb <eynsan@yahoo.co.uk>
Co-authored-by: Matteo Pagliazzi <matteopagliazzi@gmail.com>
* fix: added client-side validation for challenge prizes
This commit aims to solve the issue #11765 by adding client-side
validation for the challenge prize. This way, a user is unable to create
a challenge if the prize is higher than what they can afford. Also, the
loading property is reset to false after fetching the challenge, however
this won't work if the request isn't successful.
* style: make validation conditional clearer
* fix: add exception handling when doing server requests.
This commit adds a basic try/catch block for handling server-side
errors, and successfully enables the submit button if something failed.
This may also fix#11545, in which a server-side error, difficult to
valide from the client, was causing the submit button to stay disabled
until reload.
* fix: reenable prize validation
* fix: bad indentation
* fix: Enable submit button on input change
* fix: add throttling to enableSubmit event.
* fix: reenable prize client-side validation.
Fixes#11768
- Check if `challenge.leader` is `null` before trying to display the user's name after "Created By:"
- Check the `challenge.leader` isn't `null` before trying to get its `id` for comparison when determining if the current user `canDelete` or `canEdit`
* 🎉 Working example of storybook and vue
* remove the older storybook version
* build storybook after client was built
* move storybook:build to npm-postintall
* remove automatically created eslint-disables + fix comment
* add back needed eslint :P + add @storybook/vue as devDep
* fix packagelock
* fix lint
* auto fixed lints + ignore dist/ node_modules/
* update package-lock.json
* add postbuild and readme
* add back customize config
* fix readme
* fix links in readme
* revert postbuild command
Description: Use of a same object property group for differents types between a
challenge and workingChallenge
workingChallenge use group as and id but this.challenge have a group
object
Fix: Wait for server response for challenge edit. Set this.challenge
from response and not directly from form data workingChallenge
* Refactoring & Feature: edit/delete group and challenge tasks
- Remove showOption from tasks props
- Pass all needed data to task for understand in mapGetter function which controls we should show
- Improve current solution with edit and delete logic
* Fix: this in template
* Fix & Test: extend tests, fix can Edit/Delete functions
* Fix: allow user edit challenge tasks on dashboard
* Fix: test case after code change
* fix import path
* Fix:
- Extend canEdit and canDelete functions with admin role
- Clarify canEdit and canDelete conditions
- Extend test cases
Antonio Sansotta