* WIP(groups): quickish wins
* WIP(groups): two quick wins
1. Don't show task creation button if user is not leader or manager
2. Don't require JS confirm() for approving tasks
* fix(group-plans): allow delete from options button
* fix(group-plans): update tasksOrder when task deleted
* fix(group-tasks): dismiss notification when user takes action
* refactor(tasks): DRY out create button styling
* fix(group-tasks): sync after claiming/unclaiming
* fix(claiming): better sync and notif handling
* fix(tasks): force sync instead of explicitly clearing notif
* fix(tasks): reposition task creation button
* fix(group-tasks): default to single completion
* fix(group-tasks): move completion condition field above approval switch
* fix(group-tasks): todo validation error and approval notif dismissal
* fix(group-tasks): default single completion on client
* fix(group-tasks): move completion condition up more
* fix(group-tasks): maintain client-side user assignment list
* fix(group-tasks): remove approval notifications when task deleted
* fix(group-tasks): send assigned task to top of task list
* fix(group-tasks): remove useless tag filter dropdown
* feat(group-tasks): notify user of assigned task
* fix(group-tasks): don't allow approval of tasks w/ no approval request
* fix(tests): adjust expectations
* fix(group-tasks): more sensible action on assignment notif click
* Add restart after rebirth
Page will be reloaded after purchasing "Orb of Rebirth"
* Remove restart after closing achievement
This reload is not needed, as the page now reloads immediately after purchasing "Orb of Rebirth"
* Move rebirth notification to modal
* Delete references to rebirth notification
* fix(purchasing): more number validation
* test(purchasing): add error cases
Also refactor NaN check and create client mixin
* fix(purchasing): cover "purchase" cases
* WIP(groups): quickish wins
* WIP(groups): two quick wins
1. Don't show task creation button if user is not leader or manager
2. Don't require JS confirm() for approving tasks
* fix(group-plans): allow delete from options button
* fix(group-plans): update tasksOrder when task deleted
* fix(group-tasks): dismiss notification when user takes action
* refactor(tasks): DRY out create button styling
* fix(group-tasks): sync after claiming/unclaiming
* use the same paging for "myChallenges" only loads 10 per call
* challenges: show loading above the load-more button (instead at the top)
* purple loading message and flat load-more button
* remove comment
* show loadMore button only when the request has 10 entries
* challenge card ui
* remove null/undefined entries from pinnedItems when an item is toggled - more inner checks + test
* drawer: fix when there isn't a page available
* rollback cleaning up pinnedEntries on item-toggle
* remove "re-setting" pinnedItems
* remove the filter
* catch promise rejection when user submits a message to group
* switch response exception handling to try/catch to avoid mixing aysnc/await with promises
* Several deps set to "optional" in lock file
This was done automatically when running `npm i` on Windows.
Node v10.15.2
NPM 6.4.1
* Begin working on issue #10687
Key files to look into:
- website/client/components/inventory/item.vue
- website/client/components/shops/market/sellModal.vue
File notes for me:
item.vue: provides wrapper for displaying item data.
sellModel.vue: for displaying items player intends to sell
- lines 10-21: check `item` computed property and load `item` component
- lines 151-153: ask how return line is evaluated to an `item`
The last one could be important to figuring out this caching issue.
Since the property is computed, it's possible that line is evaluating to
a truthy value that Vue is seeing as unchanged, even if the actual
`item` object is different each time.
* Pick up from sellModal.vue:155
This is where the item context seems to be set. The Vue dev tools
indicate that the `<item>` component is updating. It's only the `item`
reference inside of the `<sellModal>` component that isn't updating.
Issue #10687
* Remove (v-once) directive
This was preventing data referenced within nested elements from
updating.
Issue #10687
* Revert package-lock.json to "develop" version
This removes the "optional" settings that were automatically added by NPM to a handful of dependencies while working on PR #11044.
* Attempt to rerun tests
The most recent change shouldn't have caused tests to fail.
Sabe Jones