c3c2607bca
* fix(guilds): remove join retired public guild loophole * fix(groups): adjust test expectations and move some business logic back out of the controller * test(challenges): add cases related to public Guilds, Tavern and otherwise * fix(tests): more erroneously public test guilds, lint * fix(tests): still more setup tweaks * fix(lint): whitespace * fix(tests): couple more adjustments * fix(test): last challenge issue??
197 lines
6.6 KiB
JavaScript
197 lines
6.6 KiB
JavaScript
import { v4 as generateUUID } from 'uuid';
|
|
import {
|
|
generateUser,
|
|
generateChallenge,
|
|
createAndPopulateGroup,
|
|
translate as t,
|
|
} from '../../../../helpers/api-integration/v3';
|
|
import { model as Group } from '../../../../../website/server/models/group';
|
|
import { TAVERN_ID } from '../../../../../website/common/script/constants';
|
|
|
|
describe('POST /challenges/:challengeId/join', () => {
|
|
it('returns error when challengeId is not a valid UUID', async () => {
|
|
const user = await generateUser({ balance: 1 });
|
|
|
|
await expect(user.post('/challenges/test/join')).to.eventually.be.rejected.and.eql({
|
|
code: 400,
|
|
error: 'BadRequest',
|
|
message: t('invalidReqParams'),
|
|
});
|
|
});
|
|
|
|
it('returns error when challengeId is not for a valid challenge', async () => {
|
|
const user = await generateUser({ balance: 1 });
|
|
|
|
await expect(user.post(`/challenges/${generateUUID()}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('challengeNotFound'),
|
|
});
|
|
});
|
|
|
|
context('public Guild', () => {
|
|
let group;
|
|
let groupLeader;
|
|
let members;
|
|
let challenge;
|
|
before(async () => {
|
|
({ group, groupLeader, members } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: 'test group',
|
|
type: 'guild',
|
|
privacy: 'private',
|
|
},
|
|
members: 1,
|
|
upgradeToGroupPlan: true,
|
|
}));
|
|
challenge = await generateChallenge(groupLeader, group);
|
|
// Creation API is shut down, we need to simulate an extant public group
|
|
await Group.updateOne({ _id: group._id }, { $set: { privacy: 'public' }, $unset: { 'purchased.plan': 1 } }).exec();
|
|
});
|
|
|
|
it('returns error when challengeId is in an old public Guild', async () => {
|
|
const authorizedUser = members[0]; // eslint-disable-line prefer-destructuring
|
|
|
|
await expect(authorizedUser.post(`/challenges/${challenge._id}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('challengeNotFound'),
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Joining a valid challenge', () => {
|
|
let groupLeader;
|
|
let group;
|
|
let challenge;
|
|
let authorizedUser;
|
|
|
|
beforeEach(async () => {
|
|
const populatedGroup = await createAndPopulateGroup({
|
|
members: 1,
|
|
});
|
|
|
|
groupLeader = populatedGroup.groupLeader;
|
|
group = populatedGroup.group;
|
|
authorizedUser = populatedGroup.members[0]; // eslint-disable-line prefer-destructuring
|
|
|
|
challenge = await generateChallenge(groupLeader, group);
|
|
await groupLeader.post(`/challenges/${challenge._id}/join`);
|
|
});
|
|
|
|
it('returns an error when user isn\'t in the private group and isn\'t challenge leader', async () => {
|
|
const unauthorizedUser = await generateUser();
|
|
|
|
await expect(unauthorizedUser.post(`/challenges/${challenge._id}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('challengeNotFound'),
|
|
});
|
|
});
|
|
|
|
it('succeeds when user isn\'t in the private group but is challenge leader', async () => {
|
|
await groupLeader.post(`/challenges/${challenge._id}/leave`);
|
|
await groupLeader.post(`/groups/${group._id}/leave`);
|
|
await groupLeader.sync();
|
|
expect(groupLeader.guilds).to.be.empty; // check that leaving worked
|
|
|
|
const res = await groupLeader.post(`/challenges/${challenge._id}/join`);
|
|
expect(res.name).to.equal(challenge.name);
|
|
});
|
|
|
|
it('succeeds when it\'s a Tavern challenge, even if the user isn\'t a "member" of Tavern', async () => {
|
|
const tavern = await groupLeader.get(`/groups/${TAVERN_ID}`);
|
|
const tavernChallenge = await generateChallenge(groupLeader, tavern, { prize: 1 });
|
|
const generalUser = await generateUser();
|
|
|
|
const res = await generalUser.post(`/challenges/${tavernChallenge._id}/join`);
|
|
expect(res.name).to.equal(tavernChallenge.name);
|
|
});
|
|
|
|
it('returns challenge data', async () => {
|
|
const res = await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
expect(res.group).to.eql({
|
|
_id: group._id,
|
|
privacy: group.privacy,
|
|
name: group.name,
|
|
type: group.type,
|
|
});
|
|
expect(res.leader).to.eql({
|
|
_id: groupLeader._id,
|
|
id: groupLeader._id,
|
|
profile: { name: groupLeader.profile.name },
|
|
auth: {
|
|
local: {
|
|
username: groupLeader.auth.local.username,
|
|
},
|
|
},
|
|
flags: {
|
|
verifiedUsername: true,
|
|
},
|
|
});
|
|
expect(res.name).to.equal(challenge.name);
|
|
});
|
|
|
|
it('adds challenge to user challenges', async () => {
|
|
await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
await authorizedUser.sync();
|
|
|
|
expect(authorizedUser).to.have.property('challenges').to.include(challenge._id);
|
|
});
|
|
|
|
it('returns error when user has already joined the challenge', async () => {
|
|
await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
await expect(authorizedUser.post(`/challenges/${challenge._id}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('userAlreadyInChallenge'),
|
|
});
|
|
});
|
|
|
|
it('increases memberCount of challenge', async () => {
|
|
await challenge.sync();
|
|
const oldMemberCount = challenge.memberCount;
|
|
|
|
await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
await challenge.sync();
|
|
|
|
expect(challenge).to.have.property('memberCount', oldMemberCount + 1);
|
|
});
|
|
|
|
it('syncs challenge tasks to joining user', async () => {
|
|
const taskText = 'A challenge task text';
|
|
await groupLeader.post(`/tasks/challenge/${challenge._id}`, [
|
|
{ type: 'daily', text: taskText },
|
|
]);
|
|
|
|
await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
const tasks = await authorizedUser.get('/tasks/user');
|
|
const syncedTask = tasks.find(task => task.text === taskText);
|
|
|
|
expect(syncedTask.text).to.eql(taskText);
|
|
expect(syncedTask.isDue).to.exist;
|
|
expect(syncedTask.nextDue).to.exist;
|
|
});
|
|
|
|
it('adds challenge tag to user tags', async () => {
|
|
const userTagsLength = (await authorizedUser.get('/tags')).length;
|
|
|
|
await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
await expect(authorizedUser.get('/tags')).to.eventually.have.length(userTagsLength + 1);
|
|
});
|
|
|
|
it('awards achievement if this is user\'s first challenge', async () => {
|
|
await authorizedUser.post(`/challenges/${challenge._id}/join`);
|
|
|
|
await authorizedUser.sync();
|
|
expect(authorizedUser.achievements.joinedChallenge).to.be.true;
|
|
});
|
|
});
|
|
});
|