JSn1nj4
58c4fcd506
* Several deps set to "optional" in lock file This was done automatically when running `npm i` on Windows. Node v10.15.2 NPM 6.4.1 * Begin working on issue #10687 Key files to look into: - website/client/components/inventory/item.vue - website/client/components/shops/market/sellModal.vue File notes for me: item.vue: provides wrapper for displaying item data. sellModel.vue: for displaying items player intends to sell - lines 10-21: check `item` computed property and load `item` component - lines 151-153: ask how return line is evaluated to an `item` The last one could be important to figuring out this caching issue. Since the property is computed, it's possible that line is evaluating to a truthy value that Vue is seeing as unchanged, even if the actual `item` object is different each time. * Pick up from sellModal.vue:155 This is where the item context seems to be set. The Vue dev tools indicate that the `<item>` component is updating. It's only the `item` reference inside of the `<sellModal>` component that isn't updating. Issue #10687 * Remove (v-once) directive This was preventing data referenced within nested elements from updating. Issue #10687 * Revert package-lock.json to "develop" version This removes the "optional" settings that were automatically added by NPM to a handful of dependencies while working on PR #11044. * Attempt to rerun tests The most recent change shouldn't have caused tests to fail.
Running
For information about installing and running Habitica locally, see Setting up Habitica Locally.
Preparation Reading
-
Vue 2 (https://vuejs.org)
-
Webpack (https://webpack.github.io/) is the build system and it includes plugins for code transformation, right now we have: BabelJS for ES6 transpilation, eslint for code style, less and postcss for css compilation. The code comes from https://github.com/vuejs-templates/webpack which is a Webpack template for Vue, with some small modifications to adapt it to our use case. Docs http://vuejs-templates.github.io/webpack/
-
We're using
.vuefiles that make it possible to have HTML, JS and CSS for each component together in a single location. They're implemented as a webpack plugin and the docs can be found here http://vue-loader.vuejs.org/en/ -
SemanticUI is the UI framework http://semantic-ui.com/. So far I've only used the CSS part, it also has JS plugins but I've yet to use them. It supports theming so if it's not too difficult we'll want to customize the base theme with our own styles instead of writing CSS rules to override the original styling.
The code is in /website/client. We're using something very similar to Vuex (equivalent of React's Redux) for state management http://vuex.vuejs.org/en/index.html
The API is almost the same except that we don't use mutations but only actions because it would make it difficult to work with common code
The project is developed directly in the develop branch as long as we'll be able to avoid splitting it into a different branch.
So far most of the work has been on the template, so there's no complex logic to understand. The only thing I would suggest you to read about is Vuex for data management: it's basically a Flux implementation: there's a central store that hold the data for the entire app, and every change to the data must happen through an action, the data cannot be mutated directly.
For further resources, see Guidance for Blacksmiths, and in particular the "Website Technology Stack" section.