e9e4265545
commit 00affb306655a543f5d29b3af6361e686b577a97 Author: SabreCat <sabe@habitica.com> Date: Tue May 2 09:47:25 2023 -0500 fix(tests): account for invite limit changes commit 47661117f9fd661b8bc8f63b7cc7c8d5f8fa0fd7 Author: SabreCat <sabe@habitica.com> Date: Mon May 1 17:39:29 2023 -0500 fix(lfp): final polish commit 6a1e5af1db0dd90be3ced7e223f53c9183a206f5 Merge: 728ed2ddad9e0777bb42Author: SabreCat <sabe@habitica.com> Date: Mon May 1 16:54:12 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit 728ed2ddad7f0962d28f1ab0a271e3555b19296c Author: SabreCat <sabe@habitica.com> Date: Thu Apr 27 16:51:06 2023 -0500 fix(lfp): loading layout and page visit event commit 8a56ab329bff922e05963e3ef78fbc26ff273924 Author: SabreCat <sabe@habitica.com> Date: Wed Apr 26 16:54:46 2023 -0500 fix(faq): copy and style updates commit 6fd00d7f30150a1802e5a37edbb914ef120caf9a Author: SabreCat <sabe@habitica.com> Date: Fri Apr 21 17:12:52 2023 -0500 feat(lfp): fixes, analytics, FAQ commit 4b5d7304ad7cfc5f72320b23456ed2898e53caac Author: SabreCat <sabe@habitica.com> Date: Mon Apr 17 15:13:03 2023 -0500 fix(lfp): smol tweaks commit 9a5476a2558eb17a603f4aae1b5b2d35773be8b4 Author: SabreCat <sabe@habitica.com> Date: Thu Apr 13 16:03:33 2023 -0500 feat(lfp): refresh button commit aa58f5018469f38a9a9d31c3bffa26bb88a8c672 Merge: bbb03d006ec8adf20804Author: SabreCat <sabe@habitica.com> Date: Tue Apr 11 17:44:56 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit bbb03d006e8b122bb7206bdc778a31de422167bb Author: SabreCat <sabe@habitica.com> Date: Tue Apr 4 18:30:50 2023 -0500 fix(lint): whitespace and const commit 23683ad29a4cce0b0da061ad6c030982034c0a9c Author: SabreCat <sabe@habitica.com> Date: Tue Apr 4 17:02:57 2023 -0500 chore(LFP): add analytics also re-fix loading state commit 4477d84f5266c87f5583368029b72153f00f0568 Author: SabreCat <sabe@habitica.com> Date: Mon Apr 3 16:24:26 2023 -0500 fix(LFP): address issues with loading commit bdc5154f24bb5e50963376c3c0c9cc73c0b05ccc Merge: 81923eef6f229ed46425Author: SabreCat <sabe@habitica.com> Date: Mon Apr 3 15:58:12 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit 81923eef6f0c627d079475a28f9d93d8e4628934 Author: SabreCat <sabe@habitica.com> Date: Thu Mar 30 16:44:49 2023 -0500 feat(LFP): release candidate commit fe1f8939fc6b09d36cfaf0b6e5838df04e41009d Author: SabreCat <sabe@habitica.com> Date: Wed Mar 29 17:35:54 2023 -0500 WIP(LFP): fixes commit afc361f5a9f806cbd814ad910d1274e3a6609efd Merge: d6b5cbdebc7ede3acd01Author: SabreCat <sabe@habitica.com> Date: Wed Mar 29 16:24:39 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit d6b5cbdebc2829e9325ea57fb5deeccc128c1635 Author: SabreCat <sabe@habitica.com> Date: Tue Mar 28 16:13:18 2023 -0500 WIP(LFP): change copy, add close X, fix API response commit 4274a4625862351ef0ecf33c8a3249ca5ebec7cb Author: SabreCat <sabe@habitica.com> Date: Mon Mar 27 17:07:36 2023 -0500 fix(LFP): layout, unset when stopping commit 95abfcfa5f13c9cce6385206947a47f85b76d11d Merge: 4a360eedd853c536b525Author: SabreCat <sabe@habitica.com> Date: Mon Mar 27 16:32:46 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit 4a360eedd8b9cf41d3a0fe7a4cfaa72c5bd7bd26 Author: SabreCat <sabe@habitica.com> Date: Thu Mar 23 16:54:49 2023 -0500 feat(LFP): completed style and infinite scroll commit bbc439d9d03c9631a450236eb33af66f0428fa50 Author: SabreCat <sabe@habitica.com> Date: Tue Mar 21 10:40:26 2023 -0500 WIP(LFP): nicer layout, buffs fix commit 1658688597456663477ab19da61ae1b9bc85cf2a Merge: 664507434f027e61a93eAuthor: SabreCat <sabe@habitica.com> Date: Tue Mar 21 09:29:02 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit 664507434f2f76e6bf3b61cdc9e3daddb81204af Author: SabreCat <sabe@habitica.com> Date: Fri Mar 17 17:13:08 2023 -0500 WIP(LFP): API and client adjustments commit 2f0b6f2517f9e2d634cb23ee303cfb4542e998ce Merge: 0db1704325a16098ccdaAuthor: SabreCat <sabe@habitica.com> Date: Fri Mar 17 16:45:13 2023 -0500 Merge branch 'release' into sabrecat/party-seeking commit 0db1704325c3555f0b5d9c8d1dfc44177e90c093 Author: SabreCat <sabe@habitica.com> Date: Mon Mar 13 14:48:10 2023 -0500 fix(modal): scrollbar for squashed viewports commit 733c35192e0a4e31e1bebfdd7488cfc1f7587f36 Author: SabreCat <sabe@habitica.com> Date: Thu Mar 9 12:51:02 2023 -0600 WIP(party): seekers functional rough commit d4b854410b557db26eec6e6a26b6d174c02cee3a Merge: 7fe919825a0b6b967753Author: SabreCat <sabe@habitica.com> Date: Thu Mar 9 10:07:28 2023 -0600 Merge branch 'release' into sabrecat/party-seeking commit 7fe919825abfb6d518cb93b91f5997d3831bd0b5 Author: SabreCat <sabe@habitica.com> Date: Thu Mar 2 14:40:09 2023 -0600 feat(party): several adjustments to seeking feature commit c93900efcf925f7aaa4c4cb56b4451f19adfb1b3 Author: SabreCat <sabe@habitica.com> Date: Wed Mar 1 20:37:11 2023 -0600 feat(party): initial Seeking API commit 8bb784daeceb14c23992a6f3af1054a900fc26c1 Merge: e19a661a21f327795761Author: SabreCat <sabe@habitica.com> Date: Wed Mar 1 18:58:20 2023 -0600 Merge branch 'release' into sabrecat/party-seeking commit e19a661a2163a50307a286379bffb44201ed392e Author: SabreCat <sabe@habitica.com> Date: Fri Feb 24 15:51:42 2023 -0600 WIP(parties): add seeking flag and modal toggle
334 lines
12 KiB
JavaScript
334 lines
12 KiB
JavaScript
import { v4 as generateUUID } from 'uuid';
|
|
import {
|
|
generateUser,
|
|
createAndPopulateGroup,
|
|
checkExistence,
|
|
translate as t,
|
|
} from '../../../../helpers/api-integration/v3';
|
|
|
|
describe('POST /group/:groupId/join', () => {
|
|
const PET_QUEST = 'whale';
|
|
|
|
it('returns error when groupId is not for a valid group', async () => {
|
|
const joiningUser = await generateUser();
|
|
|
|
await expect(joiningUser.post(`/groups/${generateUUID()}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 404,
|
|
error: 'NotFound',
|
|
message: t('groupNotFound'),
|
|
});
|
|
});
|
|
|
|
context('Joining a public guild', () => {
|
|
let user; let joiningUser; let
|
|
publicGuild;
|
|
|
|
beforeEach(async () => {
|
|
const { group, groupLeader } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: 'Test Guild',
|
|
type: 'guild',
|
|
privacy: 'public',
|
|
},
|
|
});
|
|
|
|
publicGuild = group;
|
|
user = groupLeader;
|
|
joiningUser = await generateUser();
|
|
});
|
|
|
|
it('allows non-invited users to join public guilds', async () => {
|
|
const res = await joiningUser.post(`/groups/${publicGuild._id}/join`);
|
|
|
|
await expect(joiningUser.get('/user')).to.eventually.have.property('guilds').to.include(publicGuild._id);
|
|
expect(res.leader._id).to.eql(user._id);
|
|
expect(res.leader.profile.name).to.eql(user.profile.name);
|
|
});
|
|
|
|
it('returns an error if user was already a member', async () => {
|
|
await joiningUser.post(`/groups/${publicGuild._id}/join`);
|
|
await expect(joiningUser.post(`/groups/${publicGuild._id}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('youAreAlreadyInGroup'),
|
|
});
|
|
});
|
|
|
|
it('promotes joining member in a public empty guild to leader', async () => {
|
|
await user.post(`/groups/${publicGuild._id}/leave`);
|
|
|
|
await joiningUser.post(`/groups/${publicGuild._id}/join`);
|
|
|
|
await expect(joiningUser.get(`/groups/${publicGuild._id}`)).to.eventually.have.nested.property('leader._id', joiningUser._id);
|
|
});
|
|
|
|
it('increments memberCount when joining guilds', async () => {
|
|
const oldMemberCount = publicGuild.memberCount;
|
|
|
|
await joiningUser.post(`/groups/${publicGuild._id}/join`);
|
|
|
|
await expect(joiningUser.get(`/groups/${publicGuild._id}`)).to.eventually.have.property('memberCount', oldMemberCount + 1);
|
|
});
|
|
|
|
it('awards Joined Guild achievement', async () => {
|
|
await joiningUser.post(`/groups/${publicGuild._id}/join`);
|
|
|
|
await expect(joiningUser.get('/user')).to.eventually.have.nested.property('achievements.joinedGuild', true);
|
|
});
|
|
});
|
|
|
|
context('Joining a private guild', () => {
|
|
let user; let invitedUser; let
|
|
guild;
|
|
|
|
beforeEach(async () => {
|
|
const { group, groupLeader, invitees } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: 'Test Guild',
|
|
type: 'guild',
|
|
privacy: 'private',
|
|
},
|
|
invites: 1,
|
|
});
|
|
|
|
guild = group;
|
|
user = groupLeader;
|
|
invitedUser = invitees[0]; // eslint-disable-line prefer-destructuring
|
|
});
|
|
|
|
it('returns error when user is not invited to private guild', async () => {
|
|
const userWithoutInvite = await generateUser();
|
|
|
|
await expect(userWithoutInvite.post(`/groups/${guild._id}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('messageGroupRequiresInvite'),
|
|
});
|
|
});
|
|
|
|
context('User is invited', () => {
|
|
it('allows invited user to join private guilds', async () => {
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
await expect(invitedUser.get('/user')).to.eventually.have.property('guilds').to.include(guild._id);
|
|
});
|
|
|
|
it('clears invitation from user when joining guilds', async () => {
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
await expect(invitedUser.get('/user'))
|
|
.to.eventually.have.nested.property('invitations.guilds')
|
|
.to.not.include({ id: guild._id });
|
|
});
|
|
|
|
it('increments memberCount when joining guilds', async () => {
|
|
const oldMemberCount = guild.memberCount;
|
|
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
await expect(invitedUser.get(`/groups/${guild._id}`)).to.eventually.have.property('memberCount', oldMemberCount + 1);
|
|
});
|
|
|
|
it('does not give basilist quest to inviter when joining a guild', async () => {
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
await expect(user.get('/user')).to.eventually.not.have.nested.property('items.quests.basilist');
|
|
});
|
|
|
|
it('does not increment basilist quest count to inviter with basilist when joining a guild', async () => {
|
|
await user.update({ 'items.quests.basilist': 1 });
|
|
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
await expect(user.get('/user')).to.eventually.have.nested.property('items.quests.basilist', 1);
|
|
});
|
|
|
|
it('notifies inviting user that their invitation was accepted', async () => {
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
const inviter = await user.get('/user');
|
|
const expectedData = {
|
|
headerText: t('invitationAcceptedHeader'),
|
|
bodyText: t('invitationAcceptedBody', {
|
|
username: invitedUser.auth.local.username,
|
|
groupName: guild.name,
|
|
}),
|
|
};
|
|
|
|
expect(inviter.notifications[1].type).to.eql('GROUP_INVITE_ACCEPTED');
|
|
expect(inviter.notifications[1].data).to.eql(expectedData);
|
|
});
|
|
|
|
it('awards Joined Guild achievement', async () => {
|
|
await invitedUser.post(`/groups/${guild._id}/join`);
|
|
|
|
await expect(invitedUser.get('/user')).to.eventually.have.nested.property('achievements.joinedGuild', true);
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Joining a party', () => {
|
|
let user; let invitedUser; let
|
|
party;
|
|
|
|
beforeEach(async () => {
|
|
const { group, groupLeader, invitees } = await createAndPopulateGroup({
|
|
groupDetails: {
|
|
name: 'Test Party',
|
|
type: 'party',
|
|
},
|
|
members: 2,
|
|
invites: 1,
|
|
});
|
|
|
|
party = group;
|
|
user = groupLeader;
|
|
invitedUser = invitees[0]; // eslint-disable-line prefer-destructuring
|
|
});
|
|
|
|
it('returns error when user is not invited to party', async () => {
|
|
const userWithoutInvite = await generateUser();
|
|
|
|
await expect(userWithoutInvite.post(`/groups/${party._id}/join`)).to.eventually.be.rejected.and.eql({
|
|
code: 401,
|
|
error: 'NotAuthorized',
|
|
message: t('messageGroupRequiresInvite'),
|
|
});
|
|
});
|
|
|
|
context('User is invited', () => {
|
|
it('allows invited user to join party', async () => {
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await expect(invitedUser.get('/user')).to.eventually.have.nested.property('party._id', party._id);
|
|
});
|
|
|
|
it('Issue #12291: accepting a redundant party invite will let the user stay in the party', async () => {
|
|
await invitedUser.update({
|
|
'party._id': party._id,
|
|
});
|
|
await expect(invitedUser.get('/user')).to.eventually.have.nested.property('party._id', party._id);
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await expect(invitedUser.get('/user')).to.eventually.have.nested.property('party._id', party._id);
|
|
});
|
|
|
|
it('notifies inviting user that their invitation was accepted', async () => {
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
const inviter = await user.get('/user');
|
|
|
|
const expectedData = {
|
|
headerText: t('invitationAcceptedHeader'),
|
|
bodyText: t('invitationAcceptedBody', {
|
|
username: invitedUser.auth.local.username,
|
|
groupName: party.name,
|
|
}),
|
|
};
|
|
|
|
expect(inviter.notifications[0].type).to.eql('GROUP_INVITE_ACCEPTED');
|
|
expect(inviter.notifications[0].data).to.eql(expectedData);
|
|
});
|
|
|
|
it('clears invitation from user when joining party', async () => {
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await expect(invitedUser.get('/user')).to.eventually.not.have.nested.property('invitations.parties[0].id');
|
|
});
|
|
|
|
it('increments memberCount when joining party', async () => {
|
|
const oldMemberCount = party.memberCount;
|
|
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await expect(invitedUser.get(`/groups/${party._id}`)).to.eventually.have.property('memberCount', oldMemberCount + 1);
|
|
});
|
|
|
|
it('gives basilist quest item to the inviter when joining a party', async () => {
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await expect(user.get('/user')).to.eventually.have.nested.property('items.quests.basilist', 1);
|
|
});
|
|
|
|
it('increments basilist quest item count to inviter when joining a party', async () => {
|
|
await user.update({ 'items.quests.basilist': 1 });
|
|
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await expect(user.get('/user')).to.eventually.have.nested.property('items.quests.basilist', 2);
|
|
});
|
|
|
|
it('invites joining member to active quest', async () => {
|
|
await user.update({
|
|
[`items.quests.${PET_QUEST}`]: 1,
|
|
});
|
|
await user.post(`/groups/${party._id}/quests/invite/${PET_QUEST}`);
|
|
|
|
await invitedUser.post(`/groups/${party._id}/join`);
|
|
|
|
await invitedUser.sync();
|
|
await party.sync();
|
|
|
|
expect(invitedUser).to.have.nested.property('party.quest.RSVPNeeded', true);
|
|
expect(invitedUser).to.have.nested.property('party.quest.key', party.quest.key);
|
|
expect(party.quest.members[invitedUser._id]).to.be.null;
|
|
});
|
|
});
|
|
});
|
|
|
|
context('Party incentive achievements', () => {
|
|
let leader; let member; let
|
|
party;
|
|
|
|
beforeEach(async () => {
|
|
leader = await generateUser();
|
|
member = await generateUser();
|
|
party = await leader.post('/groups', {
|
|
name: 'Testing Party',
|
|
type: 'party',
|
|
});
|
|
|
|
await leader.post(`/groups/${party._id}/invite`, {
|
|
uuids: [member._id],
|
|
});
|
|
await member.post(`/groups/${party._id}/join`);
|
|
});
|
|
|
|
it('awards Party Up achievement to party of size 2', async () => {
|
|
await member.sync();
|
|
await leader.sync();
|
|
|
|
expect(member).to.have.nested.property('achievements.partyUp', true);
|
|
expect(member.notifications.find(notification => notification.type === 'ACHIEVEMENT_PARTY_UP')).to.exist;
|
|
expect(leader).to.have.nested.property('achievements.partyUp', true);
|
|
expect(leader.notifications.find(notification => notification.type === 'ACHIEVEMENT_PARTY_UP')).to.exist;
|
|
});
|
|
|
|
it('does not award Party On achievement to party of size 2', async () => {
|
|
await member.sync();
|
|
await leader.sync();
|
|
|
|
expect(member).to.not.have.nested.property('achievements.partyOn');
|
|
expect(leader).to.not.have.nested.property('achievements.partyOn');
|
|
});
|
|
|
|
it('awards Party On achievement to party of size 4', async () => {
|
|
const addlMemberOne = await generateUser();
|
|
const addlMemberTwo = await generateUser();
|
|
await leader.post(`/groups/${party._id}/invite`, {
|
|
uuids: [addlMemberOne._id, addlMemberTwo._id],
|
|
});
|
|
await addlMemberOne.post(`/groups/${party._id}/join`);
|
|
await addlMemberTwo.post(`/groups/${party._id}/join`);
|
|
|
|
await member.sync();
|
|
await leader.sync();
|
|
|
|
expect(member).to.have.nested.property('achievements.partyOn', true);
|
|
expect(member.notifications.find(notification => notification.type === 'ACHIEVEMENT_PARTY_ON')).to.exist;
|
|
expect(leader).to.have.nested.property('achievements.partyOn', true);
|
|
expect(leader.notifications.find(notification => notification.type === 'ACHIEVEMENT_PARTY_ON')).to.exist;
|
|
});
|
|
});
|
|
});
|