Kai/habitica
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change condition scope to fix updating for public guilds with a member count of 1

Browse Source
This commit is contained in:
TheHollidayInn
2015-09-04 16:42:35 -05:00
parent 700a6ddd9e
commit b839c0cd0c
1 changed files with 25 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
website/src/controllers/groups.js
+25 -24
View File
@@ -574,30 +574,31 @@ api.leave = function(req, res, next) {
}
update['$inc'] = {memberCount: -1};
Group.update({_id:group._id}, update, cb);
} else if (group.members.length === 1) {
//We don't delete public groups when they are empty
if (group.privacy === 'private' || group.type === 'party') {
async.waterfall([
function(cb2) {
User.find({
'invitations.guilds.id': group._id
}, cb2);
},
function(users, cb2) {
if (users) {
users.forEach(function (user, index, array) {
var i = _.findIndex(user.invitations.guilds, {id: group._id});
user.invitations.guilds.splice(i, 1);
user.save();
});
}
cb2();
},
function(cb2) {
Group.remove({_id:group._id}, cb2);
},
], cb);
}
}
if (group.members.length === 1 && (group.privacy === 'private' || group.type === 'party') ) {
async.waterfall([
function(cb2) {
User.find({
'invitations.guilds.id': group._id
}, cb2);
},
function(users, cb2) {
if (users) {
users.forEach(function (user, index, array) {
var i = _.findIndex(user.invitations.guilds, {id: group._id});
user.invitations.guilds.splice(i, 1);
user.save();
});
}
cb2();
},
function(cb2) {
Group.remove({_id:group._id}, cb2);
},
], cb);
} else {
update['$inc'] = {memberCount: -1};
Group.update({_id:group._id}, update, cb);
}
}
],function(err){