some bug-fixes & cleanup on removal of _view.*

src/app/index.coffee

@@ -22,9 +22,6 @@ _ = require('underscore')
 get '/', (page, model, params, next) ->
   return page.redirect '/' if page.params?.query?.play?
 
-  # temporary view variables, so we don't call model.set() too fast
-  _view = model.get '_view' || {}
-
   # Force SSL # NOTE handled by ngix now
   #req = page._res.req
   #if req.headers['x-forwarded-proto']!='https' and process.env.NODE_ENV=='production'
@@ -35,7 +32,6 @@ get '/', (page, model, params, next) ->
     user.setNull('apiToken', derby.uuid())
 
     require('./items').server(model)
-    model.set '_view', _view
 
     #refLists
     _.each ['habit', 'daily', 'todo', 'reward'], (type) ->
@@ -61,6 +57,6 @@ ready (model) ->
   require('./profile').app(exports, model)
   require('./pets').app(exports, model)
   require('../server/private').app(exports, model)
-  require('./debug').app(exports, model) if model.get('_nodeEnv') != 'production'
+  require('./debug').app(exports, model) if model.flags.nodeEnv != 'production'
   require('./browser').app(exports, model, app)
 

src/server/middleware.coffee

@@ -7,11 +7,9 @@ module.exports.splash = (req, res, next) ->
 
 module.exports.view = (req, res, next) ->
   model = req.getModel()
-  _view = model.get('_view') || {}
   ## Set _mobileDevice to true or false so view can exclude portions from mobile device
-  _mobileDevice = /Android|webOS|iPhone|iPad|iPod|BlackBerry/i.test(req.header 'User-Agent')
-  _nodeEnv = process.env.NODE_ENV
-  model.set '_view', _view
+  model.set '_mobileDevice', /Android|webOS|iPhone|iPad|iPod|BlackBerry/i.test(req.header 'User-Agent')
+  model.set '_nodeEnv', model.flags.nodeEnv
   next()
 
 #CORS middleware

src/server/private.coffee

@@ -10,7 +10,6 @@ module.exports.app = (appExports, model) ->
 
   appExports.showStripe = (e, el) ->
     token = (res) ->
-      console.log(res);
       $.ajax({
          type: "POST",
          url: "/charge",

src/server/static.coffee

@@ -8,10 +8,10 @@ derby = require 'derby'
 staticPages = derby.createStatic path.dirname(path.dirname(__dirname))
 
 beforeEach = (req, res, next) ->
-  req.getModel().set '_view', {nodeEnv: 'production'} # we don't want cheat buttons on static pages
+  req.getModel().set '_nodeEnv', 'production' # we don't want cheat buttons on static pages
   next()
 
-router.get '/splash.html', (req, res) -> return res.redirect('/static/front')
+router.get '/splash.html', (req, res) -> res.redirect('/static/front')
 router.get '/static/front',   beforeEach, (req, res) -> staticPages.render 'static/front', res
 router.get '/static/about',    (req, res) -> res.redirect 'http://community.habitrpg.com/node/97'
 router.get '/static/team',    (req, res) -> res.redirect 'http://community.habitrpg.com/node/96'